[GitHub] kafka pull request: KAFKA-3587 Improve logic to build offsetMap in...

2016-05-06 Thread alekar
GitHub user alekar opened a pull request: https://github.com/apache/kafka/pull/1329 KAFKA-3587 Improve logic to build offsetMap in log.Cleaner. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alekar/kafka trunk Alternatively

[GitHub] kafka pull request: KAFKA-3587 Improve logic to build offsetMap in...

2016-05-06 Thread alekar
Github user alekar closed the pull request at: https://github.com/apache/kafka/pull/1329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-05 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manas Alekar updated KAFKA-3587: Attachment: 0001-POC-improving-deduping-segments.patch > LogCleaner fails due to incorrect off

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-05 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273293#comment-15273293 ] Manas Alekar commented on KAFKA-3587: - I have attached a patch which explains

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-05 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273325#comment-15273325 ] Manas Alekar commented on KAFKA-3587: - It was easier to explain a fix in code tha

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-05 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273466#comment-15273466 ] Manas Alekar commented on KAFKA-3587: - [~ecomar] I used 1/2 because the worst

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-05 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273481#comment-15273481 ] Manas Alekar commented on KAFKA-3587: - 1. I believe this should happen when

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-05 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273626#comment-15273626 ] Manas Alekar commented on KAFKA-3587: - [~junrao] That will create the same pair

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-06 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274483#comment-15274483 ] Manas Alekar commented on KAFKA-3587: - The issue with just building the map til

[jira] [Issue Comment Deleted] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-06 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manas Alekar updated KAFKA-3587: Comment: was deleted (was: The issue with just building the map till it is full as proposed in pull

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-06 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274500#comment-15274500 ] Manas Alekar commented on KAFKA-3587: - The issue with just building the map til

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-06 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274513#comment-15274513 ] Manas Alekar commented on KAFKA-3587: - [~guozhang] Like your idea, I'll wa

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-06 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274534#comment-15274534 ] Manas Alekar commented on KAFKA-3587: - [~junrao] During cleaning the offset store