Re: [DISCUSS] Minimum constraint for segment.ms

2024-04-09 Thread Tommi Vainikainen
Hi, I support changing constraints for mentioned settings. I've noticed that first producing big messages, and then setting `segment.bytes` to low value causes unwanted consequences. I did not notice that it would delete all the records, but I did not set it to one, but instead the case is within

Re: [DISCUSS] Minimum constraint for segment.ms

2024-10-30 Thread Tommi Vainikainen
Hi, I've noticed that similar to these already mentioned settings also segment.index.bytes has a minimum value of 4. This conflicts with OffsetIndex, which throws `java.lang.IllegalArgumentException: Invalid max index size: 4` with such settings, because hard-coded entry size in OffsetIndex is 8.

Re: [DISCUSS] Minimum constraint for segment.ms

2024-11-01 Thread Tommi Vainikainen
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1030%3A+Change+constraints+and+default+values+for+various+configurations > and will try to get this KIP out of draft stage next week (so that we can > hit the 4.0 KIP freeze timeline of 20th Nov). > > -- > Divij Vaidya > >

Re: [DISCUSS] KIP-1030: Change constraints and default values for various configurations

2024-11-20 Thread Tommi Vainikainen
Hi, This proposal looks good to me with new defaults and constraints. About breaking backward compatibility I've question on how you see it best handled in case someone upgrades Kafka cluster from 3.9 to 4.0 with let's say one topic having segment.bytes=500 kb (new min is 1 MB). Does it mean that

Re: [DISCUSS] Does changing help messages for tools require a KIP?

2025-01-09 Thread Tommi Vainikainen
Hi, In my opinion the documentation should not follow the notation of Java library formatter, but simply ISO 8601 format. The standard ISO 8601 format would be actually '-MM-DDThh:mm:ss.sss' (lower case hours and seconds). The documentation is for Kafka users, and Kafka users do not need to k

Re: KAFKA-2526: command line --producer-property wins

2025-05-29 Thread Tommi Vainikainen
Hi, The proposed standardization of property priority is a good improvement and looks clear to me. One convenience issue I'd like to point out is that almost all command line tools currently define --bootstrap-server as a required command line argument. However if one needs to pass e.g. SSL for a

[jira] [Created] (KAFKA-17375) Partition reassignment cannot proceed after segment.bytes change

2024-08-20 Thread Tommi Vainikainen (Jira)
Tommi Vainikainen created KAFKA-17375: - Summary: Partition reassignment cannot proceed after segment.bytes change Key: KAFKA-17375 URL: https://issues.apache.org/jira/browse/KAFKA-17375 Project

[jira] [Created] (KAFKA-12893) MM2 fails to replicate if starting two+ nodes same time

2021-06-04 Thread Tommi Vainikainen (Jira)
Tommi Vainikainen created KAFKA-12893: - Summary: MM2 fails to replicate if starting two+ nodes same time Key: KAFKA-12893 URL: https://issues.apache.org/jira/browse/KAFKA-12893 Project: Kafka