Re: [VOTE] 2.1.0 RC0

2018-10-24 Thread Ted Yu
+1 InternalTopicIntegrationTest failed during test suite run but passed with rerun. On Wed, Oct 24, 2018 at 3:48 AM Andras Beni wrote: > +1 (non-binding) > > Verified signatures and checksums of release artifacts > Performed quickstart steps on rc artifacts (both scala 2.11 and 2.12) and > one

Re: Java 10 replacing Java 9 in Jenkins for trunk

2018-05-05 Thread Ted Yu
In PR build, I noticed the following ( https://builds.apache.org/job/kafka-pr-jdk10-scala2.12/622/console) : *02:32:11* :clients:compileJava/home/jenkins/jenkins-slave/workspace/kafka-pr-jdk10-scala2.12/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:1262: error: lambda

Re: [DISCUSS] KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization

2018-05-07 Thread Ted Yu
Which JIRA is for the Topology Optimization itself ? Thanks On Mon, May 7, 2018 at 10:26 AM, Bill Bejeck wrote: > All, > I'd like to start a discussion about adding a configuration parameter > allowing for the forthcoming topology optimization to be optional via > configuration. > > > The KIP c

Re: [DISCUSS] KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization

2018-05-07 Thread Ted Yu
bling part of the optimizations in the future? > > > Hi Ted, > > The cover JIRA for topology optimization can be found here: > https://issues.apache.org/jira/browse/KAFKA-6034 > > > Guozhang > > > On Mon, May 7, 2018 at 11:04 AM, Ted Yu wrote: > > > Which JIRA

Re: [DISCUSS] KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization

2018-05-08 Thread Ted Yu
ot a choice of which    optimizations to have, they are performed automatically. Does this make sense? On Mon, May 7, 2018 at 7:49 PM, Ted Yu wrote: > There are 4 subtasks for KAFKA-6034 > > If each optimization can be switched on/off, there should be 4 enums for > the switch. > &g

Re: [VOTE] KIP-294 - Enable TLS hostname verification by default

2018-05-09 Thread Ted Yu
+1 On Wed, May 9, 2018 at 8:28 AM, Rajini Sivaram wrote: > Hi all, > > Since there have been no objections on this straightforward KIP, I would > like to initiate the voting process. KIP-294 proposes to use a secure > default value for endpoint identification when using SSL as the security > pro

Re: Use of a formatter like Scalafmt

2018-05-09 Thread Ted Yu
Applying the tool across code base would result in massive changes. How would this be handled ? Original message From: Joan Goyeau Date: 5/9/18 3:31 PM (GMT-08:00) To: dev@kafka.apache.org Subject: Use of a formatter like Scalafmt Hi, Contributing to Kafka Streams' Scala API

Re: Can anyone take a look at this KIP and Jira?

2018-05-10 Thread Ted Yu
Since the change is internal to *SensorAccess class, looks like KIP is not required.* On Thu, May 10, 2018 at 11:54 AM, qingjun wu wrote: > Dear Kafka Developers, > > I opened a KIP and also a Jira ticket related to this. Can you please take > a look? It should be simple change to Kafka, but it

Re: [VOTE] KIP-278: Add version option to Kafka's commands

2018-05-10 Thread Ted Yu
+1 On Thu, May 10, 2018 at 6:42 PM, Sasaki Toru wrote: > Hi all, > > I would like to start the vote on KIP-278: Add version option to Kafka's > commands. > > The link to this KIP is here: > +Add+version+option+to+Kafka%27s+commands>

Re: [VOTE] KIP-292: Add KTable#transformValues() method in Kafka Streams DSL

2018-05-11 Thread Ted Yu
+1 On Fri, May 11, 2018 at 2:16 PM, Guozhang Wang wrote: > +1 (binding) > > Also slightly changed the title beyond changing [DISCUSS] to [VOTE] since > Gmail will collapse these two threads into one, so people may not realize > there is a voting started already. > > > Guozhang > > > On Fri, May

Re: [VOTE] KIP-244: Add Record Header support to Kafka Streams

2018-05-14 Thread Ted Yu
+1 On Mon, May 14, 2018 at 8:31 AM, Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Hi everyone, > > I would like to start a vote on KIP-244: Add Record Header support to Kafka > Streams > > KIP wiki page: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 244%3A+Add+Rec

Re: [VOTE] KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization

2018-05-15 Thread Ted Yu
+1 Original message From: Guozhang Wang Date: 5/15/18 2:34 PM (GMT-08:00) To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization +1 (binding). On Tue, May 15, 2018 at 2:16 PM, Matthias J. Sax wrote: > +1

Re: [VOTE] KIP-285: Connect Rest Extension Plugin

2018-05-17 Thread Ted Yu
+1 Original message From: Gwen Shapira Date: 5/17/18 12:02 PM (GMT-08:00) To: dev Subject: Re: [VOTE] KIP-285: Connect Rest Extension Plugin LGTM. +1. On Wed, May 16, 2018 at 8:19 PM, Magesh Nandakumar wrote: > Hello everyone, > > After a good round of discussions with ex

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-17 Thread Ted Yu
+1 Original message From: Gwen Shapira Date: 5/17/18 11:53 AM (GMT-08:00) To: dev Subject: Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink Yay, its about time :) +1 On Thu, May 17, 2018 at 12:38 PM, Guozhang Wang wrote: > Hello folks, > >

Re: [VOTE] KIP-297: Externalizing Secrets for Connect Configurations

2018-05-17 Thread Ted Yu
+1 Original message From: Magesh Nandakumar Date: 5/17/18 6:05 PM (GMT-08:00) To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-297: Externalizing Secrets for Connect Configurations Thanks Robert, this looks great +1 (non-binding) On Thu, May 17, 2018 at 5:35 PM, Colin McCa

Re: [DISCUSS] KIP-290: Support for wildcard suffixed ACLs

2018-05-21 Thread Ted Yu
+1 Original message From: Stephane Maarek Date: 5/21/18 3:15 AM (GMT-08:00) To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-290: Support for wildcard suffixed ACLs +1 non binding On Mon., 21 May 2018, 2:44 pm Rajini Sivaram, wrote: > Hi Piyush, Thanks for the KIP! > >

Re: [VOTE] KIP-306: Configuration for Delaying Response to Failed Client Authentication

2018-05-21 Thread Ted Yu
+1 On Mon, May 21, 2018 at 9:02 AM, Guozhang Wang wrote: > Thanks Dhruvil for the KIP, +1 from me (binding). > > > Guozhang > > On Mon, May 21, 2018 at 7:52 AM, Dhruvil Shah > wrote: > > > Hi, > > > > I would like to start a vote on KIP-306 which proposes to add a > > configuration to delay res

Re: [VOTE] KIP-305: Add Connect primitive number converters

2018-05-22 Thread Ted Yu
+1 On Tue, May 22, 2018 at 9:19 AM, Randall Hauch wrote: > I'd like to start a vote of a very straightforward proposal for Connect to > add converters for the basic primitive number types: integer, short, long, > double, and float that reuse Kafka's corresponding serdes. Here is the KIP: > > htt

Re: [VOTE] KIP-176: Remove deprecated new-consumer option for tools

2018-05-23 Thread Ted Yu
lgtm On Wed, May 23, 2018 at 9:04 AM, Paolo Patierno wrote: > Sorry ... I hope it's not too late but I created the KIP-176 on September > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 176%3A+Remove+deprecated+new-consumer+option+for+tools > > but due to be a breaking change, I neede

Re: [DISCUSS] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-05-23 Thread Ted Yu
introduced an error code for the scenario described. --Vahid From:   Ted Yu To: dev@kafka.apache.org Date:   04/27/2018 04:31 PM Subject:    Re: [DISCUSS] KIP-289: Improve the default group id behavior in KafkaConsumer bq. If they attempt an offset commit they will receive an error. Can

Re: Load testing Apche kafka usimh jmeter

2018-05-27 Thread Ted Yu
Have you seen this ? https://dzone.com/articles/apache-kafka-how-to-load-test-with-jmeter There is also: https://github.com/BrightTag/kafkameter On Fri, May 25, 2018 at 1:36 AM, Vihar Nani wrote: > Hi Team, > > Can anyone help me with steps of integrating Apche kafa with Apche Jmeter? > > I h

Re: [VOTE] KIP-264: Add a consumer metric to record raw fetch size

2018-05-27 Thread Ted Yu
lgtm On Fri, May 25, 2018 at 10:51 AM, Vahid S Hashemian < vahidhashem...@us.ibm.com> wrote: > In the absence of additional feedback on this KIP I'd like to start a > vote. > > To summarize, the KIP simply proposes to add a consumer metric to track > the size of raw (uncompressed) fetched message

referencing OffsetCheckpoint in downstream project

2018-05-31 Thread Ted Yu
Hi, OffsetCheckpoint has been relocated to org.apache.kafka.streams.state.internals package. Does this mean that downstream project should no longer reference this class ? This is how the class is used (against Kafka 0.10.0.1 release) : // ensure that topic is removed from all cleaner offset

Re: referencing OffsetCheckpoint in downstream project

2018-05-31 Thread Ted Yu
h classes. The example you have is for the broker class, > not the Streams one. > > Ismael > > On Thu, 31 May 2018, 09:03 Ted Yu, wrote: > > > Hi, > > OffsetCheckpoint has been relocated > > to org.apache.kafka.streams.state.internals package. > > > >

Re: [VOTE] KIP-266: Add TimeoutException for KafkaConsumer#position

2018-06-05 Thread Ted Yu
bq. we were already doing with request.timeout.ms I would vote for using existing config. Any new config parameter needs to go thru long process of digestion: documentation, etc in order for users to understand and familiarize. The existing config would have lower mismatch of impedance. Cheers

Re: [VOTE] KIP-266: Add TimeoutException for KafkaConsumer#position

2018-06-05 Thread Ted Yu
API calls. > > best, > Colin > > > On Tue, Jun 5, 2018, at 15:29, Ted Yu wrote: > > bq. we were already doing with request.timeout.ms > > > > I would vote for using existing config. > > > > Any new config parameter needs to go thru long process of diges

Re: [VOTE] KIP-266: Add TimeoutException for KafkaConsumer#position

2018-06-05 Thread Ted Yu
une. For example, if it's too low, you might not > be able to make progress at all on a heavily loaded server. > > We could probably come up with a good default, however. rpc.timeout.ms > could be set to something like > max(1000, 0.5 * request.timeout.ms) > > best, >

Re: [VOTE] KIP-266: Add TimeoutException for KafkaConsumer#position

2018-06-05 Thread Ted Yu
7;re willing to wait for an RPC to complete. Basically we're in agreement. It is just that figuring out good default is non-trivial. On Tue, Jun 5, 2018 at 4:44 PM, Colin McCabe wrote: > On Tue, Jun 5, 2018, at 16:35, Ted Yu wrote: > > bq. could probably come up with a good default

Re: [DISCUSS] KIP-312: Add Overloaded StreamsBuilder Build Method to Accept java.util.Properties

2018-06-08 Thread Ted Yu
Since there're only two values for the optional optimization config introduced by KAFKA-6935, I wonder the overloaded build method (with Properties instance) would make the config unnecessary. nit: * @return @return the {@link Topology} that represents the specified processing logic Double @retur

Re: [VOTE] KIP-228 Negative record timestamp support

2018-06-10 Thread Ted Yu
+1 On Sun, Jun 10, 2018 at 2:17 PM, Matthias J. Sax wrote: > +1 (binding) > > Thanks for the KIP. > > > -Matthias > > On 5/29/18 9:14 AM, Konstantin Chukhlomin wrote: > > Thanks, updated the KIP. > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 228+Negative+record+timestamp+support <

Re: [VOTE] KIP-280: Enhanced log compaction

2018-06-10 Thread Ted Yu
bq. When this configuration is set to anything other than "*offset*" or " *timestamp*", then the record headers are scanned for a key matching this value. Can the value be determined now ? My thinking is that what if there is a third compaction strategy proposed in the future ? We should guard aga

Re: [VOTE] KIP-266: Add TimeoutException for KafkaConsumer#position

2018-06-11 Thread Ted Yu
> failures more quickly > > 3. Someone has configured a very long (or maybe infinite) > > request.timeout.ms > > > > Case #2 is probably the one which is hardest to support well.  We could > > probably do it with logic like this: > > > > A. If defau

Re: [DISCUSS] KIP-291: Have separate queues for control requests and data requests

2018-06-13 Thread Ted Yu
Lucas: Under Rejected Alternatives, #2, can you elaborate a bit more on why the separate config has bigger impact ? Thanks On Wed, Jun 13, 2018 at 2:00 PM, Dong Lin wrote: > Hey Luca, > > Thanks for the KIP. Looks good overall. Some comments below: > > - We usually specify the full mbean for th

Re: [DISCUSS] KIP-291: Have separate queues for control requests and data requests

2018-06-14 Thread Ted Yu
s may want to fine tune the capacity of the > controlRequestQueue. > > I'm ok with either approach, and can change it if you or anyone else feels > strong about adding the extra config. > > Thanks, > Lucas > > > On Wed, Jun 13, 2018 at 3:11 PM, Ted Yu wrote: >

Re: [DISCUSS] KIP-291: Have separate queues for control requests and data requests

2018-06-14 Thread Ted Yu
ead of reusing the > existing one. > Please take another look when you have time. Thanks a lot! > > Lucas > > On Thu, Jun 14, 2018 at 2:33 PM, Ted Yu wrote: > > > bq. that's a waste of resource if control request rate is low > > > > I don't kn

Re: [VOTE] KIP-280: Enhanced log compaction

2018-06-15 Thread Ted Yu
sues.apache.org/jira/browse/KAFKA-7061 Cheers, Luís > On 11 Jun 2018, at 01:50, Ted Yu wrote: > > bq. When this configuration is set to anything other than "*offset*" or " > *timestamp*", then the record headers are scanned for a key matching this > value. > &g

Re: [DISCUSS] KIP-291: Have separate queues for control requests and data requests

2018-06-15 Thread Ted Yu
Change looks good. Thanks On Fri, Jun 15, 2018 at 8:42 AM, Lucas Wang wrote: > Hi Ted, > > Thanks for the suggestion. I've updated the KIP. Please take another look. > > Lucas > > On Thu, Jun 14, 2018 at 6:34 PM, Ted Yu wrote: > > > Currently i

Re: [VOTE] KIP-280: Enhanced log compaction

2018-06-16 Thread Ted Yu
format of the config. Instead of "offset", "timestamp", "", > we could replace the last one with "header=". > > WDYT? > > > -Matthias > > On 6/15/18 3:06 AM, Ted Yu wrote: > > If selection exists in header, the selection should ov

Re: [VOTE] KIP-280: Enhanced log compaction

2018-06-17 Thread Ted Yu
tion of user A. > > Also, if existing topics might have data with record header key > "offset", the change would not be backward compatible either. > > > -Matthias > > On 6/16/18 6:59 PM, Ted Yu wrote: > > Pardon the brevity in my previous reply. > > I was ta

Re: [VOTE] KIP-291: Have separate queues for control requests and data requests

2018-06-18 Thread Ted Yu
+1 On Mon, Jun 18, 2018 at 1:04 PM, Lucas Wang wrote: > Hi All, > > I've addressed a couple of comments in the discussion thread for KIP-291, > and > got no objections after making the changes. Therefore I would like to start > the voting thread. > > KIP: > https://cwiki.apache.org/confluence/di

Re: [VOTE] 1.1.1 RC0

2018-06-19 Thread Ted Yu
+1 Ran unit test suite which passed. Checked signatures. On Tue, Jun 19, 2018 at 4:47 PM, Dong Lin wrote: > Re-send to kafka-clie...@googlegroups.com > > On Tue, Jun 19, 2018 at 4:29 PM, Dong Lin wrote: > > > Hello Kafka users, developers and client-developers, > > > > This is the first candi

Re: [DISCUSS] KIP-319: Replace segments with segmentSize in WindowBytesStoreSupplier

2018-06-20 Thread Ted Yu
Normally size is not measured in time unit, such as milliseconds.  How about naming the new method segmentInterval ? Thanks Original message From: John Roesler Date: 6/20/18 10:45 AM (GMT-08:00) To: dev@kafka.apache.org Subject: [DISCUSS] KIP-319: Replace segments with segment

Re: [DISCUSS] KIP-319: Replace segments with segmentSize in WindowBytesStoreSupplier

2018-06-21 Thread Ted Yu
which is also a > quantity of milliseconds. > > I agree that "interval" is more intuitive, but I think I favor consistency > in this case. Does that seem reasonable? > > Thanks, > -John > > On Wed, Jun 20, 2018 at 1:06 PM Ted Yu wrote: > > >

Re: [DISCUSS] KIP-319: Replace segments with segmentSize in WindowBytesStoreSupplier

2018-06-21 Thread Ted Yu
ought you meant as > > opposed > > > to "segments". Now it makes sense that you meant as opposed to > > > "segmentSize". > > > > > > I named it that way to match the peer method "windowSize", which is > also > > a &

Re: [VOTE] KIP-313: Add KStream.flatTransform and KStream.flatTransformValues

2018-06-22 Thread Ted Yu
+1 On Fri, Jun 22, 2018 at 2:50 AM, Bruno Cadonna wrote: > Hi list, > > I would like to voting on this KIP. > > I created a first PR[1] that adds flatTransform. Once I get some > feedback, I will start work on flatTransformValues. > > Best regards, > Bruno > > [1] https://github.com/apache/kafka

Re: [VOTE] 1.0.2 RC0

2018-06-22 Thread Ted Yu
+1 Ran test suite. Checked signatures. On Fri, Jun 22, 2018 at 11:42 AM, Vahid S Hashemian < vahidhashem...@us.ibm.com> wrote: > +1 (non-binding) > > Built from source and ran quickstart successfully on Ubuntu (with Java 8). > > Thanks for running the release Matthias! > --Vahid > > > > > From:

Re: [VOTE] KIP-312: Add Overloaded StreamsBuilder Build Method to Accept java.util.Properties

2018-06-25 Thread Ted Yu
+1 On Mon, Jun 25, 2018 at 9:45 AM, Guozhang Wang wrote: > +1. > > On Mon, Jun 25, 2018 at 8:12 AM, Matthias J. Sax > wrote: > > > +1 (binding) > > > > On 6/25/18 6:11 AM, Bill Bejeck wrote: > > > All, > > > I'd like to start a vote for this KIP now. > > > > > > Thanks, > > > Bill > > > > > > >

Re: SASL Unit test failing

2018-06-25 Thread Ted Yu
I ran the test alone which passed. Can you include -i on the command line to see if there is some clue from the output ? Here is my environment: Java version: 1.8.0_151, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_151.jdk/Contents/Home/jre Default locale: en_

Re: [VOTE] KIP-319: Replace numSegments to segmentInterval in Streams window configurations

2018-06-25 Thread Ted Yu
+1 On Mon, Jun 25, 2018 at 2:56 PM, John Roesler wrote: > Hello All, > > Thanks for the discussion on KIP-319. I'd now like to start the voting. > > As a reminder, KIP-319 proposes a fix to an issue I identified in > KAFKA-7080. Specifically, the issue is that we're creating > CachingWindowStore

Re: [DISCUSS] KIP-323: Schedulable KTable as Graph source

2018-06-25 Thread Ted Yu
This would be useful feature. In the Public Interfaces section, the new method lacks a closing parenthesis. In the Proposed Changes section, if the order of the 3 bullets can match the order of the parameters of the new method, it would be easier to read. For Rejected Alternatives #2, can you ad

Re: [Discuss] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

2018-06-25 Thread Ted Yu
If there are different TopicNameExtractor classes from multiple sink nodes, the new method should throw exception alerting user of such scenario. On Mon, Jun 25, 2018 at 2:23 PM, Bill Bejeck wrote: > Thanks for the KIP! > > Overall I'm +1 on the KIP. I have one question. > > The KIP states th

Re: SASL Unit test failing

2018-06-25 Thread Ted Yu
ahmed 3.10.0-514.36.5.el7.x86_64 #1 SMP Thu Dec 28 21:42:18 EST > 2017 x86_64 x86_64 x86_64 GNU/Linux > > > Can you please let me know how I can run an individual unit test, what > options do I provide? > > > Thank you, > Ahmed. > > > > On Mon, Jun 25, 2018

Re: SASL Unit test failing

2018-06-25 Thread Ted Yu
", arch: "amd64", family: "unix" On Mon, Jun 25, 2018 at 5:42 PM, Ted Yu wrote: > Here was the command I used: > > ./gradlew -Dtest.single=SaslAuthenticatorTest clients:test > > On Mon, Jun 25, 2018 at 5:39 PM, Ahmed A wrote: > >> I ran test with

Re: [Discuss] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

2018-06-25 Thread Ted Yu
gt; > -Matthias > > On 6/25/18 5:19 PM, Ted Yu wrote: > > If there are different TopicNameExtractor classes from multiple sink > nodes, > > the new method should throw exception alerting user of such scenario. > > > > > > On Mon, Jun 25, 2018 at

Re: [DISCUSS] KIP-326: Schedulable KTable as Graph source

2018-06-26 Thread Ted Yu
What's the relationship between this KIP and KIP-323 ? Thanks On Tue, Jun 26, 2018 at 11:22 AM, Flávio Stutz wrote: > Hey, guys, I've just created a new KIP about creating a new DSL graph > source for realtime partitioned consolidations. > > We have faced the following scenario/problem in a lot

Re: [DISCUSS] KIP-322: Return new error code for DeleteTopics API when topic deletion disabled.

2018-06-26 Thread Ted Yu
Looks good overall. nit: you are going to fill in an actual value below in your PR, right ? private static final long serialVersionUID = 1L; In Motivation, please mention the IllegalStateException scenario. On Tue, Jun 26, 2018 at 9:34 AM, Manikumar wrote: > Hi all, > > I have created a

Re: [DISCUSS] KIP-325: Extend Consumer Group Command to Show Beginning Offsets

2018-06-26 Thread Ted Yu
nit: bq. leaving this empty for compacted topics Some user(s) may be confused by empty partition size. How about emitting 'compacted' for compacted topics ? Cheers On Tue, Jun 26, 2018 at 4:42 PM, Gwen Shapira wrote: > It will be. In my experience most topics aren't compacted, so it will stil

Re: [DISCUSS] KIP-328: Ability to suppress updates for KTables

2018-06-26 Thread Ted Yu
I started to read this KIP which contains a lot of materials. One suggestion: .suppress( new Suppression() Do you think it would be more consistent with the rest of Streams data structures by supporting `of` ? Suppression.of(Duration.ofMinutes(10)) Cheers On Tue, Jun 26, 2018

Re: [DISCUSS] KIP-322: Return new error code for DeleteTopics API when topic deletion disabled.

2018-06-27 Thread Ted Yu
bq. set the serialVersionUID = 1L in Kafka exception classes Indeed. Should have checked earlier. On Wed, Jun 27, 2018 at 1:38 AM, Manikumar wrote: > Hi, > > Thanks for the review. > > > > nit: you are going to fill in an actual value below in your PR, right ? > > private static final long

Re: [DISCUSS] KIP-328: Ability to suppress updates for KTables

2018-06-27 Thread Ted Yu
of the methods I listed. > > For example: > > windowCounts > .suppress( > Suppression > .suppressLateEvents(Duration.ofMinutes(10)) > .suppressIntermediateEvents( > IntermediateSuppression.emitAfter(Duration.ofMinutes(10)) >

Re: [VOTE] 2.0.0 RC0

2018-06-27 Thread Ted Yu
+1 Checked signatures Ran test suite On Mon, Jun 25, 2018 at 11:12 AM, Thomas Crayford wrote: > +1 (non-binding) Heroku has run our usual set of upgrade and performance > tests, and we haven't found any notable issues through that. > > On Sat, Jun 23, 2018 at 12:30 AM, Vahid S Hashemian < > vah

Re: [VOTE] KIP-330: Add retentionPeriod in SessionBytesStoreSupplier

2018-06-27 Thread Ted Yu
+1 On Wed, Jun 27, 2018 at 4:40 PM, Bill Bejeck wrote: > +1 > > -Bill > > On Wed, Jun 27, 2018 at 7:39 PM Guozhang Wang wrote: > > > Hello folks, > > > > I'd like to start a voting thread on KIP-330. I've intentionally skipped > > the discuss phase since it is a pretty straight-forward public A

Re: [VOTE] KIP-280: Enhanced log compaction

2018-06-28 Thread Ted Yu
+1 On Thu, Jun 28, 2018 at 4:56 AM, Luís Cabral wrote: > Hi Ted, > Can I also get your input on this? > > bq. +1 from my side for using `compaction.strategy` with values > "offset","timestamp" and "header" and `compaction.strategy.header` > -Matthias > > bq. +1 from me as well. > -Guozhang > > >

Re: [VOTE] 1.1.1 RC2

2018-06-28 Thread Ted Yu
+1 Ran test suite which passed. On Thu, Jun 28, 2018 at 6:12 PM, Dong Lin wrote: > Hello Kafka users, developers and client-developers, > > This is the second candidate for release of Apache Kafka 1.1.1. > > Apache Kafka 1.1.1 is a bug-fix release for the 1.1 branch that was first > released wi

Re: [VOTE] KIP-308: Support dynamic update of max.connections.per.ip/max.connections.per.ip.overrides configs

2018-06-29 Thread Ted Yu
+1 On Fri, Jun 29, 2018 at 7:29 AM, Manikumar wrote: > Hi All, > > I would like to start voting on KIP-308 which would add support for dynamic > update of max.connections.per.ip/max.connections.per.ip.overrides configs > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=85474993

Re: [VOTE] 0.10.2.2 RC1

2018-06-29 Thread Ted Yu
+1 Ran test suite. Checked signatures. On Fri, Jun 29, 2018 at 10:21 AM, Jason Gustafson wrote: > +1 (binding). I checked release notes, documentation, and went through the > quickstart. > > Thanks Matthias! > > On Fri, Jun 22, 2018 at 6:43 PM, Matthias J. Sax > wrote: > > > Hello Kafka users

Re: [VOTE] KIP-291: Have separate queues for control requests and data requests

2018-06-29 Thread Ted Yu
bq. which is hard coded to be 300 milliseconds Have you considered making the duration configurable ? The comparison at the end of your email seems to be copied where tabular form is lost. Do you mind posting that part again ? Thanks On Fri, Jun 29, 2018 at 4:53 PM, Lucas Wang wrote: > Hi Jun

Re: [kafka-clients] [VOTE] 2.0.0 RC1

2018-06-30 Thread Ted Yu
+1 Checked signatures Ran test suite On Sat, Jun 30, 2018 at 2:37 AM, Rajini Sivaram wrote: > Hi Manikumar, > > Thank you for pointing that out, I had forgotten to drop the old artifacts. > New artifacts should be there now. > > Regards, > > Rajini > > On Sat, Jun 30, 2018 at 7:44 AM, Manikumar

Re: [VOTE] KIP-291: Have separate queues for control requests and data requests

2018-07-02 Thread Ted Yu
h it, > rather than exposing it as a config? > > 2. Sorry for losing the format of the table, I've attached it below as a > picture > > > Regards, > Lucas > > On Fri, Jun 29, 2018 at 5:28 PM, Ted Yu wrote: > >> bq. which is hard coded to be 300 millisecon

Re: [VOTE] KIP-322: Return new error code for DeleteTopics API when topic deletion disabled.

2018-07-03 Thread Ted Yu
+1 On Tue, Jul 3, 2018 at 9:05 AM, Mickael Maison wrote: > +1 (non binding) > Thanks for the KIP > > On Tue, Jul 3, 2018 at 4:59 PM, Vahid S Hashemian > wrote: > > +1 (non-binding) > > > > --Vahid > > > > > > > > From: Gwen Shapira > > To: dev > > Date: 07/03/2018 08:49 AM > > Subject

Re: [VOTE] KIP-291: Have separate queues for control requests and data requests

2018-07-03 Thread Ted Yu
it separately > if it turns out to be a problem. What do you think? > > #2, please try this link and see if it works now: > https://drive.google.com/file/d/1QbPDqfT59A2X4To2p3OfD5YeJR8aW > DK7/view?usp=sharing > > Regards, > Lucas > > > On Mon, Jul 2, 2018 at 5:52 PM

Re: [VOTE] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

2018-07-03 Thread Ted Yu
Hi, I don't seem to find response to John's comment : http://search-hadoop.com/m/Kafka/uyzND11alrn1G5N3Y1?subj=Re+Discuss+KIP+321+Add+method+to+get+TopicNameExtractor+in+TopologyDescription On Tue, Jul 3, 2018 at 7:38 PM, Nishanth Pradeep wrote: > Hello, > > I would like to start the vote on ex

Re: [VOTE] 1.1.1 RC3

2018-07-09 Thread Ted Yu
+1 Ran test suite. Checked signatures. On Sun, Jul 8, 2018 at 3:36 PM Dong Lin wrote: > Hello Kafka users, developers and client-developers, > > This is the fourth candidate for release of Apache Kafka 1.1.1. > > Apache Kafka 1.1.1 is a bug-fix release for the 1.1 branch that was first > relea

Re: [VOTE] 2.0.0 RC2

2018-07-10 Thread Ted Yu
+1 Ran thru test suite. Checked signatures. On Tue, Jul 10, 2018 at 10:17 AM Rajini Sivaram wrote: > Hello Kafka users, developers and client-developers, > > > This is the third candidate for release of Apache Kafka 2.0.0. > > > This is a major version release of Apache Kafka. It includes 40 n

Re: [DISCUSS] KIP-340: Allow kafka-reassign-partitions.sh and kafka-log-dirs.sh to take admin client property file

2018-07-11 Thread Ted Yu
Looking at StreamsResetter.java : commandConfigOption = optionParser.accepts("config-file", "Property file containing configs to be passed to admin cl Not sure you have considered naming the option in the above fashion. Probably add the above to Alternative section. Cheers On Wed, Jul 1

Re: [DISCUSS] KIP-340: Allow kafka-reassign-partitions.sh and kafka-log-dirs.sh to take admin client property file

2018-07-11 Thread Ted Yu
e updated the KIP as suggested. > > Thanks, > Dong > > On Wed, Jul 11, 2018 at 5:57 PM, Ted Yu wrote: > > > Looking at StreamsResetter.java : > > > >commandConfigOption = optionParser.accepts("config-file", > "Property > > file con

Re: [DISCUSS] KIP-340: Allow kafka-reassign-partitions.sh and kafka-log-dirs.sh to take admin client property file

2018-07-11 Thread Ted Yu
not sure the benefit of this change is worth the effort to deprecate the > old config. Maybe we should do it separately if more people thing it is > necessary? > > On Wed, Jul 11, 2018 at 8:01 PM, Ted Yu wrote: > > > bq. "--config-file" in ConfigCommand. > > >

Re: [DISCUSS]: KIP-339: Create a new ModifyConfigs API

2018-07-11 Thread Ted Yu
bq. Map changes, Set removals, Is it possible to combine the two parameters into one Map where null Config value signifies removal of config ? This way, the following wouldn't occur (reducing un-intended config removal): bq. If a configuration key is specified in both *changes* and *removals*

Re: [DISCUSS]: KIP-339: Create a new ModifyConfigs API

2018-07-13 Thread Ted Yu
lin > > On Wed, Jul 11, 2018, at 21:28, Ted Yu wrote: > > bq. Map changes, Set > removals, > > > > Is it possible to combine the two parameters into one Map where null > Config > > value signifies removal of config ? > > This way, the following

Re: KIP-327: Add describe all topics API to AdminClient

2018-07-13 Thread Ted Yu
bq. describe topics by a regular expression on the server side Should caution be taken if the regex doesn't filter ("*") ? Cheers On Fri, Jul 13, 2018 at 6:02 PM Colin McCabe wrote: > As Jason wrote, this won't scale as the number of partitions increases. > We already have users who have tens

Re: [DISCUSS]: KIP-339: Create a new ModifyConfigs API

2018-07-13 Thread Ted Yu
, the notion of null value support would be conveyed to user in a friendly manner. Cheers On Fri, Jul 13, 2018 at 5:51 PM Colin McCabe wrote: > On Fri, Jul 13, 2018, at 17:45, Ted Yu wrote: > > Looking at modifyConfigs API, it doesn't seem that ConcurrentHashMap > should be used

Re: KIP-327: Add describe all topics API to AdminClient

2018-07-14 Thread Ted Yu
McCabe, wrote: > > > Good point. We should probably have a maximum number of results like > > 1000 or something. That can go in the request RPC as well... > > Cheers, > > Colin > > > > On Fri, Jul 13, 2018, at 18:15, Ted Yu wrote: > > > bq. describe topic

Re: [VOTE] KIP-340: Allow kafka-reassign-partitions.sh and kafka-log-dirs.sh to take admin client property file

2018-07-17 Thread Ted Yu
+1 On Tue, Jul 17, 2018 at 1:40 PM Jason Gustafson wrote: > +1. This is useful (though the naming inconsistencies in the tools are > vexing, as always). > > -Jason > > On Tue, Jul 17, 2018 at 12:24 PM, Dong Lin wrote: > > > Hi all, > > > > It seems that there is no further concern with the KIP-

Re: [DISCUSS] KIP-344: The auto-generated client id should be passed to MetricsReporter

2018-07-20 Thread Ted Yu
Looks good to me. On Fri, Jul 20, 2018 at 12:17 AM Kevin Lu wrote: > Hi All, > > This is the discussion thread for KIP-344 ( > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-344%3A+The+auto-generated+client+id+should+be+passed+to+MetricsReporter > ). > > Thanks! > > Regards, > Kevin >

Re: [DISCUSS] KIP-334 Include partitions in exceptions raised during consumer record deserialization/validation

2018-07-20 Thread Ted Yu
Hi, Stanislav: Do you plan to start VOTE thread ? Cheers On Fri, Jul 20, 2018 at 6:11 PM Stanislav Kozlovski wrote: > Hey group, > > I added a Pull Request for this KIP - here it is > https://github.com/apache/kafka/pull/5410 > Please take a look. > > Best, > Stanislav > > On Thu, Jul 5, 2018 a

Re: [DISCUSS] KIP-346 - Limit blast radius of log compaction failure

2018-07-23 Thread Ted Yu
For `uncleanable-partitions`, should the example include topic name(s) ? Cheers On Mon, Jul 23, 2018 at 5:46 PM Stanislav Kozlovski wrote: > I renamed the KIP and that changed the link. Sorry about that. Here is the > new link: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Imp

Re: Seeing old tombstones in compacted topic

2018-07-23 Thread Ted Yu
Looking at some recent JIRAs, such as KAFKA-6568, which came in after the release of 0.11.0 Would that possibly be related to what you observed ? Cheers On Mon, Jul 23, 2018 at 6:23 PM Mitch Seymour wrote: > Hi all, > > We're using version 0.11.0 of Kafka (broker and client), and our Kafka > S

Re: [DISCUSS] KIP-346 - Limit blast radius of log compaction failure

2018-07-24 Thread Ted Yu
Stanislav Kozlovski wrote: > Hi Ted, > > Yes, absolutely. Thanks for pointing that out! > > On Mon, Jul 23, 2018 at 6:12 PM Ted Yu wrote: > > > For `uncleanable-partitions`, should the example include topic name(s) ? > > > > Cheers > > > > On

Re: [VOTE] KIP-344: The auto-generated client id should be passed to MetricsReporter

2018-07-25 Thread Ted Yu
+1 On Wed, Jul 25, 2018 at 9:49 AM Kevin Lu wrote: > Hi All, > > I am calling a vote for KIP-344 > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-344%3A+The+auto-generated+client+id+should+be+passed+to+MetricsReporter > . > > If any committer feels that this minor change does not need t

Re: [Vote] KIP-321: Update TopologyDescription to better represent Source and Sink Nodes

2018-07-25 Thread Ted Yu
+1 On Wed, Jul 25, 2018 at 7:24 PM Nishanth Pradeep wrote: > Hello, > > I'm calling a vote for KIP-321: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-321%3A+Update+TopologyDescription+to+better+represent+Source+and+Sink+Nodes > > Best, > Nishanth Pradeep >

Re: [VOTE] KIP-328: Ability to suppress updates for KTables

2018-07-30 Thread Ted Yu
+1 On Mon, Jul 30, 2018 at 11:46 AM John Roesler wrote: > Hello devs, > > The discussion of KIP-328 has gone some time with no new comments, so I am > calling for a vote! > > Here's the KIP: https://cwiki.apache.org/confluence/x/sQU0BQ > > The basic idea is to provide: > * more usable control ov

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

2018-07-30 Thread Ted Yu
Look good to me. On Mon, Jul 23, 2018 at 7:30 AM Manikumar wrote: > Hi all, > > I have created a KIP to use AdminClient API in AclCommand (kafka-acls.sh) > > * > https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API* > < > https://cwiki.apache.org/

Re: [VOTE] KIP-334 Include partitions in exceptions raised during consumer record deserialization/validation

2018-08-02 Thread Ted Yu
+1 Original message From: Stanislav Kozlovski Date: 8/2/18 2:41 AM (GMT-08:00) To: dev@kafka.apache.org Subject: [VOTE] KIP-334 Include partitions in exceptions raised during consumer record deserialization/validation Hey everybody, I'd like to start a vote thread for KIP-3

Re: [VOTE] KIP-332: Update AclCommand to use AdminClient API

2018-08-02 Thread Ted Yu
+1 On Thu, Aug 2, 2018 at 7:33 PM Manikumar wrote: > Hi All, > > I would like to start voting on KIP-332 which allows AclCommand to use > AdminClient API for acl management. > > KIP: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API > > Dis

Re: [VOTE] KIP-341: Update Sticky Assignor's User Data Protocol

2018-08-03 Thread Ted Yu
+1 On Fri, Aug 3, 2018 at 10:40 AM Jason Gustafson wrote: > +1 Thanks Vahid. > > On Thu, Aug 2, 2018 at 1:27 PM, Vahid S Hashemian < > vahidhashem...@us.ibm.com > > wrote: > > > Hi everyone, > > > > I believe the feedback on this KIP has been addressed so far. So I'd like > > to start a vote. >

Moving build job Was: Build failed in Jenkins: kafka-trunk-jdk10 #364

2018-08-03 Thread Ted Yu
Should the build job run on nodes with the {{Hadoop}} label ? Based on recent builds@a.o discussion about how small the disk capacity is on the general {{ubuntu}} label, I think we should try {{Hadoop}} labeled machines. Cheers On Fri, Aug 3, 2018 at 3:08 PM Apache Jenkins Server < jenk...@build

Re: [DISCUSS] KIP-353: Allow Users to Configure Kafka Streams Timestamp Synchronization

2018-08-03 Thread Ted Yu
Guozhang: Do you plan to support dynamic config for the new config entry ? Cheers On Fri, Aug 3, 2018 at 2:00 PM Guozhang Wang wrote: > Hello all, > > I would like to kick off a discussion on the following KIP, to allow users > control when a task can be processed based on its buffered records

Re: [DISCUSS] KIP-353: Allow Users to Configure Kafka Streams Timestamp Synchronization

2018-08-03 Thread Ted Yu
e > instance. > > Guozhang > > > On Fri, Aug 3, 2018 at 3:33 PM, Ted Yu wrote: > > > Guozhang: > > > > Do you plan to support dynamic config for the new config entry ? > > > > Cheers > > > > On Fri, Aug 3, 2018 at 2:00 PM Guozhang Wang wr

Re: [VOTE] KIP-174 Deprecate and remove internal converter configs in WorkerConfig

2018-01-08 Thread Ted Yu
+1 On Mon, Jan 8, 2018 at 4:27 AM, UMESH CHAUDHARY wrote: > Hello All, > Since there are no outstanding comments on this, so I'd like to start a > vote. > > Please find the KIP here > 174+-+Deprecate+and+remove+internal+converter+configs+

Re: Another bug

2018-01-12 Thread Ted Yu
Can you provide more information ? release of Kafka relevant configs sequence of operation that led to the exception Thanks On Fri, Jan 12, 2018 at 11:22 AM, Peter Holm wrote: > This occurs, when the heartbeat thread is stopped forcibly > > [kafka-coordinator-heartbeat-thread | console-con

  1   2   3   4   5   >