Re: [DISCUSS]KIP-1107: Adding record-level acks for producers

2024-11-05 Thread TaiJu Wu
Hi Chia-Ping, Thanks for your feedback. I have updated KIP based on your suggestions. Best, Stanley Chia-Ping Tsai 於 2024年11月5日 週二 下午4:41寫道: > hi TaiJuWu, > > Q0: Could you please add getter (Short acks()) to "public interface" > section? > > Q1: Could you please add RPC json reference to prov

Re: [DISCUSS]KIP-1107: Adding record-level acks for producers

2024-11-05 Thread TaiJu Wu
is useful when acks is specified > per-topic, but introduces a lot of edge cases that are underspecified. > > Thanks, > Greg > > > On Tue, Nov 5, 2024 at 4:52 PM TaiJu Wu wrote: > > > Hi Chia-Ping, > > > > Thanks for your feedback. > > I have upd

Re: [DISCUSS]KIP-1107: Adding record-level acks for producers

2024-11-05 Thread TaiJu Wu
records of the same acknowledgment level because we may send up to three separate requests to brokers. Best, TaiJuWu TaiJu Wu 於 2024年11月6日 週三 上午10:01寫道: > Hi Fred and Greg, > > Apologies for the delayed response. > Yes, you’re correct. > I’ll outline the behavior I expect. > > Than

Re: [DISCUSS]KIP-1107: Adding record-level acks for producers

2024-11-18 Thread TaiJu Wu
asily > > Q1: `Return Map> when > RecordAccumulator#drainBatchesForOneNode is called.` > > this is weird to me, as all we need to do is pass `Map to > `Sender` and make sure `Sender#sendProduceRequest` add correct acks to > ProduceRequest, right? > > Best, > Chi

Re: [DISCUSS]KIP-1107: Adding record-level acks for producers

2024-11-14 Thread TaiJu Wu
Hi all, I have updated the contents of this KIP Please take a look and let me know what you think. Thanks, TaiJuWu On Thu, Nov 14, 2024 at 2:21 PM TaiJu Wu wrote: > Hi all, > > Thanks for your feeback and @Chia-Ping's help. > . > I also agree topic-level acks config is mo

Re: [DISCUSS]KIP-1107: Adding record-level acks for producers

2024-11-13 Thread TaiJu Wu
> > > > Best, > > David > > > > On Wed, Nov 13, 2024 at 3:56 PM Frédérik Rouleau > > wrote: > > > > > Hi TaiJuWu, > > > > > > I find this adding lot's of complexity and I am still not convinced by > the > > >

Re: [DISCUSS]KIP-1107: Adding record-level acks for producers

2025-01-06 Thread TaiJu Wu
will be handled by the same network > > thread on the broker. If that network thread is busy doing IO for some > > reason (perhaps reading from disk is slow), then it will impact all other > > requests from that producer. Hence, making producer(s) cheap to create > is a > >

Re: [VOTE] KIP-1101: Trigger rebalance on rack topology changes

2024-12-16 Thread TaiJu Wu
+1 (non-binding) On Mon, Dec 16, 2024 at 5:01 PM PoAn Yang wrote: > Hi All, > > I would like to start vote on KIP-1101: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1101%3A+Trigger+rebalance+on+rack+topology+changes > > Discussion thread: > https://lists.apache.org/thread/l8ko353v3n

Re: [VOTE] KIP-1118: Add Deadlock Protection on Producer Network Thread

2024-12-16 Thread TaiJu Wu
+1(non-binding) On Mon, Dec 16, 2024 at 5:41 PM Chia-Ping Tsai wrote: > +1 (binding) > > 郭骏旺 於 2024年12月16日 週一 上午9:16寫道: > > > +1 (non-binding) > > > > On Mon, Dec 9, 2024 at 10:33 AM TengYao Chi wrote: > > > > > Hi everyone, > > > > > > Based on our discussion > > >

Re: [DISCUSS]KIP-1107: Adding record-level acks for producers

2024-11-23 Thread TaiJu Wu
-Ping > > On 2024/11/18 08:36:25 TaiJu Wu wrote: > > Hi Chia-Ping, > > > > Thanks for your suggestions and feedback. > > > > Q1: I have updated this according your suggestions. > > Q2: This is necessary change since there is a assumption about > > *Reco

[VOTE] KIP-1107: Adding topic-level acks and compressions for producers

2025-01-02 Thread TaiJu Wu
Hello everyone, Happy New Year! There is no response about KIP-1107 for a long time so I would like to vote. Discussion thread: https://lists.apache.org/thread/v1sm6c59j5wppg1w6t17bvkgqlt3orp7 KIP-1107 https://cwiki.apache.org/confluence/display/KAFKA/KIP-1107%3A++Adding+topic-level+acks+and+com

Re: [VOTE] KIP-1107: Adding topic-level acks and compressions for producers

2025-01-02 Thread TaiJu Wu
anges to the producer, and > it's essential to ensure we have thoroughly considered all perspectives. > > Best, > Chia-Ping > > On 2025/01/03 03:03:03 TaiJu Wu wrote: > > Hello everyone, > > > > Happy New Year! > > There is no response about KIP-1107 fo

Re: [DISCUSS]KIP-1107: Adding record-level acks for producers

2025-01-02 Thread TaiJu Wu
Hello folk, This thread is pending for a long time, I want to bump this thread and get more feedback. Any questions are welcome. Best, TaiJuWu TaiJu Wu 於 2024年11月23日 週六 下午9:15寫道: > Hi Chia-Ping, > > Sorry for late reply and thanks for your feedback to make this KIP more > valua

Re: [DISCUSS] KIP-1133: AK Documentation and Website in Markdown

2025-03-10 Thread TaiJu Wu
Hi Harish, Thanks for this KIP. Is it possible to add dev website from trunk for developers? It could help developer to browser the web without local build and check recent documentation change quickly. I think it can improve our documentation a lot since developers can easy to check it. Best, T