[jira] [Created] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-1135: Summary: Code cleanup - use Json.encode() to write json data to zk Key: KAFKA-1135 URL: https://issues.apache.org/jira/browse/KAFKA-1135 Project: Kafka Issue

[jira] [Commented] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826116#comment-13826116 ] Swapnil Ghike commented on KAFKA-1135: -- Created reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1135: - Attachment: KAFKA-1135.patch > Code cleanup - use Json.encode() to write json data to zk > --

[jira] [Updated] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1135: - Attachment: KAFKA-1135_2013-11-18_19:17:54.patch > Code cleanup - use Json.encode() to write json

[jira] [Commented] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826128#comment-13826128 ] Swapnil Ghike commented on KAFKA-1135: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1135: - Attachment: KAFKA-1135_2013-11-18_19:20:58.patch > Code cleanup - use Json.encode() to write json

[jira] [Commented] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826133#comment-13826133 ] Swapnil Ghike commented on KAFKA-1135: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1117) tool for checking the consistency among replicas

2013-11-20 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828146#comment-13828146 ] Swapnil Ghike commented on KAFKA-1117: -- Hey Jun, after committing this patch, builds

[jira] [Commented] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-25 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832037#comment-13832037 ] Swapnil Ghike commented on KAFKA-1135: -- Thanks for catching this David! Jun, it seems

[jira] [Commented] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-25 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832040#comment-13832040 ] Swapnil Ghike commented on KAFKA-1135: -- [~jjkoshy], does the above issue look similar

[jira] [Created] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-27 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-1152: Summary: ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1 Key: KAFKA-1152 URL: https://issues.apache.org/jira/browse/KAFKA-1152

[jira] [Updated] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-27 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1152: - Attachment: KAFKA-1152.patch > ReplicaManager's handling of the leaderAndIsrRequest should gracef

[jira] [Commented] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-27 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13834544#comment-13834544 ] Swapnil Ghike commented on KAFKA-1152: -- Created reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1152: - Attachment: KAFKA-1152_2013-11-28_10:19:05.patch > ReplicaManager's handling of the leaderAndIsrR

[jira] [Commented] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835022#comment-13835022 ] Swapnil Ghike commented on KAFKA-1152: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1152: - Attachment: KAFKA-1152.patch > ReplicaManager's handling of the leaderAndIsrRequest should gracef

[jira] [Commented] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835198#comment-13835198 ] Swapnil Ghike commented on KAFKA-1152: -- Created reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835205#comment-13835205 ] Swapnil Ghike commented on KAFKA-1152: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1152: - Attachment: KAFKA-1152_2013-11-28_22:40:55.patch > ReplicaManager's handling of the leaderAndIsrR

[jira] [Updated] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1152: - Attachment: (was: KAFKA-1152.patch) > ReplicaManager's handling of the leaderAndIsrRequest sh

[jira] [Updated] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-12-03 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1152: - Attachment: incremental.patch Attached a patch to fix logging statement. > ReplicaManager's hand

[jira] [Commented] (KAFKA-291) Add builder to create configs for consumer and broker

2013-12-30 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859341#comment-13859341 ] Swapnil Ghike commented on KAFKA-291: - Not sure if the ConfigBuilder is going to reduce

[jira] [Updated] (KAFKA-622) Create mbeans per client

2012-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-622: Attachment: kafka-622-v4.patch 9 - I am not convinced that "ClientIdAndTopicPartition" is the right

[jira] [Updated] (KAFKA-622) Create mbeans per client

2012-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-622: Attachment: kafka-622-v5.patch Quick fix to interchange the order of constructor arguments of Client

[jira] [Updated] (KAFKA-622) Create mbeans per client

2012-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-622: Attachment: kafka-622-v6.patch Oops, another quick fix. Didn't realize that syncproducer was not get

[jira] [Updated] (KAFKA-640) System Test Failures : kafka.common.InvalidClientIdException in broker log4j messages

2012-11-29 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-640: Attachment: kafka-640.patch This happened because ClientId.validate(clientId) in SimpleConsumer did

[jira] [Commented] (KAFKA-608) getTopicMetadata does not respect producer config settings

2012-11-30 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507546#comment-13507546 ] Swapnil Ghike commented on KAFKA-608: - Is including broker.list in properties necessary

[jira] [Created] (KAFKA-646) Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level

2012-12-04 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-646: --- Summary: Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level Key: KAFKA-646 URL: https://issues.apache.org/jira/browse/KAFKA-646 Pro

[jira] [Updated] (KAFKA-646) Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level

2012-12-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-646: Labels: bugs (was: ) > Provide aggregate stats at the high level Producer and > ZookeeperConsu

[jira] [Created] (KAFKA-648) Use uniform convention for naming properties keys for clientId, groupId, consumerId, correlationId

2012-12-04 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-648: --- Summary: Use uniform convention for naming properties keys for clientId, groupId, consumerId, correlationId Key: KAFKA-648 URL: https://issues.apache.org/jira/browse/KAFKA-648

[jira] [Assigned] (KAFKA-646) Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level

2012-12-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-646: --- Assignee: Swapnil Ghike > Provide aggregate stats at the high level Producer and > Zookee

[jira] [Commented] (KAFKA-622) Create mbeans per client

2012-12-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509976#comment-13509976 ] Swapnil Ghike commented on KAFKA-622: - Created KAFKA-646 to address your comments.

[jira] [Updated] (KAFKA-513) Add state change log to Kafka brokers

2012-12-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-513: Priority: Major (was: Blocker) > Add state change log to Kafka brokers > --

[jira] [Commented] (KAFKA-235) Add a 'log.file.age' configuration parameter to force rotation of log files after they've reached a certain age

2012-12-05 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511208#comment-13511208 ] Swapnil Ghike commented on KAFKA-235: - Yes, KAFKA-475 added a feature to 0.7 and 0.8 th

[jira] [Comment Edited] (KAFKA-235) Add a 'log.file.age' configuration parameter to force rotation of log files after they've reached a certain age

2012-12-06 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511208#comment-13511208 ] Swapnil Ghike edited comment on KAFKA-235 at 12/6/12 7:59 AM: --

[jira] [Resolved] (KAFKA-235) Add a 'log.file.age' configuration parameter to force rotation of log files after they've reached a certain age

2012-12-06 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike resolved KAFKA-235. - Resolution: Fixed Fix Version/s: 0.7.2 0.8 > Add a 'log.file.age' co

[jira] [Created] (KAFKA-660) Change (topic, partition) tuples to TopicAndPartition

2012-12-06 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-660: --- Summary: Change (topic, partition) tuples to TopicAndPartition Key: KAFKA-660 URL: https://issues.apache.org/jira/browse/KAFKA-660 Project: Kafka Issue Type: B

[jira] [Updated] (KAFKA-646) Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level

2012-12-07 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-646: Attachment: kafka-646-patch-num1-v1.patch This patch has a bunch of refactoring changes and a couple

[jira] [Commented] (KAFKA-646) Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level

2012-12-07 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527019#comment-13527019 ] Swapnil Ghike commented on KAFKA-646: - Actually I just realized that the Aggregated*Sta

[jira] [Updated] (KAFKA-646) Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level

2012-12-07 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-646: Attachment: kafka-646-patch-num1-v2.patch Attached patch v2. The changes from patch v1: 1. Deleted

[jira] [Comment Edited] (KAFKA-646) Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level

2012-12-07 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527078#comment-13527078 ] Swapnil Ghike edited comment on KAFKA-646 at 12/8/12 6:17 AM: --

[jira] [Updated] (KAFKA-646) Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level

2012-12-10 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-646: Attachment: kafka-646-patch-num1-v3.patch Thanks for reviewing. Patch v3: 1. Oh, that's because cli

[jira] [Updated] (KAFKA-646) Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level

2012-12-10 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-646: Attachment: kafka-646-patch-num1-v4.patch Fixed a typo in FetchRequestAndResponseStats mbean creatio

[jira] [Updated] (KAFKA-646) Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level

2012-12-11 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-646: Attachment: kafka-646-patch-num1-v5.patch Patch v5: 40. I agree with you. Created a new trait Confi

[jira] [Work started] (KAFKA-513) Add state change log to Kafka brokers

2012-12-11 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-513 started by Swapnil Ghike. > Add state change log to Kafka brokers > - > > Key: KAFKA-513 >

[jira] [Commented] (KAFKA-604) Add missing metrics in 0.8

2012-12-11 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529626#comment-13529626 ] Swapnil Ghike commented on KAFKA-604: - Wow, this is going to be fun. :) Unfortunately p

[jira] [Updated] (KAFKA-646) Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level

2012-12-12 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-646: Attachment: kafka-646-patch-num1-v6.patch Made the changes. > Provide aggregate sta

[jira] [Commented] (KAFKA-604) Add missing metrics in 0.8

2012-12-12 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530200#comment-13530200 ] Swapnil Ghike commented on KAFKA-604: - Yes I like this idea, can follow this in KAFKA-6

[jira] [Updated] (KAFKA-646) Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level

2012-12-12 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-646: Attachment: kafka-646-patch-num1-v7.patch Including in patch v7 Joel's suggestion at KAFKA-604 to me

[jira] [Updated] (KAFKA-513) Add state change log to Kafka brokers

2012-12-12 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-513: Attachment: kafka-513-v1.patch Patch v1: 1. Created a tool PartitionStateChangeLogMerger - It looks

[jira] [Updated] (KAFKA-648) Use uniform convention for naming properties keys

2012-12-21 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-648: Summary: Use uniform convention for naming properties keys (was: Use uniform convention for naming

[jira] [Updated] (KAFKA-515) Log cleanup can close a file channel opnened by Log.read before the transfer completes

2013-01-11 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-515: Fix Version/s: (was: 0.8) 0.8.1 > Log cleanup can close a file channel op

[jira] [Updated] (KAFKA-515) Log cleanup can close a file channel opnened by Log.read before the transfer completes

2013-01-11 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-515: Affects Version/s: 0.8.1 > Log cleanup can close a file channel opnened by Log.read before the t

[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-11 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551666#comment-13551666 ] Swapnil Ghike commented on KAFKA-648: - Will it make sense to create a Utils function to

[jira] [Commented] (KAFKA-697) ConsoleConsumer throws InvalidConfigException for "." in client id

2013-01-12 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552080#comment-13552080 ] Swapnil Ghike commented on KAFKA-697: - Currently we allow only alphanumerics, - and _ i

[jira] [Assigned] (KAFKA-697) ConsoleConsumer throws InvalidConfigException for "." in client id

2013-01-14 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-697: --- Assignee: Swapnil Ghike > ConsoleConsumer throws InvalidConfigException for "." in client

[jira] [Updated] (KAFKA-697) ConsoleConsumer throws InvalidConfigException for "." in client id

2013-01-14 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-697: Attachment: kafka-697-allow-dot.patch Thanks for your comments. I agree that allowing dot will make

[jira] [Created] (KAFKA-708) ISR becomes empty while marking a partition offline

2013-01-16 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-708: --- Summary: ISR becomes empty while marking a partition offline Key: KAFKA-708 URL: https://issues.apache.org/jira/browse/KAFKA-708 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-708) ISR becomes empty while marking a partition offline

2013-01-16 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-708: Attachment: kafka-request.log.2013-01-16-15 > ISR becomes empty while marking a partition offlin

[jira] [Assigned] (KAFKA-708) ISR becomes empty while marking a partition offline

2013-01-16 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-708: --- Assignee: Neha Narkhede > ISR becomes empty while marking a partition offline > --

[jira] [Commented] (KAFKA-715) NumberFormatException in PartitionStateInfo

2013-01-21 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559016#comment-13559016 ] Swapnil Ghike commented on KAFKA-715: - Looks like a duplicate of KAFKA-708

[jira] [Created] (KAFKA-726) Add ReplicaFetcherThread name to mbean names

2013-01-22 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-726: --- Summary: Add ReplicaFetcherThread name to mbean names Key: KAFKA-726 URL: https://issues.apache.org/jira/browse/KAFKA-726 Project: Kafka Issue Type: Bug Af

[jira] [Updated] (KAFKA-726) Add ReplicaFetcherThread name to mbean names

2013-01-22 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-726: Attachment: KAFKA-726.patch As described in the description above. > Add ReplicaFet

[jira] [Commented] (KAFKA-726) Add ReplicaFetcherThread name to mbean names

2013-01-22 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560423#comment-13560423 ] Swapnil Ghike commented on KAFKA-726: - I actually deleted brokerConfig.brokerId. Replic

[jira] [Updated] (KAFKA-726) Add ReplicaFetcherThread name to mbean names

2013-01-23 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-726: Attachment: KAFKA-726-v2.patch Set the clientId to name in ReplicaFetcherThread and removed Replica

[jira] [Commented] (KAFKA-738) correlationId is not set in FetchRequest in AbstractFetcherThread

2013-01-27 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13563965#comment-13563965 ] Swapnil Ghike commented on KAFKA-738: - Probably because we create a new FetchRequestBui

[jira] [Commented] (KAFKA-738) correlationId is not set in FetchRequest in AbstractFetcherThread

2013-01-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564824#comment-13564824 ] Swapnil Ghike commented on KAFKA-738: - With this patch, all fetchRequests in SimpleCons

[jira] [Commented] (KAFKA-738) correlationId is not set in FetchRequest in AbstractFetcherThread

2013-01-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564887#comment-13564887 ] Swapnil Ghike commented on KAFKA-738: - I see. Actually the same issue is present in had

[jira] [Commented] (KAFKA-738) correlationId is not set in FetchRequest in AbstractFetcherThread

2013-01-29 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565965#comment-13565965 ] Swapnil Ghike commented on KAFKA-738: - Though with this patch, the requestMap will be c

[jira] [Commented] (KAFKA-738) correlationId is not set in FetchRequest in AbstractFetcherThread

2013-01-29 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565992#comment-13565992 ] Swapnil Ghike commented on KAFKA-738: - +1 > correlationId is not set i

[jira] [Updated] (KAFKA-513) Add state change log to Kafka brokers

2013-02-11 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-513: Attachment: kafka-513-v2.patch Patch v2: 1.1.a Statements other than "abort transition" are logged

[jira] [Updated] (KAFKA-757) System Test Hard Failure cases : "Fatal error during KafkaServerStable startup" when hard-failed broker is re-started

2013-02-12 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-757: Labels: 0.8 replication-testing (was: replication-testing) > System Test Hard Failure cases : "

[jira] [Assigned] (KAFKA-757) System Test Hard Failure cases : "Fatal error during KafkaServerStable startup" when hard-failed broker is re-started

2013-02-12 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-757: --- Assignee: Swapnil Ghike > System Test Hard Failure cases : "Fatal error during KafkaServer

[jira] [Updated] (KAFKA-757) System Test Hard Failure cases : "Fatal error during KafkaServerStable startup" when hard-failed broker is re-started

2013-02-13 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-757: Attachment: kafka-757-v1.patch There are two parts to this patch : A. Move the sanity check to dete

[jira] [Updated] (KAFKA-757) System Test Hard Failure cases : "Fatal error during KafkaServerStable startup" when hard-failed broker is re-started

2013-02-13 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-757: Attachment: kafka-757-v2.patch Sorry, in indexSlotFor() we should check if lastOffset is the same as

[jira] [Updated] (KAFKA-757) System Test Hard Failure cases : "Fatal error during KafkaServerStable startup" when hard-failed broker is re-started

2013-02-13 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-757: Attachment: kafka-757-v3.patch Yes, your point is valid. Jay also suggested to implement truncate()

[jira] [Assigned] (KAFKA-755) standardizing json values stored in ZK

2013-02-14 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-755: --- Assignee: Swapnil Ghike > standardizing json values stored in ZK > ---

[jira] [Commented] (KAFKA-604) Add missing metrics in 0.8

2013-02-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581160#comment-13581160 ] Swapnil Ghike commented on KAFKA-604: - I can do this after finishing KAFKA-755.

[jira] [Updated] (KAFKA-755) standardizing json values stored in ZK

2013-02-20 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-755: Attachment: kafka-755-v1.patch This patch standardizes the reading and writing to zookeeper values a

[jira] [Updated] (KAFKA-755) standardizing json values stored in ZK

2013-02-20 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-755: Status: Patch Available (was: Open) > standardizing json values stored in ZK >

[jira] [Commented] (KAFKA-768) broker should exit if hitting exceptions durin startup

2013-02-21 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583582#comment-13583582 ] Swapnil Ghike commented on KAFKA-768: - +1 > broker should exit if hitt

[jira] [Commented] (KAFKA-768) broker should exit if hitting exceptions durin startup

2013-02-21 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583586#comment-13583586 ] Swapnil Ghike commented on KAFKA-768: - Also to maintain consistency with Producer/Consu

[jira] [Assigned] (KAFKA-604) Add missing metrics in 0.8

2013-02-21 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-604: --- Assignee: Swapnil Ghike > Add missing metrics in 0.8 > -- > >

[jira] [Updated] (KAFKA-733) Fat jar option for build, or override for ivy cache location

2013-02-21 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-733: Labels: bugs patch (was: patch) > Fat jar option for build, or override for ivy cache location

[jira] [Updated] (KAFKA-733) Fat jar option for build, or override for ivy cache location

2013-02-21 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-733: Labels: bugs (was: bugs patch) > Fat jar option for build, or override for ivy cache location

[jira] [Updated] (KAFKA-733) Fat jar option for build, or override for ivy cache location

2013-02-21 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-733: Status: Patch Available (was: Open) > Fat jar option for build, or override for ivy cache locat

[jira] [Updated] (KAFKA-733) Fat jar option for build, or override for ivy cache location

2013-02-21 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-733: Assignee: Dave DeMaagd > Fat jar option for build, or override for ivy cache location > ---

[jira] [Updated] (KAFKA-755) standardizing json values stored in ZK

2013-02-21 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-755: Attachment: kafka-755-v2.patch Addressed all points. i. Renamed valueAsString flag to valueInQuotes

[jira] [Created] (KAFKA-770) KafkaConfig properties should be verified in the constructor

2013-02-21 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-770: --- Summary: KafkaConfig properties should be verified in the constructor Key: KAFKA-770 URL: https://issues.apache.org/jira/browse/KAFKA-770 Project: Kafka Issue

[jira] [Updated] (KAFKA-770) KafkaConfig properties should be verified in the constructor

2013-02-21 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-770: Attachment: kafka-770.patch Attached a patch. > KafkaConfig properties should be ve

[jira] [Assigned] (KAFKA-770) KafkaConfig properties should be verified in the constructor

2013-02-21 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-770: --- Assignee: Swapnil Ghike > KafkaConfig properties should be verified in the constructor > -

[jira] [Commented] (KAFKA-768) broker should exit if hitting exceptions durin startup

2013-02-21 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584045#comment-13584045 ] Swapnil Ghike commented on KAFKA-768: - Filed KAFKA-770 with a patch. >

[jira] [Updated] (KAFKA-755) standardizing json values stored in ZK

2013-02-22 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-755: Attachment: kafka-755-v3.patch Made the changes and rebased. writePreferredReplicaElectionData is

[jira] [Updated] (KAFKA-604) Add missing metrics in 0.8

2013-02-22 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-604: Attachment: kafka-604-new.patch Added droppedMessageRate per topic in Producer, partition count on t

[jira] [Updated] (KAFKA-604) Add missing metrics in 0.8

2013-02-22 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-604: Attachment: kafka-604-new-v2.patch Thanks Jun for observing that "All.Topics" does not uniquely iden

[jira] [Commented] (KAFKA-568) LogTest started failing after KAFKA-506

2013-02-24 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585522#comment-13585522 ] Swapnil Ghike commented on KAFKA-568: - It still fails intermittently on 0.8 branch, I c

[jira] [Created] (KAFKA-773) kafka.integration.PrimitiveApiTest fails intermittently

2013-02-25 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-773: --- Summary: kafka.integration.PrimitiveApiTest fails intermittently Key: KAFKA-773 URL: https://issues.apache.org/jira/browse/KAFKA-773 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-773) kafka.integration.PrimitiveApiTest fails intermittently

2013-02-25 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-773: Priority: Blocker (was: Major) > kafka.integration.PrimitiveApiTest fails intermittently >

[jira] [Assigned] (KAFKA-773) kafka.integration.PrimitiveApiTest fails intermittently

2013-02-25 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-773: --- Assignee: Swapnil Ghike > kafka.integration.PrimitiveApiTest fails intermittently > --

[jira] [Updated] (KAFKA-773) kafka.integration.PrimitiveApiTest fails intermittently

2013-02-25 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-773: Attachment: kafka-773.patch This test fails when highWatermark for a partition is updated after its

<    1   2   3   4   5   >