Re: [DISCUSS] KIP-1027 Add MockFixedKeyProcessorContext

2024-05-03 Thread Shashwat Pandey
Hi Matthias, Sorry this fell out of my radar for a bit. Revisiting the topic, I think you’re right and we accept the duplicated nesting as an appropriate solution to not affect the larger public API. I can update my PR with the change. Regards, Shashwat Pandey On Wed, May 1, 2024 at 11:00 PM

Re: [DISCUSS] KIP-1027 Add MockFixedKeyProcessorContext

2024-05-21 Thread Shashwat Pandey
wiki account created, please request it via a commet on this > > ticket: https://issues.apache.org/jira/browse/INFRA-25451 > > > > After you have the account, please share your wiki id, and we can give > > you write permission on the wiki. > > > > > > >

Re: [DISCUSS] KIP-1027 Add MockFixedKeyProcessorContext

2024-06-12 Thread Shashwat Pandey
FixedKeyRecordFactory also make sense? Regards, Shashwat Pandey On Mon, Jun 10, 2024 at 5:07 PM Matthias J. Sax wrote: > Shaswhat, > > any updates on this KIP? -- I still think that recommending to use > `InternalFixedKeyRecordFactory` is not the best way to write test code. > Changing

Re: [DISCUSS] KIP-1027 Add MockFixedKeyProcessorContext

2024-06-22 Thread Shashwat Pandey
to exclude an internal class in the > JavaDocs build step. > > > -Matthias > > On 6/12/24 4:47 PM, Shashwat Pandey wrote: > > Hi Matthias, > > > > I think that strategy definitely works, abstracting away changes to > > FixedKeyRecord from users, I can put that new fa

Re: [DISCUSS] KIP-1027 Add MockFixedKeyProcessorContext

2024-06-23 Thread Shashwat Pandey
well. Regards, Shashwat Pandey On Sat, Jun 22, 2024 at 8:25 PM Matthias J. Sax wrote: > Thanks for the update. > > About the wiki account. Creating the account was done by Infra, but > setting permissions is on us. Fixed. > > > About the KIP: > > Should we pass-

[DISCUSS] KIP-1027 Add MockFixedKeyProcessorContext

2024-03-11 Thread Shashwat Pandey
Hi everyone, I would like to start the discussion on https://cwiki.apache.org/confluence/display/KAFKA/KIP-1027%3A+Add+MockFixedKeyProcessorContext This adds MockFixedKeyProcessorContext to the Kafka Streams Test Utils library. Regards, Shashwat Pandey

Re: [DISCUSS] KIP-1027 Add MockFixedKeyProcessorContext

2024-03-14 Thread Shashwat Pandey
MockFixedKeyProcessorContext, some of the internal classes should also be extracted i.e. MockRecordMetadata, CapturedPunctuator and probably a new CapturedFixedKeyForward. Let me know what you think! Regards, Shashwat Pandey On Mon, Mar 11, 2024 at 10:09 PM Matthias J. Sax wrote: > Thanks for the

Re: [DISCUSS] KIP-1027 Add MockFixedKeyProcessorContext

2025-07-16 Thread Shashwat Pandey
Hi Matthias, Sorry this totally fell off my radar, what would be left to do? Would updating the version to latest release be enough? Regards, Shashwat Pandey On Wed, Jun 11, 2025 at 5:37 PM Matthias J. Sax wrote: > Is there still interest to complete this KIP? > > -Matthias > &g