Re: Request to be added on contributor list

2022-01-11 Thread Seung-chan Ahn
Thanks a lot, Bill Sincerely, Seung-chan Ahn On Wed, Jan 12, 2022 at 12:33 AM Bill Bejeck wrote: > Hi Seung-chan Ahn, > > You're all set now. Thanks for your interest in Apache Kafka. > > Regards, > Bill > > On Mon, Jan 10, 2022 at 11:14 AM 안승찬 wrote: > &g

[DISCUSS] KIP-812: Introduce another form of the `KafkaStreams.close()` API that forces the member to leave the consumer group

2022-01-12 Thread Seung-chan Ahn
Hi team, Here's the new KIP for this issue . The title says pretty

Re: [DISCUSS] KIP-812: Introduce another form of the `KafkaStreams.close()` API that forces the member to leave the consumer group

2022-02-11 Thread Seung-chan Ahn
d the `close()` function again but with a control > object, that includes 1) timeout, 2) leave-group flag, and hence can also > extend to include more variables just in case. Would like to hear others' > thoughts as well. > > > Guozhang > > > On Wed, Jan 12, 2022 at 5

Re: [DISCUSS] KIP-812: Introduce another form of the `KafkaStreams.close()` API that forces the member to leave the consumer group

2022-02-11 Thread Seung-chan Ahn
ent the close > function in the future, which would explode the function names :P Instead > maybe we can just overload the `close()` function again but with a control > object, that includes 1) timeout, 2) leave-group flag, and hence can also > extend to include more variables just in

[VOTE] KIP-812: Introduce another form of the `KafkaStreams.close()` API that forces the member to leave the consumer group

2022-02-15 Thread Seung-chan Ahn
Hi team, I feel like we have a finalized proposal for this improvement . I want to know what you think. Thanks in advance for your help, Seung-chan

Re: [DISCUSS] KIP-812: Introduce another form of the `KafkaStreams.close()` API that forces the member to leave the consumer group

2022-02-15 Thread Seung-chan Ahn
Hi Guozhang, Thanks a lot for sharing your idea and guiding me. Thanks to your support, we've reached this voting: https://lists.apache.org/thread/toq5pg799ctd7lwdcd6g7zk6xn73h26r Seung-chan On Wed, Jan 12, 2022 at 10:50 PM Seung-chan Ahn wrote: > Hi team, > > Here's t

Re: [DISCUSS] KIP-812: Introduce another form of the `KafkaStreams.close()` API that forces the member to leave the consumer group

2022-02-18 Thread Seung-chan Ahn
why we use `Integer` here, instead of `int`, > or `Duration`? > > Thank you. > Luke > > On Tue, Feb 15, 2022 at 11:19 PM Seung-chan Ahn > wrote: > > > Hi Guozhang, > > > > > > Thanks a lot for sharing your idea and guiding me. > > > > > >

Re: [DISCUSS] KIP-812: Introduce another form of the `KafkaStreams.close()` API that forces the member to leave the consumer group

2022-02-19 Thread Seung-chan Ahn
` > variable in `CloseOptions` is `null`. What doest null `timeout` mean? > > Thank you. > Luke > > On Sat, Feb 19, 2022 at 3:31 PM Seung-chan Ahn > wrote: > > > Hi Luke, > > > > Thanks for reviewing this KIP! > > > > 1. You are right, I'm on

Re: [VOTE] KIP-812: Introduce another form of the `KafkaStreams.close()` API that forces the member to leave the consumer group

2022-02-19 Thread Seung-chan Ahn
This vote passes with: - 3 +1 (binding) votes from Guozhang, John and Luke Thanks for the votes and feedback Seung-chan On Wed, Feb 16, 2022 at 12:06 AM Seung-chan Ahn wrote: > Hi team, > > I feel like we have a finalized proposal for this improvement > <https://cwiki.apache.o

Re: [VOTE] KIP-812: Introduce another form of the `KafkaStreams.close()` API that forces the member to leave the consumer group

2022-03-29 Thread Seung-chan Ahn
o complete this KIP? Since we have > just passed the freeze deadline of 3.2, the KIP would only be completed in > 3.3.0. > > On Sat, Feb 19, 2022 at 5:37 AM Seung-chan Ahn > wrote: > > > This vote passes with: > > - 3 +1 (binding) votes from Guozhang, John and Luke > &