Hi,
Could you please grant me write access to KIP proposals?
I am planning to make KIP for KAFKA-8233: Helper class to make it simpler
to write test logic with TopologyTestDriver
Wiki ID: jkarvanen
Best regards,
Jukka Karvanen
Hi All,
I would like to start the discussion on KIP-456: Helper classes to make it
simpler to write test logic with TopologyTestDriver:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-456%3A+Helper+classes+to+make+it+simpler+to+write+test+logic+with+TopologyTestDriver
There is also relate
Hi,
I played around with Patrick's KAFKA-8200 branch and I tested it with
combined with my draft version of KIP-456.
Some comments:
These two version of iterableOutput methods are working now differently, if
you reuse same fetched Iterable object after piping in new inputs.
Version without serde
, but waiting Patrick's clarification of the use case.
Jukka
ti 23. huhtik. 2019 klo 15.37 Jukka Karvanen (jukka.karva...@jukinimi.com)
kirjoitti:
> Hi All,
>
> I would like to start the discussion on KIP-456: Helper classes to make it
> simpler to write test logic with T
gt; >
> > Let's wait on Patrick's input to see how to proceed.
> >
> >
> > -Matthias
> >
> > On 4/25/19 12:03 AM, Jukka Karvanen wrote:
> >> Hi,
> >>
> >> If you want to see or test the my current idea of the implementa
t; about it.
>
>
> Please give me some more time to review this KIP in detail and I will
> follow up later again.
>
>
> -Matthias
>
> On 4/26/19 2:25 PM, Jukka Karvanen wrote:
> > Yes, my understanding was also that this KIP cover all the requirement of
> > KI
. toukok. 2019 klo 9.05 Jukka Karvanen (jukka.karva...@jukinimi.com)
kirjoitti:
> Hi,
>
> New TestInputTopic and TestOutputTopic included to Developer guide testing
> page as alternative,
> The old way with ConsumerRecordFactory and OutputVerifier is not removed.
>
> You can see th
remaining records if there are any.
>
> General:
>
> 8. Can the TTD, input, and output topics implement AutoCloseable, to
> facilitate try-with-resources in tests?
>
> Example:
> try (driver = new TTD(), input = new TestInputTopic(), output = new
> TestOutputTopic() ) {
&
Hi,
This KIP is relating to add classes to kafka-stream-test-utils.
My initial plan was to create new project for these helper classes before I
decided to contribute directly to Apache Kafka with this KIP.
I have one streams project where I have used these classes, that is why I
planned to release
Hi,
I will write new KIP for the TestTopologyDriver Input and Output usability
changes.
It is out of the scope of the current title: "Helper classes to make it
simpler to write test logic with TopologyTestDriver"
and we can get back to this KIP if that alternative is not favored.
So my original a
low-level perspective Kafka does and should not care what is inside
> the topic, but from a user perspective this information usually belongs
> together.
> Sidenote: Having topics as objects would probably also make it easier to
> track them from the outside.
> regards
> Pat
Hi All,
I would like to start the discussion on KIP-470: TopologyTestDriver test
input and output usability improvements:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-470%3A+TopologyTestDriver+test+input+and+output+usability+improvements
This KIP is inspired by the Discussion in KIP-456
time to
> look through the KIP.
>
> My question was also if this handling of topics wouldn't make more sense
> even outside the TTD, for the general API.
>
> regards
> Patrik
>
> On Thu, 9 May 2019 at 14:43, Jukka Karvanen
> wrote:
>
> > Hi Patrick,
> >
topic accept ProducerRecords and the output topic return
> ConsumerRecords. I'm open to discussion on this point, though.
>
> Thanks for the proposal, Jukka!
> -John
>
> On Mon, May 20, 2019 at 7:59 AM Jukka Karvanen
> wrote:
> >
> > Hi All,
> >
> &
e facing
> two practically identical paths to accomplish the same goal, and it's
> very difficult to slim the interface down later, because we don't
> really know which parts are more popular (i.e., no one submits
> "feature requests" to _remove_ stuff they don't
uot;, equalTo("Hello")),
hasProperty("headers", equalTo(headers;
Jukka
la 15. kesäk. 2019 klo 1.10 John Roesler (j...@confluent.io) kirjoitti:
> Sounds good. Thanks as always for considering my feedback!
> -John
>
> On Fri, Jun 14, 2019 at 12:12 PM Ju
> >
> > Thanks for the updates. I look forward to hearing what others think.
> >
> > -John
> >
> > On Mon, Jun 17, 2019 at 4:12 AM Jukka Karvanen
> > wrote:
> > >
> > > Wiki page updated:
> > >
> >
> https:
Ack, thanks!
>
> On Thu, Jun 20, 2019 at 11:27 PM Jukka Karvanen <
> jukka.karva...@jukinimi.com>
> wrote:
>
> > Hi Guozhang,
> >
> > 1) This TestRecord is new class in my proposal. So it is a simplified
> > version of ProducerRecord and ConsumerRe
sub-topologies created?
>
> On Fri, Jun 21, 2019 at 12:05 PM Guozhang Wang wrote:
>
> > 1) Got it, could you list this class along with all its functions in the
> > proposed public APIs as well?
> >
> > 2) Ack, thanks!
> >
> > On Thu, Jun 20, 2019 at
gt; with internal topics when there are sub-topologies created?
> >
> > On Fri, Jun 21, 2019 at 12:05 PM Guozhang Wang
> wrote:
> >
> >> 1) Got it, could you list this class along with all its functions in the
> >> proposed public APIs as well?
> >>
>
y I don't see
> > how those could be affected.
>
> I mistakenly thought the KIP was proposing to completely remove
> Producer/ConsumerRecords in favor of TestRecord. But taking another quick
> look I can see the plan for using the TestRecord objects. Thanks for the
&g
ng.
>
> Not sure if I can follow here. You first say, you could easily migrate
> your code, but than you say it was not easily possible? Can you clarify
> your experience upgrading your test code?
>
>
> -Matthias
>
>
> On 6/27/19 12:21 AM, Jukka Karvanen wrote:
> > Hi,
&g
e all good options. I guess
> my
> > > own preference is 5.
> > >
> > > It seems like the migration pain is a one-time concern vs. having more
> > > maintainable code for years thereafter.
> > >
> > > Thanks,
> > > -John
> >
Hi,
Sorry; I need to rollback right away the one method removal what I was
proposing.
One constructor with Long restored to TestRecord, which is needed by
TestInputTopic.
Regards,
Jukka
la 7. syysk. 2019 klo 8.06 Jukka Karvanen (jukka.karva...@jukinimi.com)
kirjoitti:
> Hi,
>
> Let
people generally feel positive, it might be time to start a vote.
> >>
> >> Thanks,
> >> -John
> >>
> >> On Sat, Sep 7, 2019 at 12:40 AM Jukka Karvanen
> >> wrote:
> >>>
> >>> Hi,
> >>>
> >>> So
; close the vote before Wednesday (cf
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=125307901
> )
> > we might be able to get it into 2.4 release (if we have the bandwidth to
> > review the PR in time...)
> >
> >
> > -Matthias
> >
> >
Hi all,
I would like to start vote on KIP-470:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-470%3A+TopologyTestDriver+test+input+and+output+usability+improvements
Regards,
Jukka
p 20, 2019 at 9:56 AM Matthias J. Sax
> >> wrote:
> >>
> >>> Thanks for the KIP Jukka!
> >>>
> >>> +1 (binding)
> >>>
> >>> -Matthias
> >>>
> >>>> On 9/20/19 9:44 AM, Paul Whalen wrote:
> &g
Jukka Karvanen created KAFKA-8233:
-
Summary: Helper class to make it simpler to write test logic
TopologyTestDriver
Key: KAFKA-8233
URL: https://issues.apache.org/jira/browse/KAFKA-8233
Project
29 matches
Mail list logo