Re: Contributing to Kafka

2020-08-08 Thread Gokul Srinivas
Matthias, I'm able to access the wiki and jira now thank you! I signed up to the JIRA with a slightly different email address so wanted to double check. Not a major problem but it would make it a bit easier for me to manage. Thanks, -Gokul On 2020/08/04 20:37:00, "Matthias J. Sax" wrote: >

[DISCUSS] KIP-654 Aborting Transaction with non-flushed data should throw a non-fatal Exception

2020-08-27 Thread Gokul Srinivas
Hello all, I would like to propose the following KIP to throw a new non-fatal exception whilst aborting transactions with non-flushed data. This will help users distinguish non-fatal errors and potentially retry the batch. *Issue *- https://issues.apache.org/jira/browse/KAFKA-10186

Re: [DISCUSS] KIP-654 Aborting Transaction with non-flushed data should throw a non-fatal Exception

2020-09-01 Thread Gokul Srinivas
be better? About the name itself. I would prefer something simpler like `AbortedTransactionException`. Thoughts? -Matthias On 8/27/20 10:24 AM, Gokul Srinivas wrote: Hello all, I would like to propose the following KIP to throw a new non-fatal exception whilst aborting transactions with non-fl

Re: [DISCUSS] KIP-654 Aborting Transaction with non-flushed data should throw a non-fatal Exception

2020-09-03 Thread Gokul Srinivas
All, Gentle reminder - any comments on the line of thinking I mentioned in the last email? I've updated the Exception to be named "TransactionAbortedException" on the KIP confluence page. -Gokul On 01-09-2020 18:34, Gokul Srinivas wrote: Matthias, Sophie, Jason, Took

Re: [DISCUSS] KIP-654 Aborting Transaction with non-flushed data should throw a non-fatal Exception

2020-09-03 Thread Gokul Srinivas
maybe we should reuse the old error message just in case? Besides that, this KIP LGTM On Thu, Sep 3, 2020 at 5:23 AM Gokul Srinivas wrote: All, Gentle reminder - any comments on the line of thinking I mentioned in the last email? I've updated the Exception to be named "TransactionA

Re: [DISCUSS] KIP-654 Aborting Transaction with non-flushed data should throw a non-fatal Exception

2020-09-03 Thread Gokul Srinivas
Appreciate the help! On 04-09-2020 00:46, Sophie Blee-Goldman wrote: Yep, you can go ahead and call for a vote on the KIP On Thu, Sep 3, 2020 at 12:09 PM Gokul Srinivas wrote: Sophie, That sounds fair. I've updated the KIP to state the same message for backward compatibili

[VOTE] KIP-654 Aborting Transaction with non-flushed data should throw a non-fatal Exception

2020-09-03 Thread Gokul Srinivas
Hi, I would like to call a vote on the following KIP. *KIP *- https://cwiki.apache.org/confluence/display/KAFKA/KIP-654:+Aborted+transaction+with+non-flushed+data+should+throw+a+non-fatal+exception

Re: [VOTE] KIP-654 Aborting Transaction with non-flushed data should throw a non-fatal Exception

2020-09-09 Thread Gokul Srinivas
fson wrote: +1 Thanks for the KIP! On Thu, Sep 3, 2020 at 12:25 PM Gokul Srinivas wrote: Hi, I would like to call a vote on the following KIP. *KIP *- https://cwiki.apache.org/confluence/display/KAFKA/KIP-654:+Aborted+transaction+with+non-flushed+data+should+throw+a+non-fatal+exception

Re: [DISCUSS] KIP-654 Aborting Transaction with non-flushed data should throw a non-fatal Exception

2020-09-11 Thread Gokul Srinivas
All, As the vote has passed, I have raised a PR here: https://github.com/apache/kafka/pull/9280 Please help review. Thanks, Gokul On 04-09-2020 00:48, Gokul Srinivas wrote: Appreciate the help! On 04-09-2020 00:46, Sophie Blee-Goldman wrote: Yep, you can go ahead and call for a vote on the