Re: Review Request 34492: Patch for KAFKA-2210

2015-06-09 Thread Dapeng Sun
n/scala/kafka/security/auth/KafkaPrincipal.scala <https://reviews.apache.org/r/34492/#comment139452> I think it is better to use constants or enum to stand for UserType Thanks Dapeng - Dapeng Sun On 六月 5, 2015, 7:07 a.m., Parth Brahmbhatt wrote: > > --

Re: Review Request 34492: Patch for KAFKA-2210

2015-06-11 Thread Dapeng Sun
tps://reviews.apache.org/r/34492/#comment139881> Why add a new config file path? could authorization related config options be merged into Kafka Config? - Dapeng Sun On 六月 5, 2015, 7:07 a.m., Parth Brahmbhatt wrote: > > ---