Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

Hey Rajini - If the quota.type is set to 'user', what happens to unauthenticated clients? They don't supply a principal, so are they essentially unthrottled? This may be a nit, but I prefer 'quota.type' options to be 'authenticated-user' and 'client-id' as opposed to 'client' and 'user'. For a ne

RE: Metrics package discussion

the new metrics package > aren't very well tested. > > Thanks, > Neha > > On Wed, Mar 25, 2015 at 8:25 AM, Aditya Auradkar < > aaurad...@linkedin.com.invalid> wrote: > > > Hey everyone, > > > > Picking up this discussion after yesterdays KIP hang

Re: Review Request 31967: Patch for KAFKA-1546

matically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review77810 ------- On March 25, 2015, 8:27 p.m., Aditya Auradkar wrote: > > --- > This is an automatically genera

Re: Review Request 31967: Patch for KAFKA-1546

ree that it is a bit simpler to pass the boolean value so I'm making these changes. - Aditya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review77799 ---

Re: Review Request 31967: Patch for KAFKA-1546

ws.apache.org/r/31967/diff/ Testing --- Thanks, Aditya Auradkar

RE: Metrics package discussion

o all these issues, and ripped them out. Whether they are really useful or not, I don't know. Averages can be pretty misleading so it can be nice but I don't know that it is critical. -Jay On Thu, Mar 26, 2015 at 1:58 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: &

Re: Review Request 31967: Patch for KAFKA-1546

1995993cd0bc1 Diff: https://reviews.apache.org/r/31967/diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 31366: Patch for KAFKA-1461

core/src/main/scala/kafka/server/AbstractFetcherThread.scala <https://reviews.apache.org/r/31366/#comment126602> Can you add some documentation for this class? - Aditya Auradkar On March 27, 2015, 10:31 p.m., Sriharsha Chintalapani wrote: > >

RE: Metrics package discussion

ent > > sensors. So there is logical grouping (as opposed to a separate > > mbean per sensor as is the case in YM metrics). > > > > The main disadvantages: > > - Everyone's graphs and alerts will break and need to be updated > > - Histogram

RE: [KIP-DISCUSSION] KIP-13 Quotas

; > >> > > need > > >> > > > to give the client an indicator that it's being throttled, > instead > > >> of > > >> > > doing > > >> > > > this silently. For that, we probably need to evolve the > >

Review Request 32778: Patch for KAFKA-2087

/src/test/scala/unit/kafka/server/SimpleFetchTest.scala efb457334bd87e4c5b0dd2c66ae1995993cd0bc1 Diff: https://reviews.apache.org/r/32778/diff/ Testing --- Thanks, Aditya Auradkar

Review Request 32781: Patch for KAFKA-2087

/browse/KAFKA-2087 Repository: kafka Description --- Fixing KAFKA-2087 Diffs - core/src/main/scala/kafka/server/TopicConfigManager.scala 47295d4 Diff: https://reviews.apache.org/r/32781/diff/ Testing --- Thanks, Aditya Auradkar

RE: [KIP-DISCUSSION] KIP-13 Quotas

Jun On Wed, Apr 1, 2015 at 3:27 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Hey everyone, > > I've made changes to the KIP to capture our discussions over the last > couple of weeks. > https://cwiki.apache.org/confluence/display/KAFKA/KIP-13+-+Quotas

RE: [KIP-DISCUSSION] KIP-13 Quotas

: Aditya Auradkar Sent: Friday, April 03, 2015 10:10 AM To: dev@kafka.apache.org Subject: RE: [KIP-DISCUSSION] KIP-13 Quotas Thanks Jun. Some thoughts: 10) I think it is better we throttle regardless of the produce/fetch version. This is a nice feature where clients can tell if they are being throttled

RE: [KIP-DISCUSSION] KIP-13 Quotas

ink Aditya was also trying to avoid adding a new quota purgatory. i.e., it may be possible to use the existing purgatory instances to enforce quotas. That may be simpler, but would be incur a slight perf penalty if too many clients are being throttled. Thanks, Joel > > -Jay > > On Fri, Ap

RE: [KIP-DISCUSSION] KIP-13 Quotas

rd, so at LinkedIn that would mean potentially every request will need a small delay. I haven't worked out the efficiency implications of this choice, so as long as we do that I'm happy. -Jay On Fri, Apr 3, 2015 at 1:10 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: &

RE: [KIP-DISCUSSION] KIP-13 Quotas

ind of buy it, but I really like to understand the details of the > use > > case before we make protocol changes. What changes are you proposing in > the > > clients for monitoring and how would that be used? > > > > -Jay > > > > On Mon, Apr 6, 2015 at 10:

RE: [KIP-DISCUSSION] KIP-13 Quotas

ya at 4am asked "Hey, is my > app > > > throttled?". > > > > > > I assume Aditya is trying to avoid this scenario. > > > > > > On Mon, Apr 6, 2015 at 7:47 PM, Jay Kreps > wrote: > > > > > > > Hey Aditya, > >

[VOTE] KIP-13 Quotas

Please vote. https://cwiki.apache.org/confluence/display/KAFKA/KIP-13+-+Quotas Thanks, Aditya

RE: [KIP-DISCUSSION] KIP-13 Quotas

t 05:45:34AM +0000, Aditya Auradkar wrote: > Hey everyone, > > Following up after today's hangout. After discussing the client side metrics > piece internally, we've incorporated that section into the KIP. > https://cwiki.apache.org/confluence/display/KAFKA/KIP-13+-+Quot

Re: Review Request 33049: Patch for KAFKA-2084

nfig.scala 69b772c1941865fbe15b34bb2784c511f8ce519a core/src/main/scala/kafka/server/KafkaServer.scala c63f4ba9d622817ea8636d4e6135fba917ce085a core/src/test/scala/unit/kafka/server/ClientQuotaMetricsTest.scala PRE-CREATION Diff: https://reviews.apache.org/r/33049/diff/ Testing --- Thank

Re: Review Request 33049: Patch for KAFKA-2084

nfig.scala 69b772c1941865fbe15b34bb2784c511f8ce519a core/src/main/scala/kafka/server/KafkaServer.scala c63f4ba9d622817ea8636d4e6135fba917ce085a core/src/test/scala/unit/kafka/server/ClientQuotaMetricsTest.scala PRE-CREATION Diff: https://reviews.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

RE: [VOTE] KIP-13 Quotas

new response. The > rest of the stuff looks good to me. > > Thanks, > > Jun > > On Tue, Apr 7, 2015 at 10:47 PM, Aditya Auradkar < > aaurad...@linkedin.com.invalid> wrote: > > > Please vote. > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-13+-+Quotas > > > > Thanks, > > Aditya > >

RE: [KIP-DISCUSSION] KIP-13 Quotas

wangg...@gmail.com] Sent: Monday, April 13, 2015 7:27 PM To: dev@kafka.apache.org Subject: Re: [KIP-DISCUSSION] KIP-13 Quotas I think KAFKA-2063 (bounding fetch response) is still under discussion, and may not be got it in time with KAFKA-1927. On Thu, Apr 9, 2015 at 4:49 PM, Aditya Auradkar <

RE: [KIP-DISCUSSION] KIP-13 Quotas

de and return immediately, 3) after X ms elapsed, set timeout-error-code and return. Guozhang On Tue, Apr 14, 2015 at 5:01 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > This is an implementation proposal for delaying requests in quotas using > the current purgatory. I

RE: [KIP-DISCUSSION] KIP-13 Quotas

t NO_ERROR but we need to document such cases clearly for quote actions mixed with ack = -1. Guozhang On Wed, Apr 15, 2015 at 4:23 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Thanks for the review Guozhang. > > 1. Agreed. > > 2. This proposal actually waits for

Review Request 33378: Patch for KAFKA-2136

/test/scala/unit/kafka/server/ReplicaManagerTest.scala 00d59337a99ac135e8689bd1ecd928f7b1423d79 Diff: https://reviews.apache.org/r/33378/diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 33378: Patch for KAFKA-2136

9186c90de5a983a73b042fcb42987bfabae14fcf core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala 00d59337a99ac135e8689bd1ecd928f7b1423d79 Diff: https://reviews.apache.org/r/33378/diff/ Testing (updated) --- New tests added Thanks, Aditya Auradkar

Re: Review Request 33378: Patch for KAFKA-2136

/DelayedOperationTest.scala 9186c90de5a983a73b042fcb42987bfabae14fcf core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala 00d59337a99ac135e8689bd1ecd928f7b1423d79 Diff: https://reviews.apache.org/r/33378/diff/ Testing --- New tests added Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

fka/server/ClientQuotaMetricsTest.scala PRE-CREATION Diff: https://reviews.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

ically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/#review80130 --- On April 21, 2015, 7:21 p.m., Aditya Auradkar wrote: > > --- > This is an

Re: Review Request 33049: Patch for KAFKA-2084

Testing --- Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

ricsTest2.scala PRE-CREATION Diff: https://reviews.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

RE: [KIP-DISCUSSION] KIP-13 Quotas

he onComplete() is called and the > > operation > > > > proceeds normally i.e. perform a readFromLocalLog and return a > > response. > > > > The caveat here is that if the request is throttled but the throttle > > time > > > > is less than the max_wait ti

Re: Review Request 33551: Patch for KAFKA-2150

eck I guess. The fetch request can still be performed outside the locked segment. - Aditya Auradkar On April 25, 2015, 2:48 p.m., Sriharsha Chintalapani wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 33551: Patch for KAFKA-2150

<https://reviews.apache.org/r/33551/#comment132029> I was thinking that you could still process the fetchRequest outside the locked segment. Is there a reason a flag wouldn't work? - Aditya Auradkar On April 25, 2015, 2:48 p.m., Sriharsha Chintal

Re: Review Request 33551: Patch for KAFKA-2150

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33551/#review81693 --- Ship it! Ship It! - Aditya Auradkar On April 25, 2015, 8:35 p.m

RE: [KIP-DISCUSSION] KIP-13 Quotas

s per-client. That makes sense. On Fri, Apr 24, 2015 at 11:02:29PM +0000, Aditya Auradkar wrote: > I think Joel's suggestion is quite good. It's still possible to throttle > other types of requests using purgatory but we will need a separate purgatory > and DelayedOperati

Re: Review Request 30196: Patch for KAFKA-1886

://reviews.apache.org/r/30196/diff/ Testing --- Added an integration test to PrimitiveAPITest.scala. Thanks, Aditya Auradkar

Re: Review Request 30196: Patch for KAFKA-1886

try to avoid blindly sleeping in > > Kafka tests since it almost always leads to transient test failures. > > Consider using TestUtils.waitUntilTrue(). > > Aditya Auradkar wrote: > Thanks Neha. I missed this review comment. > > I agree sleeping isn't idea

Re: Review Request 30196: Patch for KAFKA-1886

/ Testing (updated) --- Thanks, Aditya Auradkar

[DISCUSS] KIP-21 Configuration Management

Hey everyone, Wrote up a KIP to update topic, client and broker configs dynamically via Zookeeper. https://cwiki.apache.org/confluence/display/KAFKA/KIP-21+-+Dynamic+Configuration Please read and provide feedback. Thanks, Aditya PS: I've intentionally kept this discussion separate from KIP-5 s

RE: [DISCUSS] KIP-21 Configuration Management

Hey Gwen, Thanks for the feedback. As Joel said, these client configs do not introduce a producer/consumer zk dependency. It is configuration that is needed by the broker. >From your comments, I gather that you are more worried about managing broker >internal configs via Zookeeper since we alr

RE: [DISCUSS] KIP-21 Configuration Management

ig changes the config manager updates this reference. > d. The KafkaConfiguration is the thing that allows doing the > configuration.onChange("my.config", callback) > > -Jay > > On Tue, Apr 28, 2015 at 3:57 PM, Aditya Auradkar < > aaurad...@linkedin.com.invalid> w

RE: [DISCUSS] KIP-21 Configuration Management

Hey Joe, Can you elaborate what you mean by a stop the world change? In this protocol, we can target notifications to a subset of brokers in the cluster (controller if we need to). Is the AdminChangeNotification a ZK notification or a request type exposed by each broker? Thanks, Aditya _

RE: [DISCUSS] KIP-21 Configuration Management

kaConfiguration is the thing that allows doing the configuration.onChange("my.config", callback) -Jay On Tue, Apr 28, 2015 at 3:57 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Hey everyone, > > Wrote up a KIP to update topic, client and broker configs dynamically vi

RE: [DISCUSS] KIP-21 Configuration Management

king all the configs mutable can be done gradually. -Jay On Mon, May 4, 2015 at 1:31 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Hey Jay, > > Thanks for the feedback. > > 1. We can certainly discuss what it means to remove the file configuration > as a tho

RE: [DISCUSS] KIP-21 Configuration Management

fkaConfiguration is what gets passed into various components. So to > access a config you do something like config.instance.myValue. When the > config changes the config manager updates this reference. > d. The KafkaConfiguration is the thing that allows doing the > configuration.onChange(&q

Re: Review Request 33049: Patch for KAFKA-2084

d let me know which one you prefer. I open to doing it either way. - Aditya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/#review82382 -

Re: Review Request 33049: Patch for KAFKA-1984

ConfigConfigDefTest.scala 8014a5a6c362785539f24eb03d77278434614fe6 core/src/test/scala/unit/kafka/server/ThrottledRequestExpirationTest.scala PRE-CREATION Diff: https://reviews.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-1984

s.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

ExpirationTest.scala PRE-CREATION Diff: https://reviews.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

cala/unit/kafka/server/KafkaConfigConfigDefTest.scala 8014a5a6c362785539f24eb03d77278434614fe6 core/src/test/scala/unit/kafka/server/ThrottledRequestExpirationTest.scala PRE-CREATION Diff: https://reviews.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

t/scala/unit/kafka/server/ThrottledRequestExpirationTest.scala PRE-CREATION Diff: https://reviews.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

------ Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

e6 core/src/test/scala/unit/kafka/server/ThrottledRequestExpirationTest.scala PRE-CREATION Diff: https://reviews.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 33378: Patch for KAFKA-2136

hanks, Aditya Auradkar

Re: Review Request 33378: Patch for KAFKA-2136

New tests added Thanks, Aditya Auradkar

Re: Review Request 33378: Patch for KAFKA-2136

che.org/r/33378/#review82389 --- On May 7, 2015, 1:36 a.m., Aditya Auradkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

RE: [DISCUSS] KIP-21 Configuration Management

gt; > > > > Good discussion. Since we will be talking about this at 11am, I > > > > wanted > > > > > > > to organize these comments into requirements to see if we are > all > > > on > > > > > > > the same page. > >

Re: Review Request 33378: Patch for KAFKA-2136

Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

KafkaConfigConfigDefTest.scala 8014a5a6c362785539f24eb03d77278434614fe6 core/src/test/scala/unit/kafka/server/ThrottledRequestExpirationTest.scala PRE-CREATION Diff: https://reviews.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

Test.scala 8014a5a6c362785539f24eb03d77278434614fe6 core/src/test/scala/unit/kafka/server/ThrottledRequestExpirationTest.scala PRE-CREATION Diff: https://reviews.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

RE: [DISCUSS] KIP-21 Configuration Management

uot;service > > > > > > > kafka reload". > > > > > > > > > > > > > > (See Apache web server: > > > > > > > > > > https://github.com/apache/httpd/blob/trunk/build/rpm/httpd.init#L101 > > >

Re: Review Request 34070: Patch for KAFKA-2186

/ConsumerConnector.java <https://reviews.apache.org/r/34070/#comment134315> How does this work if the consumer doesn't own these partitions? Is it possible to commit offsets for any topic? Just curious.. - Aditya Auradkar On May 12, 2015, 1:39 a.m., Jiangji

Re: Review Request 33049: Patch for KAFKA-2084

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/#review83441 --- On May 11, 2015, 11:17 p.m., Aditya Auradkar wrote: > > -

Re: Review Request 33378: Patch for KAFKA-2136

Thanks, Aditya Auradkar

Re: Review Request 33378: Patch for KAFKA-2136

atically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/#review83439 ------- On May 12, 2015, 9:40 p.m., Aditya Auradkar wrote: > > --- > This is a

Re: Review Request 33378: Patch for KAFKA-2136

/DelayedOperationTest.scala f3ab3f4ff8eb1aa6b2ab87ba75f72eceb6649620 core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala 00d59337a99ac135e8689bd1ecd928f7b1423d79 Diff: https://reviews.apache.org/r/33378/diff/ Testing --- New tests added Thanks, Aditya Auradkar

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 5:14 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java, line > > 62 > > > > > > Is this actually right? I agree you'll get discontinuities as the > > m

Re: Review Request 34170: Patch for KAFKA-2191

" number of samples. In the rare case, there is no activity for 10 mins (say), this will add 10sec*6*10 = 600 samples which will be purged immediately on the next record call. - Aditya Auradkar On May 13, 2015, 10:32 p.m., Dong Lin wrote: > >

Re: Review Request 34170: Patch for KAFKA-2191

> > Dong Lin wrote: > The question is, when Rate.measure() is called right after > Rate.record(n), what should be the return value? I think there are two > possibilities: 0 and n/config.timeWindowMs(). I didn't find any use case > where these two values make a differenc

RE: [DISCUSS] KIP-21 Configuration Management

> > > > > file > > > > > > > > > that > > > > > > > > > > > Kafka broker will take. If we move all configs to ZK, we > > > can > > > > > > > > customize > > > > > > > > > > the > > >

RE: [DISCUSS] KIP-21 Configuration Management

will be 3 paths within config /config/clients/ /config/topics/ /config/brokers/ Didn't we decide that brokers will not be configured dynamically, rather we will keep the config in the file? On Fri, May 15, 2015 at 10:46 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: >

[VOTE] KIP-21 Dynamic Configuration

https://cwiki.apache.org/confluence/display/KAFKA/KIP-21+-+Dynamic+Configuration Aditya

RE: [VOTE] KIP-21 Dynamic Configuration

nt to introduce a separate > new request or have a combined new request for both topic and client id > level config changes? > > A minor point in the wiki, for the json format in ZK, we should change > {X1=Y1, > X2=Y2..} to a json map, right? > > Thanks, > &

Re: Review Request 34418: Patch for KAFKA-2191

mon/metrics/MetricsTest.java <https://reviews.apache.org/r/34418/#comment135560> can you remove this? - Aditya Auradkar On May 19, 2015, 5:12 p.m., Jay Kreps wrote: > > --- > This is an automatically generated e-mail

RE: [VOTE] KIP-21 Dynamic Configuration

ager to be ConfigOverrideManager and have it handle all the override types we will have? I think I may just be unclear on what you are proposing... -Jay On Mon, May 18, 2015 at 1:34 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Yeah, that was just a typo. I've fixed it. Thanks fo

RE: [VOTE] KIP-21 Dynamic Configuration

g) - you are welcome to update the KIP page. Thanks, Andrii Biletskyi On Tue, May 19, 2015 at 11:40 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Updating the discussion with the latest comments. > > 1. We discussed adding 2 new API's (AlterConfig and De

RE: [VOTE] KIP-21 Dynamic Configuration

Tue, May 19, 2015 at 10:33 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Thanks Andrii. I'll make the changes. > > I've also updated KIP-21 to include the new config requests. Take a look > and vote. > > https://cwiki.apache.org/co

Review Request 34554: Patch for KAFKA-2205

c7136f20972614ac47aa57ab13e3c94ef775a4b7 core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala 7877f6ca1845c2edbf96d4a9783a07a552db8f07 Diff: https://reviews.apache.org/r/34554/diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 34554: Patch for KAFKA-2205

scala 7877f6ca1845c2edbf96d4a9783a07a552db8f07 Diff: https://reviews.apache.org/r/34554/diff/ Testing (updated) --- 1. Added new testcases for new code. 2. Verified that both topic and client configs can be changed dynamically by starting a local cluster Thanks, Aditya Auradkar

RE: [VOTE] KIP-21 Dynamic Configuration

picMetadataResponse in KIP-4? Do we remove the config part in it? Thanks, Jun On Thu, May 21, 2015 at 10:25 AM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Hey Jun, > > I've added a section on error codes on the KIP-21 wiki. > > Here are the propos

Re: Review Request 33049: Patch for KAFKA-2084

KafkaConfigConfigDefTest.scala 8014a5a6c362785539f24eb03d77278434614fe6 core/src/test/scala/unit/kafka/server/ThrottledRequestExpirationTest.scala PRE-CREATION Diff: https://reviews.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

Test.scala 8014a5a6c362785539f24eb03d77278434614fe6 core/src/test/scala/unit/kafka/server/ThrottledRequestExpirationTest.scala PRE-CREATION Diff: https://reviews.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

ampledStat.oldest(now) == now. > > > > Should I open a ticket and submit a patch for it? > > Aditya Auradkar wrote: > Hey dong, yeah you should submit a patch for it. > > Dong Lin wrote: > Sure! I will do it. Dropping since this is being tracked in a sepa

RE: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

Andryii, I made a few edits to this document as discussed in the KIP-21 thread. https://cwiki.apache.org/confluence/display/KAFKA/KIP-4+-+Command+line+and+centralized+administrative+operations With these changes. the only difference between TopicMetadataResponse_V1 and V0 is the removal of the

RE: [VOTE] KIP-21 Dynamic Configuration

Hey everyone, Completed the changes to KIP-4. After today's hangout, there doesn't appear to be anything remaining to discuss on this KIP. Please vote so we can formally close this. Thanks, Aditya ____ From: Aditya Auradkar Sent: Thursday, May 2

RE: [VOTE] KIP-21 Dynamic Configuration

bump From: Aditya Auradkar Sent: Tuesday, May 26, 2015 1:16 PM To: dev@kafka.apache.org Subject: RE: [VOTE] KIP-21 Dynamic Configuration Hey everyone, Completed the changes to KIP-4. After today's hangout, there doesn't appear to be anything

RE: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

rrect ISR for the consumer to choose. So, perhaps it's worth fixing the ISR inconsistency issue in KAFKA-1367 (there is some new discussion there on what it takes to fix this). If we do that, we can leave TMR unchanged. Thanks, Jun On Tue, May 26, 2015 at 1:13 PM, Aditya Auradka

RE: [VOTE] KIP-21 Dynamic Configuration

t; 2. The proposed JSON format uses camel case for field names, is that what > > we've used for other JSON in zookeeper? > > 3. This changes the format of the notifications, right? How will we > > grandfather in the old format? Clusters will have existing change > > notif

RE: [VOTE] KIP-21 Dynamic Configuration

right? How will we > > grandfather in the old format? Clusters will have existing change > > notifications in the old format so I think the new code will need to be > > able to read those? > > > > -Jay > > > > On Thu, May 28, 2015 at 11:41 AM, Aditya

RE: [VOTE] KIP-21 Dynamic Configuration

he upgrade path so people don't get bitten. -Jay On Thu, May 28, 2015 at 11:22 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Yeah, the same cleaning mechanism will be carried over. > > > 1. Are we introducing a new Java API for the config change protocol and &g

RE: [VOTE] KIP-21 Dynamic Configuration

, May 31, 2015, Aditya Auradkar wrote: > 2. There was a typo in my previous email. I meant to say that we should > use snake case because it's more consistent. I couldn't find any examples > of camel case but did find some snake case (jmx_port). Other than that, > most other e

KIP Wiki

Hey everyone, We have enough KIP's now (25) that it's a bit hard to tell which ones are adopted or under discussion by glancing at the wiki. Any concerns if I split it into 3 tables (adopted, discarded and KIP's under discussion)? https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improveme

RE: [VOTE] KIP-19 Add a request timeout to NetworkClient

+1 (non-binding). One minor comment. Should we rename "max.block.ms" to "max.send.block.ms"? Something that indicates that it is being applied to the "send" API methods exposed by KafkaProducer. Aditya From: Joel Koshy [jjkosh...@gmail.com] Sent: Tuesday

Re: Review Request 33049: Patch for KAFKA-2084

eviews.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

eviews.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

: https://reviews.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

  1   2   3   4   5   >