Re: [DISCUSS] KIP-1153: Kafka Streams `CloseOptions` should not have a public constructor

Hi Jiunn-Yang You could copy the code example from KIP-1092, but adjust it to fit the Streams style (e.g. javadoc, definition). It would be easier since these examples have been discussed previously. Best, TengYao 黃竣陽 於 2025年4月26日 週六 上午11:34寫道： > Hello Sophie, Mathias, > > Thanks for your com

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

Hi Jun, Thank you for pointing that out. I have revised the KIP as follows: “In this case, the change does not introduce new invalid configurations or prevent any currently valid setup. The main behavioral difference is that we now explicitly throw a ConfigException during the storage forma

Re: [PR] KAFKA-19026: add note in ZK to KRaft migration [kafka-site]

edoardocomar commented on PR #685: URL: https://github.com/apache/kafka-site/pull/685#issuecomment-2830434852 thanks, https://github.com/apache/kafka/pull/19563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Created] (KAFKA-19203) Replace `ApiError#exception` by `Error#exception` for KafkaAdminClient

Chia-Ping Tsai created KAFKA-19203: -- Summary: Replace `ApiError#exception` by `Error#exception` for KafkaAdminClient Key: KAFKA-19203 URL: https://issues.apache.org/jira/browse/KAFKA-19203 Project: K

Re: read cluster metadata topic

Hi Peter, On Fri, Apr 25, 2025 at 10:14 AM Péter Sinóros-Szabó wrote: > I'm actually interested in all the advertised listener configs, we use a > few of them. As I see the metadata response will contain only one > listener's data, the listener I accessed Kafka through, am I right? That's correc

[jira] [Created] (KAFKA-19204) Timeouts in coordinator runtime operations can break share group initialization and deletion

Andrew Schofield created KAFKA-19204: Summary: Timeouts in coordinator runtime operations can break share group initialization and deletion Key: KAFKA-19204 URL: https://issues.apache.org/jira/browse/KAFKA-192

Re: [VOTE] 3.9.1 RC1

Hi Luke, as discussed in the issue https://github.com/apache/kafka-site/pull/685 On Thu, 24 Apr 2025 at 12:04, 黃竣陽 wrote: > > Hello TengYao, > > I've completed the following tests on my local machine: > > - Built from source using JDK 21 & JDK 17 (Zulu) > - Executed all unit and integration tests

Re: [PR] KAFKA-19026: add note in ZK to KRaft migration [kafka-site]

edoardocomar merged PR #685: URL: https://github.com/apache/kafka-site/pull/685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.ap

Re: [DISCUSS] KIP-1153: Kafka Streams `CloseOptions` should not have a public constructor

Hello Sophie, Thanks for your comments, I’ve updated the KIP to add a new static `build()` method for initializing the CloseOptions object. The public constructor has been deprecated, while the existing fluent-style methods remain unchanged. Best Regards, Jiunn-Yang > Sophie Blee-Goldman 於

Re: [VOTE] 3.9.1 RC1

Luke, TengYao https://github.com/apache/kafka/pull/19563 On Fri, 25 Apr 2025 at 12:18, Edoardo Comar wrote: > > Hi Luke, as discussed in the issue > https://github.com/apache/kafka-site/pull/685 > > On Thu, 24 Apr 2025 at 12:04, 黃竣陽 wrote: > > > > Hello TengYao, > > > > I've completed the follo

Re: read cluster metadata topic

Hi José, > Is your client interested in all of the endpoints exposed by the brokers or only a specific endpoint/listener? I'm actually interested in all the advertised listener configs, we use a few of them. As I see the metadata response will contain only one listener's data, the listener I acces

Re: read cluster metadata topic

hi all, I'm actually interested in all the advertised listener configs It's a coincidence that we have a KIP ( https://cwiki.apache.org/confluence/x/PZFEF) which tries to get the advertised listeners by using DESCRIBE_CONFIGS. Maybe you could give it a try as well. Best, Chia-Ping José Armand

[jira] [Created] (KAFKA-19200) Indexes should be sanity checked on startup

Gaurav Narula created KAFKA-19200: - Summary: Indexes should be sanity checked on startup Key: KAFKA-19200 URL: https://issues.apache.org/jira/browse/KAFKA-19200 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-19201) Handle deletion of a topic which has initialised share-group state

Andrew Schofield created KAFKA-19201: Summary: Handle deletion of a topic which has initialised share-group state Key: KAFKA-19201 URL: https://issues.apache.org/jira/browse/KAFKA-19201 Project: K

[jira] [Resolved] (KAFKA-19198) Deletion of topic assigned to a share group can result in NPE

[ https://issues.apache.org/jira/browse/KAFKA-19198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19198. -- Fix Version/s: 4.1.0 Resolution: Fixed > Deletion of topic assigned to a share

Re: [DISCUSS] KIP-1166: Improve high-watermark replication

Hi Jun, I updated the KIP to document the points you have raised. On Thu, Apr 24, 2025 at 1:34 PM Jun Rao wrote: > The follower of regular topic could have fetched to the end of the log from > the leader, but need to wait 500ms for the true HWM to be propagated. This > will delay the consumption

Re: [DISCUSS] KIP-1166: Improve high-watermark replication

Hi Jun, > On Thu, Apr 24, 2025 at 1:34 PM Jun Rao wrote: > > Also, in FetchResponse, we use -1 as the default for various offsets. > > Should we follow that convention for the new field? In KRaft, a value of -1 for the HighWatermark field in the FETCH response specifically indicates an unknown h

Re: [DISCUSS] KIP-1139: Add support for OAuth jwt-bearer grant type

Hey Kirk, thanks for the updates. Ack on the responses related to the custom validators behaviour (LM3) and nbf (LM4), makes sense to me. LM6. Related to testing. Have we considered using a mock Oauth server instead of the real auth frameworks/servers mentioned above? (There seems to be a few libr

[jira] [Created] (KAFKA-19205) inconsistent result of beginningOffsets/endoffset between classic consumer and async consumer with zero timeout

Chia-Ping Tsai created KAFKA-19205: -- Summary: inconsistent result of beginningOffsets/endoffset between classic consumer and async consumer with zero timeout Key: KAFKA-19205 URL: https://issues.apache.org/jira/b

Re: [DISCUSS] KIP-1139: Add support for OAuth jwt-bearer grant type

Hi Krik, Thanks for the updates. > Would adding a test dependency on Testcontainers be within the scope of this KIP, or should it have its own KIP? I don't think we need a separate KIP for this. We can include it as part of implementing the integration tests. > Also, Keycloak is MIT licensed. Is

Re: [DISCUSS] KIP-1139: Add support for OAuth jwt-bearer grant type

Hi Lianet, On Fri, Apr 25, 2025, at 10:03 AM, Lianet M. wrote: > Hey Kirk, thanks for the updates. Ack on the responses related to the > custom validators behaviour (LM3) and nbf (LM4), makes sense to me. > > LM6. Related to testing. Have we considered using a mock Oauth server > instead of the r

Re: KIP-1155: Metadata Version Downgrades [DISCUSS]

On Fri, Apr 25, 2025, at 14:26, José Armando García Sancio wrote: > Hi Colin, > > Thanks for the KIP. I have a few questions and comments. > > The "initiating the downgrade" section states "It will also check that > the requested metadata version is compatible with all the other > KIP-584 features

Re: [DISCUSS] KIP-1153: Kafka Streams `CloseOptions` should not have a public constructor

Thanks! I personally think this looks good, as we really just wanted to remove the public constructor, but I'll ping Matthias to take a look and make sure this is in line with his understanding If yes I think we can move to a vote On Fri, Apr 25, 2025 at 5:34 AM 黃竣陽 wrote: > Hello Sophie, > > T

Re: KIP-1155: Metadata Version Downgrades [DISCUSS]

Hi Colin, Thanks for the KIP. I have a few questions and comments. The "initiating the downgrade" section states "It will also check that the requested metadata version is compatible with all the other KIP-584 features that are enabled." What do you mean by this? In the same section, you have "I

[jira] [Resolved] (KAFKA-18889) Make records in ShareFetchResponse non-nullable

[ https://issues.apache.org/jira/browse/KAFKA-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-18889. --- Fix Version/s: 4.1.0 Resolution: Fixed > Make records in ShareFetchResponse non-nulla

[jira] [Created] (KAFKA-19202) Enable KIP-1071 in streams system tests where it makes sense

Lucas Brutschy created KAFKA-19202: -- Summary: Enable KIP-1071 in streams system tests where it makes sense Key: KAFKA-19202 URL: https://issues.apache.org/jira/browse/KAFKA-19202 Project: Kafka

[jira] [Resolved] (KAFKA-19131) Exception thrown while updating the RemoteLogReader threads

[ https://issues.apache.org/jira/browse/KAFKA-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash resolved KAFKA-19131. -- Fix Version/s: 4.1.0 Resolution: Fixed > Exception thrown while updatin

Re: [DISCUSS] KIP-1166: Improve high-watermark replication

Hi, Jose, Thanks for the reply. Sounds good to me. Jun On Fri, Apr 25, 2025 at 9:55 AM José Armando García Sancio wrote: > Hi Jun, > > > On Thu, Apr 24, 2025 at 1:34 PM Jun Rao > wrote: > > > Also, in FetchResponse, we use -1 as the default for various offsets. > > > Should we follow that con

Re: [DISCUSS] KIP-1153: Kafka Streams `CloseOptions` should not have a public constructor

Ah thanks Matthias, I was looking at the wrong code earlier whoops. I totally agree, the #build static constructor is out of place, as I said originally I believe we should follow the same pattern we used in KIP-1092 As for whether to literally reuse the same CloseOptions object, I'm against that,

Re: [DISCUSS] KIP-1153: Kafka Streams `CloseOptions` should not have a public constructor

Thanks for the KIP. Using `build()` method in not common in the current API. Why do we want to diverge? It seems more aligned to the current API design to replace `build()` with two static builder methods: - withTimeout(Duration) - withLeaveGropu(boolean) (Just for to illustrate. I would

[jira] [Created] (KAFKA-19206) AsyncKafkaConsumer hangs when NetworkClient fails authentication

Kirk True created KAFKA-19206: - Summary: AsyncKafkaConsumer hangs when NetworkClient fails authentication Key: KAFKA-19206 URL: https://issues.apache.org/jira/browse/KAFKA-19206 Project: Kafka I

Re: [DISCUSS] KIP-1146: Anchored wall-clock punctuation

Thanks for updating the KIP. I think you can start a vote. -Matthias On 4/13/25 10:54 PM, Herman K. Jakobsen wrote: Thank you for your inputs! It looks like my previous answer messed up the mailing thread due to the use of the hashtag symbol when creating the following list. I've tried to re

Re: KIP-1155: Metadata Version Downgrades [DISCUSS]

Hey Colin, I want to follow up to Andrew questions and your replies. First, yes both KIP-932 and KIP-1071 are going to use "Features". - https://github.com/apache/kafka/pull/19293 - https://github.com/apache/kafka/pull/19509 Don't think it's mentioned on the KIPs (at least not for KIP-1071).

Re: [DISCUSS] KIP-1153: Kafka Streams `CloseOptions` should not have a public constructor

Hello Sophie, Mathias, Thanks for your comments. I fully agree with option 2 and will proceed to update the KIP to reflect this choice. Best Regards, Jiunn-Yang > Sophie Blee-Goldman 於 2025年4月26日 清晨6:48 寫道： > > Ah thanks Matthias, I was looking at the wrong code earlier whoops. I > totally a

Re: [DISCUSS] KIP-1153: Kafka Streams `CloseOptions` should not have a public constructor

That's a good point about the DEFAULT enum, it would essentially be redundant with REMAIN_IN_GROUP since this is the default behavior for Streams regardless of whether it's dynamic or static. We only had DEFAULT for the plain consumer client because the behavior differed for these two cases. So +1

[VOTE] KIP-1140: Avoid to return null value in Map from public api of consumer

Hello all I would like to call a vote on KIP-1140: Avoid to return null value in Map from public api of consumer KIP: Discussion thread: Best Regards, Jiunn-Yang

Re: [DISCUSS] KIP-1153: Kafka Streams `CloseOptions` should not have a public constructor

hi all, It seems the consensus is to create CloseOptions for streams, and currently it is almost identical to the CloseOptions for consumers. I'm +1 to this idea, as streams may have different behavior in the future. Additionally, I want to raise a question that might highlight a difference even