Re: [DISCUSS] KIP-1090 Flaky Tests đź‘»

2024-09-21 Thread Chia-Ping Tsai
hi David I have some questions for the latest KIP. Q0: If both git and gradle develocity can be our database to query flaky, maybe we don’t need the flaky tag? As you described before, that can save the overhead of adding/removing the tags. Make senses? Q1: the main test suite should include

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #3325

2024-09-21 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-1021: Allow to get last stable offset (LSO) in kafka-get-offsets.sh

2024-09-21 Thread Kamal Chandraprakash
Hi all, It is not clear in the KIP whether we return the timestamp of the `last-stable-offset` record. For a valid timestamp (>0), we return both the record offset and its timestamp. For special offsets such as `latest` (-1) and `earliest` (-2), we return only the offset and the timestamp is set

Re: [DISCUSS] KIP-1090 Flaky Tests đź‘»

2024-09-21 Thread Chia-Ping Tsai
hi David Thanks for all response. I have a couple of questions about the quarantine test and PR flow Q0: I am still a bit confused about “should we put new integration tests into quarantine manually/automatically?” To quote the KIP: “ Automatically placing a new test into the quarantine will

Re: New release branch 3.9

2024-09-21 Thread Colin McCabe
Hi Christo, Thanks for the bug report! It's a bit tricky to decide if this is a blocker or not since it apparently has been around for a long time (it's not new in 3.9, or even in 3.7, apparently...) I also don't have a clear idea of how long we'd have to delay the release to accommodate this f

Re: [DISCUSS] KIP-1090 Flaky Tests đź‘»

2024-09-21 Thread Chia-Ping Tsai
hi José and David Maybe the unit test should be excluded from the "Flaky Test Management" and "retry" 1. unit test can NOT have "@Flaky" (if we decided to use annotation in the flaky management) 2. CI will enable the retry only for integration test. This can be addressed by adding a new flag "all

CommitFailedException during rebalance of cooperative-sticky consumer, message is not retried

2024-09-21 Thread galya bocheva
Hi Team, We are experiencing some odd behaviour of CooperativeStickyAssignor - during rebalancing of partitions a consumer receives new partition and keeps old ones. Still there is CommitFailedException received for one of the old partitions and the offsets are not retried, we receive directly t

Re: [DISCUSS] KIP-1090 Flaky Tests đź‘»

2024-09-21 Thread David Arthur
Q0/Q1: If we automatically quarantine integration tests that have had recent flakiness, I worry we will just ignore them. However, the alternative is to let them stay in the main suite while being flaky which could start to fail builds. I think the question comes down to: what is the outcome if we