[jira] [Resolved] (KAFKA-16188) Delete deprecated kafka.common.MessageReader

2024-09-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-16188. Resolution: Fixed > Delete deprecated kafka.common.MessageReader > ---

[jira] [Resolved] (KAFKA-17487) Race in GlobalStreamThread initialization

2024-09-05 Thread Nicholas Telford (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford resolved KAFKA-17487. -- Resolution: Duplicate I mistakenly created this issue before pulling trunk, which has

[jira] [Resolved] (KAFKA-17265) Fix flaky MemoryRecordsBuilderTest#testBuffersDereferencedOnClose

2024-09-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17265. Fix Version/s: 4.0.0 Resolution: Fixed > Fix flaky MemoryRecordsBuilderTest#testBuf

[VOTE] KIP-1085: Fix leaking *_DOC variables in StreamsConfig

2024-09-05 Thread 黃竣陽
Hello everyone, I would like to call for a vote on KIP-1085: The discussion can be found here: Best regards, Jiunn-Yang

Re: [VOTE] KIP-1080: Fix the typo: `maxlifeTimeMs` in CreateDelegationTokenOptions

2024-09-05 Thread Chia-Ping Tsai
+1 (binding) 黃竣陽 於 2024年9月5日 週四 下午9:08寫道: > Hello everyone, > > I would like to call for a vote on KIP-1080: < > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1080%3A+Fix+the+typo%3A+%60maxlifeTimeMs%60+in+CreateDelegationTokenOptions > > > > The discussion can be found here: >

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #3271

2024-09-05 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-1080: Fix the typo: `maxlifeTimeMs` in CreateDelegationTokenOptions

2024-09-05 Thread Lianet M.
Hey all, just one small comment: shouldn't the new method be named " maxLifetimeMs()" (Lifetime vs LifeTime)? I believe it's the right spelling, but mostly, it aligns better with the RPC field (max_lifetime_ms), that generates a CreateDelegationTokenRequestData.maxLifetimeMs() and CreateDelegationT

Re: [VOTE] KIP-1080: Fix the typo: `maxlifeTimeMs` in CreateDelegationTokenOptions

2024-09-05 Thread Chia-Ping Tsai
> it aligns better with the RPC field (max_lifetime_ms) That makes sense to me. +1 to align it Best, Chia-Ping Lianet M. 於 2024年9月5日 週四 下午11:13寫道: > Hey all, just one small comment: shouldn't the new method be named " > maxLifetimeMs()" (Lifetime vs LifeTime)? I believe it's the right spellin

Re: [VOTE] KIP-1085: Fix leaking *_DOC variables in StreamsConfig

2024-09-05 Thread Matthias J. Sax
+1 (binding) On 9/5/24 06:34, Chia-Ping Tsai wrote: +1 (binding) 黃竣陽 於 2024年9月5日 週四 下午9:13寫道: Hello everyone, I would like to call for a vote on KIP-1085: < https://cwiki.apache.org/confluence/display/KAFKA/KIP-1085%3A+Fix+leaking+*_DOC+variables+in+StreamsConfig The discussion can be f

Re: [VOTE] KIP-1085: Fix leaking *_DOC variables in StreamsConfig

2024-09-05 Thread Matthias J. Sax
+1 (binding) On 9/5/24 06:34, Chia-Ping Tsai wrote: +1 (binding) 黃竣陽 於 2024年9月5日 週四 下午9:13寫道: Hello everyone, I would like to call for a vote on KIP-1085: < https://cwiki.apache.org/confluence/display/KAFKA/KIP-1085%3A+Fix+leaking+*_DOC+variables+in+StreamsConfig The discussion can be f

Re: [EXT] Re: [VOTE] KIP-1033: Add Kafka Streams exception handler for exceptions occurring during processing

2024-09-05 Thread Matthias J. Sax
Thanks Colin. Merged the PR to `trunk` and cherry-picked to `3.9` branch. -Matthias On 9/3/24 4:07 PM, Colin McCabe wrote: Hi Matthias and Sebastien, This sounds like a very small and low-risk PR for a KIP that is new in 3.9 (KIP-1033). I think we should be OK to cherry-pick it to 3.9, even

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #3272

2024-09-05 Thread Apache Jenkins Server
See

Jenkins build is still unstable: Kafka » Kafka Branch Builder » 3.9 #58

2024-09-05 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-1080: Fix the typo: `maxlifeTimeMs` in CreateDelegationTokenOptions

2024-09-05 Thread 黃竣陽
It make sense to me, I will change to `CreateDelegationTokenRequestData.setMaxLifetimeMs` > Chia-Ping Tsai 於 2024年9月5日 晚上11:22 寫道: > >> it aligns better with the RPC field (max_lifetime_ms) > > That makes sense to me. +1 to align it > > Best, > Chia-Ping > > Lianet M. 於 2024年9月5日 週四 下午11:13

Re: [DISCUSS] KIP-512: make Record Headers available in onAcknowledgement

2024-09-05 Thread Rich C.
Thanks all. I haven't seen a strong use case that requires change on onCompletion. So I will remove it from KIP-512. When there is good motivation in the future, we can re-initialize a discussion thread and KIP. Regards, Rich On Thu, Sep 5, 2024 at 7:27 PM Chia-Ping Tsai wrote: > > I lean a >

[jira] [Created] (KAFKA-17488) Cleanup (test) code for Kafka Streams "metric version"

2024-09-05 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-17488: --- Summary: Cleanup (test) code for Kafka Streams "metric version" Key: KAFKA-17488 URL: https://issues.apache.org/jira/browse/KAFKA-17488 Project: Kafka

Re: [DISCUSS] KIP-1088: Replace KafkaClientSupplier with KafkaClientInterceptor

2024-09-05 Thread Sophie Blee-Goldman
1. Fair enough. In the end it doesn't matter that much to us, so I just figured from basic principles if this is a config then it should go in the StreamsConfig. Also happy to hear what others think 2. We need the client-specific configs (for example to extract the client ids for monitoring, resou

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

2024-09-05 Thread Sophie Blee-Goldman
Thanks for another detailed response Lucas! Especially w.r.t how the epochs are defined. I also went back and re-read KIP-848 to refresh myself, I guess it wasn't clear to me how much of the next-gen consumer protocol we are reusing vs what's being built from the ground up. S16. > It will become