Re: [DISCUSS] KIP-975 Docker Image for Apache Kafka

2023-12-20 Thread Vedarth Sharma
Hello everyone, In the course of implementing this KIP, we introduced a small piece of code in golang to prepare property files for the Docker image. Our decision was influenced by considerations such as performance, code testability, and a reduction in the final Docker image size, as outlined in

Re: [DISCUSS] KIP-975 Docker Image for Apache Kafka

2023-12-20 Thread Mickael Maison
Hi Vedarth, In the PR when I raised concerns about introducing Go to the repository you responded "Startup time will get impacted though, as java is significantly slower than golang and we are calling this script multiple times.". It would be good to provide numbers if you have, so the community c

Re: Apache Kafka 3.7.0 Release

2023-12-20 Thread Mickael Maison
Hi, With the current timeline for 3.7, I tend to agree with Viktor that JBOD support in KRaft is unlikely to receive the extensive testing this feature needs before releasing. And that's not counting the testing tasks left to do in https://issues.apache.org/jira/browse/KAFKA-14127. I'm fine stick

[jira] [Created] (KAFKA-16035) add integration test for ExpiresPerSec and RemoteLogSizeComputationTime metrics

2023-12-20 Thread Luke Chen (Jira)
Luke Chen created KAFKA-16035: - Summary: add integration test for ExpiresPerSec and RemoteLogSizeComputationTime metrics Key: KAFKA-16035 URL: https://issues.apache.org/jira/browse/KAFKA-16035 Project: Ka

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2500

2023-12-20 Thread Apache Jenkins Server
See Changes: -- [...truncated 239497 lines...] Gradle Test Run :core:test > Gradle Test Executor 95 > ZkMigrationIntegrationTest > testMigrateTopicDeletions(ClusterInstan

Re: [DISCUSS] KIP-975 Docker Image for Apache Kafka

2023-12-20 Thread Vedarth Sharma
Hi Mickael, In our previous approach startup time would have been affected if the utility script code was written in some other language. If we had just replaced the utility script with java code that would have impacted startup time significantly. In my local machine, it took around 50ms (on M2 s

Build failed in Jenkins: Kafka » Kafka Branch Builder » 3.7 #24

2023-12-20 Thread Apache Jenkins Server
See Changes: -- [...truncated 457690 lines...] Gradle Test Run :core:test > Gradle Test Executor 94 > ZkConfigMigrationClientTest > testWriteExistingClientQuotas() STARTED Gr

[jira] [Created] (KAFKA-16036) Add `group.coordinator.rebalance.protocols` and publish all new configs

2023-12-20 Thread David Jacot (Jira)
David Jacot created KAFKA-16036: --- Summary: Add `group.coordinator.rebalance.protocols` and publish all new configs Key: KAFKA-16036 URL: https://issues.apache.org/jira/browse/KAFKA-16036 Project: Kafka

Re: [DISCUSS] KIP-975 Docker Image for Apache Kafka

2023-12-20 Thread Mickael Maison
Hi Vedarth, Thanks for the quick reply and for the clarifications. I agree with your analysis and the alternative approach you found makes sense. I'll try to take a look at your PR later on today or tomorrow. Thanks, Mickael On Wed, Dec 20, 2023 at 1:33 PM Vedarth Sharma wrote: > > Hi Mickael,

Re: [DISCUSS] KIP-853: KRaft Voters Change

2023-12-20 Thread Josep Prat
Hi Jose, Did you have any time to update the KIP? Let me know if we can help in any way. Thanks in advance, On Mon, Nov 27, 2023 at 7:04 PM José Armando García Sancio wrote: > On Mon, Nov 27, 2023 at 2:32 AM Josep Prat wrote: > > I wanted to revive this thread and see if there is anything prev

[jira] [Resolved] (KAFKA-15991) Flaky new consumer test testGroupIdNotNullAndValid

2023-12-20 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-15991. --- Resolution: Fixed > Flaky new consumer test testGroupIdNotNullAndValid > ---

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2501

2023-12-20 Thread Apache Jenkins Server
See Changes: -- [...truncated 345147 lines...] > Task :streams:upgrade-system-tests-23:testClasses UP-TO-DATE > Task :streams:upgrade-system-tests-23:checkstyleTest UP-TO-D

Re: [VOTE] KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-12-20 Thread Gantigmaa Selenge
Thank you Andrew! I have now submitted a PR (https://github.com/apache/kafka/pull/14995) for the implementation of this KIP. Regards, Tina On Tue, Dec 19, 2023 at 1:32 PM Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Thanks for the KIP. > > +1 (non-binding) > > Thanks, > Andrew

Re: [DISCUSS] Road to Kafka 4.0

2023-12-20 Thread Justine Olshan
Hey Luke, I think your point is valid. This is another good reason to have a 3.8 release. Would you say that implementing KIP-966 in 3.8 would be an acceptable way to move forward? Thanks, Justine On Tue, Dec 19, 2023 at 4:35 AM Luke Chen wrote: > Hi Justine, > > Thanks for your reply. > > >

Re: [DISCUSS] KIP-975 Docker Image for Apache Kafka

2023-12-20 Thread Ismael Juma
Hi Mickael, A couple of comments inline. On Wed, Dec 20, 2023 at 3:34 AM Mickael Maison wrote: > When you say, "we have opted to take a different approach", who is > "we"? I think this decision should be made by the committers. > Changes can only be merged by committers, so I think it's implic

Re: [DISCUSS] Road to Kafka 4.0

2023-12-20 Thread Josep Prat
Hi Justine, Luke, and others, I believe a 3.8 version would make sense, and I would say KIP-853 should be part of it as well. Best, On Wed, Dec 20, 2023 at 4:11 PM Justine Olshan wrote: > Hey Luke, > > I think your point is valid. This is another good reason to have a 3.8 > release. > Would yo

[jira] [Created] (KAFKA-16037) Upgrade existing system tests to use new consumer

2023-12-20 Thread Kirk True (Jira)
Kirk True created KAFKA-16037: - Summary: Upgrade existing system tests to use new consumer Key: KAFKA-16037 URL: https://issues.apache.org/jira/browse/KAFKA-16037 Project: Kafka Issue Type: Test

Re: [DISCUSS] KIP-975 Docker Image for Apache Kafka

2023-12-20 Thread Mickael Maison
Hi, Yes changes have to be merged by a committer but for this kind of decisions it's best if it's seen by more than one. > Hmm, is this a blocker? I don't see why. It would be nice to include it in > 3.7 and we have time, so I'm fine with that. Sure, it's not a blocker in the usual sense. But if

[jira] [Created] (KAFKA-16038) Periodic Logging fo Current Assignment

2023-12-20 Thread Almog Gavra (Jira)
Almog Gavra created KAFKA-16038: --- Summary: Periodic Logging fo Current Assignment Key: KAFKA-16038 URL: https://issues.apache.org/jira/browse/KAFKA-16038 Project: Kafka Issue Type: Improvement

Re: [DISCUSS] KIP-853: KRaft Voters Change

2023-12-20 Thread José Armando García Sancio
Yes. I have been working on the KIP. I don't expect to change too much from what is currently documented. I am mainly focusing on improving the UX and readability of the KIP. I am hoping to be able to restart the discussion first thing next year. Thanks On Wed, Dec 20, 2023 at 6:11 AM Josep Prat

Re: [DISCUSS] KIP-853: KRaft Voters Change

2023-12-20 Thread Josep Prat
Hi Jose, Thanks for the update. Best, Josep Prat Open Source Engineering Director, aivenjosep.p...@aiven.io | +491715557497 | aiven.io Aiven Deutschland GmbH Alexanderufer 3-7, 10117 Berlin Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen Amtsgericht Charlottenburg, HRB 209739 B On Wed, Dec

Re: [DISCUSS] KIP-975 Docker Image for Apache Kafka

2023-12-20 Thread Ismael Juma
We should be very clear on what users can rely on when it comes to the docker images (i.e. what are public interfaces) and what are implementation details (and can be changed whenever we want). That's the only way to have a maintainable system. Same way we make changes to internal classes even thou

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2503

2023-12-20 Thread Apache Jenkins Server
See Changes: -- [...truncated 451754 lines...] Gradle Test Run :core:test > Gradle Test Executor 95 > ZkConfigMigrationClientTest > testWriteExistingTopicConfigs() PASSED

Re: DISCUSS KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2023-12-20 Thread ziming deng
Hello, thanks for mention this. In fact alterConfig and incrementalAlterConfig have different semantics, we should pass all configs when using alterConfig and we can update config incrementally using incrementalAlterConfigs, and is’t not worth doing so since alterConfig has been deprecated for

Re: DISCUSS KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2023-12-20 Thread ziming deng
> shouldn't we also introduce --disable-incremental as deprecated? I think your suggestion is nice, it should be marked as deprecated and will be removed together with `AdminClient.alterConfigs()` > On Dec 19, 2023, at 16:36, Federico Valeri wrote: > > HI Ziming, thanks for the KIP. Looks go

[jira] [Created] (KAFKA-16039) RecordHeaders supports the addAll method

2023-12-20 Thread Jianbin Chen (Jira)
Jianbin Chen created KAFKA-16039: Summary: RecordHeaders supports the addAll method Key: KAFKA-16039 URL: https://issues.apache.org/jira/browse/KAFKA-16039 Project: Kafka Issue Type: Improvem

Re: [DISCUSS] KIP-967: Support custom SSL configuration for Kafka Connect RestServer

2023-12-20 Thread Taras Ledkov
Hi team, Ping for review / vote for KIP-967 [1]. Voting thread is here [2] [1]. https://cwiki.apache.org/confluence/display/KAFKA/KIP-967%3A+Support+custom+SSL+configuration+for+Kafka+Connect+RestServer [2]. https://lists.apache.org/thread/wc4v5v3pynl15g1q547m2croqsqgmzpw -- With best regards,