Build failed in Jenkins: kafka-trunk-jdk14 #169

2020-06-04 Thread Apache Jenkins Server
See Changes: [github] KAFKA-10069: Correctly remove user-defined "predicate" and "negate" -- [...truncated 3.15 MB...] org.apache.kafka.streams.TopologyTestDriverTest >

[jira] [Created] (KAFKA-10100) LiveLeaders field in LeaderAndIsrRequest is not used anymore

2020-06-04 Thread David Jacot (Jira)
David Jacot created KAFKA-10100: --- Summary: LiveLeaders field in LeaderAndIsrRequest is not used anymore Key: KAFKA-10100 URL: https://issues.apache.org/jira/browse/KAFKA-10100 Project: Kafka I

Re: KIP-599: Throttle Create Topic, Create Partition and Delete Topic Operations

2020-06-04 Thread David Jacot
Hi Jun and Anna, Thank you both for your replies. Based on our recent discussion, I agree that using a rate is better to remain consistent with other quotas. As you both suggested, it seems that changing the way we compute the rate to better handle spiky workloads and behave a bit more similarly

Re: KIP-599: Throttle Create Topic, Create Partition and Delete Topic Operations

2020-06-04 Thread David Jacot
Hi Tom, That's a good question. As the validation does not create any load on the controller, I was planning to do it without checking the quota at all. Does that sound reasonable? Best, David On Thu, Jun 4, 2020 at 4:23 PM David Jacot wrote: > Hi Jun and Anna, > > Thank you both for your repl

Re: KIP-599: Throttle Create Topic, Create Partition and Delete Topic Operations

2020-06-04 Thread Tom Bentley
Hi David, As a user I might expect the validateOnly option to do everything except actually make the changes. That interpretation would imply the quota should be checked, but the check should obviously be side-effect free. I think this interpretation could be useful because it gives the caller eit

Re: [VOTE] KIP-599: Throttle Create Topic, Create Partition and Delete Topic Operations

2020-06-04 Thread Tom Bentley
+1 (non binding). Thanks! On Wed, Jun 3, 2020 at 3:51 PM Rajini Sivaram wrote: > +1 (binding) > > Thanks for the KIP, David! > > Regards, > > Rajini > > > On Sun, May 31, 2020 at 3:29 AM Gwen Shapira wrote: > > > +1 (binding) > > > > Looks great. Thank you for the in-depth design and discussio

Re: KIP-599: Throttle Create Topic, Create Partition and Delete Topic Operations

2020-06-04 Thread David Jacot
Hi all, I just published an updated version of the KIP which includes: * Using a slightly modified version of our Rate. I have tried to formalize it based on our discussion. As Anna suggested, we may find a better way to implement it. * Handling of ValidateOnly as pointed out by Tom. Please, chec

Re: [VOTE] KIP-599: Throttle Create Topic, Create Partition and Delete Topic Operations

2020-06-04 Thread Mickael Maison
+1 (binding) Thanks David for looking into this important issue On Thu, Jun 4, 2020 at 3:59 PM Tom Bentley wrote: > > +1 (non binding). > > Thanks! > > On Wed, Jun 3, 2020 at 3:51 PM Rajini Sivaram > wrote: > > > +1 (binding) > > > > Thanks for the KIP, David! > > > > Regards, > > > > Rajini > >

[jira] [Created] (KAFKA-10101) recovery point is advanced without flushing the data after recovery

2020-06-04 Thread Jun Rao (Jira)
Jun Rao created KAFKA-10101: --- Summary: recovery point is advanced without flushing the data after recovery Key: KAFKA-10101 URL: https://issues.apache.org/jira/browse/KAFKA-10101 Project: Kafka Is

[jira] [Resolved] (KAFKA-9576) Topic creation failure causing Stream thread death

2020-06-04 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-9576. Resolution: Duplicate > Topic creation failure causing Stream thread death > --

Build failed in Jenkins: kafka-trunk-jdk14 #172

2020-06-04 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu) in workspace

[jira] [Created] (KAFKA-10102) Source node references not updated after rebuilding topology

2020-06-04 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10102: --- Summary: Source node references not updated after rebuilding topology Key: KAFKA-10102 URL: https://issues.apache.org/jira/browse/KAFKA-10102 Project: K

Re: Please I Want to Subscribe

2020-06-04 Thread Guozhang Wang
Hello Ricardo, Here you go for the guidelines, it is self-service: https://kafka.apache.org/contact Guozhang On Wed, Jun 3, 2020 at 1:09 PM Ricardo Ferreira wrote: > Please I Want to Subscribe > > -- -- Guozhang

[jira] [Created] (KAFKA-10103) JDBC Sink Connector doesn't support numerical values in event keys

2020-06-04 Thread Jakub (Jira)
Jakub created KAFKA-10103: - Summary: JDBC Sink Connector doesn't support numerical values in event keys Key: KAFKA-10103 URL: https://issues.apache.org/jira/browse/KAFKA-10103 Project: Kafka Issue T

Re: Please I Want to Subscribe

2020-06-04 Thread Ricardo Ferreira
Thanks for the heads up! Yeah, I saw the right email but ended up sending the subscribe request for the wrong one =) Everything is fixed now. Thanks, -- Ricardo On 6/4/20 12:40 PM, Guozhang Wang wrote: Hello Ricardo, Here you go for the guidelines, it is self-service: https://kafka.apache

Jenkins build is back to normal : kafka-2.6-jdk8 #18

2020-06-04 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2020-06-04 Thread Satish Duggana
Hi Jun, Please let us know if you have any comments on "transactional support" and "follower requests/replication" mentioned in the wiki. Thanks, Satish. On Tue, Jun 2, 2020 at 9:25 PM Satish Duggana wrote: > > Thanks Jun for your comments. > > >100. It would be useful to provide more details on

Re: [DISCUSS] KIP-590: Redirect Zookeeper Mutation Protocols to The Controller

2020-06-04 Thread Boyang Chen
Hey there, bumping this thread for any further KIP-590 discussion, since it's been quiet for a while. Boyang On Thu, May 21, 2020 at 10:31 AM Boyang Chen wrote: > Thanks David, I agree the wording here is not clear, and the fellow broker > should just send a new CreateTopicRequest in this case

[jira] [Created] (KAFKA-10104) Remove deprecated --zookeeper flags as specified in KIP-604

2020-06-04 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-10104: Summary: Remove deprecated --zookeeper flags as specified in KIP-604 Key: KAFKA-10104 URL: https://issues.apache.org/jira/browse/KAFKA-10104 Project: Kafka

[jira] [Resolved] (KAFKA-10069) The user-defined "predicate" and "negate" are not removed from Transformation

2020-06-04 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-10069. Resolution: Fixed > The user-defined "predicate" and "negate" are not remo

Re: [DISCUSS] KIP-619 Deprecate ConsumerConfig#addDeserializerToConfig(Properties, Deserializer, Deserializer) and ProducerConfig#addSerializerToConfig(Properties, Serializer, Serializer)

2020-06-04 Thread Matthias J. Sax
@Chia-Ping Can you maybe start a new DISCUSS thread using the new KIP number? This would help to keep the threads separated. Thanks! -Matthias On 6/3/20 6:56 AM, Chia-Ping Tsai wrote: > When I created the KIP, the next number was 619 and not sure why the number > is out of sync. > > At any r

Re: [DISCUSS] KIP-619 Deprecate ConsumerConfig#addDeserializerToConfig(Properties, Deserializer, Deserializer) and ProducerConfig#addSerializerToConfig(Properties, Serializer, Serializer)

2020-06-04 Thread Matthias J. Sax
Btw: I think the KIP is quite straightforward and you could even skip the DISCUSS and call for a VOTE directly. -Matthias On 6/4/20 4:40 PM, Matthias J. Sax wrote: > @Chia-Ping > > Can you maybe start a new DISCUSS thread using the new KIP number? This > would help to keep the threads separate

Build failed in Jenkins: kafka-trunk-jdk14 #177

2020-06-04 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu) in workspace

Re: [DISCUSS] KIP-513: Distinguish between Key and Value serdes in scala wrapper library for kafka streams

2020-06-04 Thread Matthias J. Sax
As you say "hierarchy" I read this really as "class hierarchy". For this case, I think that we need to do it differently. I agree to this part: KeySerde extends Serde ValueSerde extends Serde However, KeySerializer extends KeySerde (etc) does not make sense IMHO, because a `KeySerializer

Re: [VOTE] KIP-572: Improve timeouts and retires in Kafka Streams

2020-06-04 Thread Matthias J. Sax
Guozhang, what you propose makes sense, but this seems to get into implementation detail territory already? Thus, if there are nor further change requests to the KIP wiki page itself, I would like to proceed with the VOTE. -Matthias On 5/20/20 12:30 PM, Guozhang Wang wrote: > Thanks Matthias,

[jira] [Resolved] (KAFKA-10040) Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-04 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10040. - Fix Version/s: 2.7.0 Resolution: Fixed > Make computing the PreferredReplicaImbal

Re: KIP-599: Throttle Create Topic, Create Partition and Delete Topic Operations

2020-06-04 Thread Jun Rao
Hi, David, Anna, Thanks for the discussion and the updated wiki. 11. If we believe the token bucket behavior is better in terms of handling the burst behavior, we probably don't need a separate KIP since it's just an implementation detail. Regarding "So instead of having one sample equal to 560

Re: [DISCUSS] KIP-513: Distinguish between Key and Value serdes in scala wrapper library for kafka streams

2020-06-04 Thread Yuriy Badalyantc
Hi Matthias, I think you misunderstood my diagram. I wanted to show the next relationships: - Serde is KeySerde and ValueSerde - KeySerde is KeySerializer and KeyDeserializer - ValueSerde is ValueSerializer and ValueDeserializer So, `Serde` is is most "powerfull" class. It could do anything. `Key

Build failed in Jenkins: kafka-trunk-jdk14 #178

2020-06-04 Thread Apache Jenkins Server
See Changes: [github] MINOR: Add explanation for disabling forwarding from value transformers [github] KAFKA-10066: TestOutputTopic should pass record headers into [github] KAFKA-10040; Make computing the Prefe

[jira] [Created] (KAFKA-10105) Regression in group coordinator dealing with flaky clients joining while leaving

2020-06-04 Thread William Reynolds (Jira)
William Reynolds created KAFKA-10105: Summary: Regression in group coordinator dealing with flaky clients joining while leaving Key: KAFKA-10105 URL: https://issues.apache.org/jira/browse/KAFKA-10105

[jira] [Created] (KAFKA-10106) measure and log time taken to handle LeaderAndIsr request

2020-06-04 Thread NIKHIL (Jira)
NIKHIL created KAFKA-10106: -- Summary: measure and log time taken to handle LeaderAndIsr request Key: KAFKA-10106 URL: https://issues.apache.org/jira/browse/KAFKA-10106 Project: Kafka Issue Type: Im

Re: [DISCUSS] KIP-619 Deprecate ConsumerConfig#addDeserializerToConfig(Properties, Deserializer, Deserializer) and ProducerConfig#addSerializerToConfig(Properties, Serializer, Serializer)

2020-06-04 Thread Chia-Ping Tsai
> I think the KIP is quite straightforward and you could even skip the > DISCUSS and call for a VOTE directly. Copy that On 2020/06/04 23:43:12, "Matthias J. Sax" wrote: > Btw: > > I think the KIP is quite straightforward and you could even skip the > DISCUSS and call for a VOTE directly. > >

[VOTE] KIP-620 Deprecate ConsumerConfig#addDeserializerToConfig(Properties, Deserializer, Deserializer) and ProducerConfig#addSerializerToConfig(Properties, Serializer, Serializer)

2020-06-04 Thread Chia-Ping Tsai
hi All, I would like to start the vote on KIP-620: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=155749118 -- Chia-Ping

Re: KIP-599: Throttle Create Topic, Create Partition and Delete Topic Operations

2020-06-04 Thread Anna Povzner
Hi David and Jun, I dug a bit deeper into the Rate implementation, and wanted to confirm that I do believe that the token bucket behavior is better for the reasons we already discussed but wanted to summarize. The main difference between Rate and token bucket is that the Rate implementation allows