[jira] [Created] (KAFKA-8654) Cant restart heartbeatThread if encountered unexpected exception in heartbeatloop。

2019-07-11 Thread nick allen (JIRA)
nick allen created KAFKA-8654: - Summary: Cant restart heartbeatThread if encountered unexpected exception in heartbeatloop。 Key: KAFKA-8654 URL: https://issues.apache.org/jira/browse/KAFKA-8654 Project: K

Jenkins build is back to normal : kafka-trunk-jdk8 #3778

2019-07-11 Thread Apache Jenkins Server
See

[jira] [Created] (KAFKA-8655) Failed to start systemctl kafka (code=exited, status=1/FAILURE)

2019-07-11 Thread Ben (JIRA)
Ben created KAFKA-8655: -- Summary: Failed to start systemctl kafka (code=exited, status=1/FAILURE) Key: KAFKA-8655 URL: https://issues.apache.org/jira/browse/KAFKA-8655 Project: Kafka Issue Type: Bug

Re: [VOTE] KIP-476: Add Java AdminClient interface

2019-07-11 Thread Andy Coates
Hi All, So voting currently stands on: Binding: +1 Matthias, +1 Colin Non-binding: +1 Thomas Becker +1 Satish Guggana +1 Ryan Dolan So we're still 1 binding vote short. :( On Wed, 3 Jul 2019 at 23:08, Matthias J. Sax wrote: > Thanks for the details Colin and Andy. > > My indent was not to

Build failed in Jenkins: kafka-trunk-jdk8 #3779

2019-07-11 Thread Apache Jenkins Server
See Changes: [ismael] KAFKA-8653; Default rebalance timeout to session timeout for JoinGroup -- [...truncated 2.63 MB...] org.apache.kafka.connect.runtime.isolation.Plugin

Re: [VOTE] KIP-476: Add Java AdminClient interface

2019-07-11 Thread Gwen Shapira
+1 (binding) Thank you for the improvement. On Thu, Jul 11, 2019, 3:53 AM Andy Coates wrote: > Hi All, > > So voting currently stands on: > > Binding: > +1 Matthias, > +1 Colin > > Non-binding: > +1 Thomas Becker > +1 Satish Guggana > +1 Ryan Dolan > > So we're still 1 binding vote short. :( >

Re: [VOTE] KIP-476: Add Java AdminClient interface

2019-07-11 Thread Rajini Sivaram
+1 (binding) Thanks for the KIP, Andy! Regards, Rajini On Thu, Jul 11, 2019 at 1:18 PM Gwen Shapira wrote: > +1 (binding) > > Thank you for the improvement. > > On Thu, Jul 11, 2019, 3:53 AM Andy Coates wrote: > > > Hi All, > > > > So voting currently stands on: > > > > Binding: > > +1 Matt

Re: [DISCUSS] KIP-213: Second follow-up on Foreign Key Joins

2019-07-11 Thread Jan Filipiak
On 10.07.2019 06:25, Adam Bellemare wrote: > In my experience (obviously empirical) it seems that many people just want > the ability to join on foreign keys for the sake of handling all the > relational data in their event streams and extra tombstones don't matter at > all. This has been my own

Re: PR builds stopped since 07/10 11AM

2019-07-11 Thread Ismael Juma
Hi all, After updating some jobs to the "modern" PR builder, I noticed several regressions and shared the details in the Apache Builds mailing list. Thankfully, the team has re-enabled the old PR builder. I have reverted the changes to the jobs so they should work as they were 2-3 days ago. Ismae

Re: PR builds stopped since 07/10 11AM

2019-07-11 Thread Bill Bejeck
Thanks Ismael! On Thu, Jul 11, 2019 at 10:41 AM Ismael Juma wrote: > Hi all, > > After updating some jobs to the "modern" PR builder, I noticed several > regressions and shared the details in the Apache Builds mailing list. > Thankfully, the team has re-enabled the old PR builder. I have reverte

[jira] [Created] (KAFKA-8656) Kafka Consumer Record Latency Metric

2019-07-11 Thread Sean Glover (JIRA)
Sean Glover created KAFKA-8656: -- Summary: Kafka Consumer Record Latency Metric Key: KAFKA-8656 URL: https://issues.apache.org/jira/browse/KAFKA-8656 Project: Kafka Issue Type: New Feature

[DISCUSS] KIP-488: Clean up Sum,Count,Total Metrics

2019-07-11 Thread John Roesler
Hi Kafka devs, I'd like to propose KIP-488 as a minor cleanup of some of our metric implementations. KIP-488: https://cwiki.apache.org/confluence/x/kkAyBw Over time, iterative updates to these metrics has resulted in a pretty confusing little collection of classes, and I've personally been invol

[DISCUSS] KIP-489 Kafka Consumer Record Latency Metric

2019-07-11 Thread Sean Glover
Hi kafka-dev, I've created KIP-489 as a proposal for adding latency metrics to the Kafka Consumer in a similar way as record-lag metrics are implemented. https://cwiki.apache.org/confluence/display/KAFKA/489%3A+Kafka+Consumer+Record+Latency+Metric Regards, Sean -- Principal Engineer, Lightbend

[jira] [Resolved] (KAFKA-8644) The Kafka protocol generator should allow null defaults for bytes and array fields

2019-07-11 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira resolved KAFKA-8644. - Resolution: Fixed Fix Version/s: 2.4.0 > The Kafka protocol generator should allow null de

[jira] [Created] (KAFKA-8657) Automatic Topic Creation on Producer

2019-07-11 Thread Justine Olshan (JIRA)
Justine Olshan created KAFKA-8657: - Summary: Automatic Topic Creation on Producer Key: KAFKA-8657 URL: https://issues.apache.org/jira/browse/KAFKA-8657 Project: Kafka Issue Type: Improvement

Re: [DISCUSS] KIP-435: Internal Partition Reassignment Batching

2019-07-11 Thread Viktor Somogyi-Vass
Hi Stan, I meant the following (maybe rare) scenario - we have replicas [1, 2, 3] on a lot of partitions and the user runs a massive rebalance to change them all to [3, 2, 1]. In the old behavior, I think that this would not do anything but simply change the replica set in ZK. Then, the user could

[jira] [Resolved] (KAFKA-8653) Regression in JoinGroup v0 rebalance timeout handling

2019-07-11 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8653. Resolution: Fixed Fix Version/s: 2.3.1 > Regression in JoinGroup v0 rebalance timeou

[DISCUSS] KIP-487: Automatic Topic Creation on Producer

2019-07-11 Thread Justine Olshan
Hello all, I'd like to start a discussion thread for KIP-487. This KIP plans to deprecate the current system of auto-creating topics through requests to the metadata and give the producer the ability to automatically create topics instead. More information can be found here: https://cwiki.apache.

Re: [DISCUSS] KIP-488: Clean up Sum,Count,Total Metrics

2019-07-11 Thread Matthias J. Sax
Thanks for the KIP. Overall LGTM. The only though I have is, if we may want to use `TotalSum` and `TotalCount` instead of `CumulativeSum/Count` as names? -Matthias On 7/11/19 9:31 AM, John Roesler wrote: > Hi Kafka devs, > > I'd like to propose KIP-488 as a minor cleanup of some of our metric

Re: [DISCUSS] KIP-466: Add support for List serialization and deserialization

2019-07-11 Thread Matthias J. Sax
Daniyar, thanks for the update to the KIP. It's in really good shape and well written. About the default constructor question: All Serdes/Serializer/Deserializer classes need a default constructor to create them easily via reflections when specifies in a config. I understand that it is not super

Re: [DISCUSS] KIP-478 Strongly Typed Processor API

2019-07-11 Thread Matthias J. Sax
Side remark: > Now that "flat transform" is a specific >> part of the API it seems okay to steer folks in that direction (to never >> use context.process in a transformer), but it should be called out >> explicitly in javadocs. Currently Transformer (which is used for both >> transform() and flat

Re: [DISCUSS] KIP-479: Add Materialized to Join

2019-07-11 Thread Bill Bejeck
Thanks all for the great discussion so far. Everyone has made excellent points, and I appreciate the detail everyone has put into their arguments. However, after carefully evaluating all the points made so far, creating an overload with Materialized is still my #1 option. My reasoning for saying

Re: [DISCUSS] KIP-488: Clean up Sum,Count,Total Metrics

2019-07-11 Thread Bruno Cadonna
Hi John, Thank you for the KIP. LGTM I also do not like CumulativeSum/Count so much. I propose to just call it Sum and Count. I understand that you want to unequivocally distinguish the two metric functions by their names, but I have the feeling the names become artificially complex. The exact

Re: [jira] [Created] (KAFKA-8326) Add List Serde

2019-07-11 Thread Jan Filipiak
I think this encourages bad descissions. Lets just have people define repeated fields in thrift,avro,json, protobuf. Its gonna look nasty if you got your 11th layer of lists. If you really want to add lists, please do Map aswell in 1 shot Best Jan On 06.05.2019 17:59, Daniyar Yeralin (JIRA) wrot

Build failed in Jenkins: kafka-trunk-jdk11 #689

2019-07-11 Thread Apache Jenkins Server
See Changes: [cshapi] KAFKA-8644; The Kafka protocol generator should allow null defaults for -- [...truncated 2.56 MB...] org.apache.kafka.connect.json.JsonConverterTest

[jira] [Resolved] (KAFKA-7688) Allow byte array class for Decimal Logical Types to fix Debezium Issues

2019-07-11 Thread Konstantine Karantasis (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-7688. --- Resolution: Fixed Fix Version/s: (was: 1.1.1) This issue was resol

Build failed in Jenkins: kafka-trunk-jdk8 #3780

2019-07-11 Thread Apache Jenkins Server
See Changes: [cshapi] KAFKA-8644; The Kafka protocol generator should allow null defaults for -- [...truncated 2.55 MB...] org.apache.kafka.connect.transforms.ReplaceFiel

request access to create KIP

2019-07-11 Thread Jose M
Hello, Id like permisssions to create a new KIP on the wiki. Wiki Id: jose.moralesaragon Thanks a lot, Jose M

Re: request access to create KIP

2019-07-11 Thread Jun Rao
Hi, Jose, Thanks for your interest. Just gave you the wiki permission. Jun On Thu, Jul 11, 2019 at 3:39 PM Jose M wrote: > Hello, > > Id like permisssions to create a new KIP on the wiki. > > Wiki Id: jose.moralesaragon > > > Thanks a lot, > > Jose M >

Re: [DISCUSS] KIP-488: Clean up Sum,Count,Total Metrics

2019-07-11 Thread Matthias J. Sax
`Sum` is an existing name, for the "sampled sum" metric, that gets deprecated. Hence, we cannot use it. If we cannot use `Sum` and use `TotalSum`, we should also not use `Count` but `TotalCount` for consistency. -Matthias On 7/11/19 12:58 PM, Bruno Cadonna wrote: > Hi John, > > Thank you for

Re: [DISCUSSION] KIP-418: A method-chaining way to branch KStream

2019-07-11 Thread Matthias J. Sax
Ivan, did you see my last reply? What do you think about my proposal to mix both approaches and try to get best-of-both worlds? -Matthias On 6/11/19 3:56 PM, Matthias J. Sax wrote: > Thanks for the input John! > >> under your suggestion, it seems that the name is required > > If you want to g

[jira] [Resolved] (KAFKA-8424) Replace ListGroups request/response with automated protocol

2019-07-11 Thread Boyang Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-8424. Resolution: Fixed > Replace ListGroups request/response with automated protocol > -

Re: [DISCUSS] KIP-487: Automatic Topic Creation on Producer

2019-07-11 Thread Dhruvil Shah
Hi Justine, Thanks for the KIP, this is great! Could you add some more information about what deprecating the broker configuration means? Would we log a warning in the logs when auto topic creation is enabled on the broker, for example? Thanks, Dhruvil On Thu, Jul 11, 2019 at 10:28 AM Justine O

Re: [DISCUSS] KIP-487: Automatic Topic Creation on Producer

2019-07-11 Thread Justine Olshan
Hi Dhruvil, Thanks for reading the KIP! That was the general idea for deprecation. We would log a warning when the config is enabled on the broker. I also believe that there would be a change to documentation. If there is anything else that should be done, please let me know! Justine On Thu, Jul

[jira] [Resolved] (KAFKA-5635) KIP-181 Kafka-Connect integrate with kafka ReST Proxy

2019-07-11 Thread Konstantine Karantasis (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-5635. --- Resolution: Won't Fix > KIP-181 Kafka-Connect integrate with kafka ReST Proxy

Re: [DISCUSS]KIP-216: IQ should throw different exceptions for different errors

2019-07-11 Thread Matthias J. Sax
Thanks Vito! I think the KIP shapes out nicely! To answer the open question you raised (I also adjust my answers based on the latest KIP update) About `StreamThreadNotStartedException`: I understand what you pointed out. However, I think we can consider the following: If a thread is not starte

Re: [DISCUSS] KIP-480 : Sticky Partitioner

2019-07-11 Thread Colin McCabe
Hi Justine, I agree that we shouldn't change RoundRobinPartitioner, since its behavior is already specified. However, we could add a new, separate StickyRoundRobinPartitioner class to KIP-480 which just implemented the sticky behavior regardless of whether the key was null. That seems pretty

Re: [VOTE] KIP-480 : Sticky Partitioner

2019-07-11 Thread Colin McCabe
+1 (binding). Thanks, Justine! ComputedPartition#get probably should be ComputedPartition#partition or something. We typically name accessors the same as the variables that are being accessed. As we discussed in the other thread, one minor addition that might make this KIP even better is a S

Re: [DISCUSS] KIP-487: Automatic Topic Creation on Producer

2019-07-11 Thread Colin McCabe
Hi Justine, Thanks for the KIP. This seems like a good step towards removing server-side topic auto-creation. We should add included "client-side" to the title of the KIP somewhere, to make it clear that we're talking about client-side auto creation. The KIP says: > In order to automatically

Re: [DISCUSS] KIP-480 : Sticky Partitioner

2019-07-11 Thread Jun Rao
Hi, Justine, Thanks for the KIP. Nice writeup and great results. Just one comment. 100. To add a record to the accumulator, the producer needs to know the partition id. The decision of whether the record can be added to the current batch is only made after the accumulator.append() call. So, when

Re: [DISCUSS] KIP-482: The Kafka Protocol should Support Optional Fields

2019-07-11 Thread Colin McCabe
On Tue, Jul 9, 2019, at 15:29, Jose Armando Garcia Sancio wrote: > Thanks Colin for the KIP. For my own edification why are we doing this > "Optional fields can have any type, except for an array of structures."? > Why can't we have an array of structures? Optional fields are serialized starting w

Jenkins build is back to normal : kafka-trunk-jdk11 #690

2019-07-11 Thread Apache Jenkins Server
See