Re: [VOTE] KIP-349 Priorities for Source Topics

2019-01-06 Thread Adam Bellemare
Hi Nick Is this change only for the basic consumer? How would this affect anything with Kafka Streams? Thanks > On Jan 5, 2019, at 10:52 PM, n...@afshartous.com wrote: > > Bumping again for more votes. > -- > Nick > > >> On Dec 26, 2018, at 12:36 PM, n...@afshartous.com wrote: >> >>

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2019-01-06 Thread Dongjin Lee
Happy new year. I just updated the title and contents of KIP and Jira issue, with updated draft implementation. Now both of compression level and buffer size options are available to producer and broker configuration. You can check the updated KIP from modified URL: https://cwiki.apache.org/confl

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2019-01-06 Thread Ismael Juma
Thanks Dongjin. One minor suggestion: we should mention that the broker side configs are also topic configs (i.e. can be set for a given topic). Ismael On Sun, Jan 6, 2019, 10:37 AM Dongjin Lee Happy new year. > > I just updated the title and contents of KIP and Jira issue, with updated > draft

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2019-01-06 Thread Dongjin Lee
Thanks for pointing out Ismael. It's now updated. Best, Dongjin On Mon, Jan 7, 2019 at 4:36 AM Ismael Juma wrote: > Thanks Dongjin. One minor suggestion: we should mention that the broker > side configs are also topic configs (i.e. can be set for a given topic). > > Ismael > > On Sun, Jan 6, 20

Re: [DISCUSS] KIP-411: Add option to make Kafka Connect task client ID values unique

2019-01-06 Thread Paul Davidson
Hi Ewen, Thanks for the feedback! If that's the case, would it maybe be possible to compatibly change the > default to use task IDs in the client ID, but only if we don't see an > existing override from the worker config? This would only change the > behavior when someone is using the default, bu

Re: [DISCUSS] KIP-411: Add option to make Kafka Connect task client ID values unique

2019-01-06 Thread Paul Davidson
Hi Konstantine, Thanks for your feedback! I think my reply to Ewen covers most of your points, and I mostly agree. If there is general agreement that changing the default behavior is preferable to a config change I will update my PR to use that approach. Paul On Fri, Jan 4, 2019 at 5:55 PM Ko

Build failed in Jenkins: kafka-trunk-jdk8 #3287

2019-01-06 Thread Apache Jenkins Server
See Changes: [github] MINOR: Bump js template to 2.2 (#6086) -- [...truncated 4.50 MB...] org.apache.kafka.streams.test.OutputVerifierTest > shouldFailIfValueIsDifferentW