Re: The purpose of ProducerRecord Headers

2018-06-10 Thread Matthias J. Sax
Check out the KIP that added headers: https://cwiki.apache.org/confluence/display/KAFKA/KIP-82+-+Add+Record+Headers -Matthias On 6/8/18 8:23 PM, wrote: > Hi team: > When I reading KafkaProducer doSend() and I found each record have a > Header[] headers . > But I don't know

[jira] [Created] (KAFKA-7031) Kafka Connect API module depends on Jersey

2018-06-10 Thread Randall Hauch (JIRA)
Randall Hauch created KAFKA-7031: Summary: Kafka Connect API module depends on Jersey Key: KAFKA-7031 URL: https://issues.apache.org/jira/browse/KAFKA-7031 Project: Kafka Issue Type: Bug

Re: [VOTE] KIP-228 Negative record timestamp support

2018-06-10 Thread Matthias J. Sax
+1 (binding) Thanks for the KIP. -Matthias On 5/29/18 9:14 AM, Konstantin Chukhlomin wrote: > Thanks, updated the KIP. > https://cwiki.apache.org/confluence/display/KAFKA/KIP-228+Negative+record+timestamp+support > >

Re: [VOTE] KIP-280: Enhanced log compaction

2018-06-10 Thread Matthias J. Sax
+1 (binding) -Matthias On 6/9/18 12:39 AM, Luís Cabral wrote: > Hi all, > > Any takers on having a look at this KIP and voting on it? > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-280%3A+Enhanced+log+compaction > > Cheers, > Luis > signature.asc Description: OpenPGP digital sig

Re: [VOTE] KIP-228 Negative record timestamp support

2018-06-10 Thread Ted Yu
+1 On Sun, Jun 10, 2018 at 2:17 PM, Matthias J. Sax wrote: > +1 (binding) > > Thanks for the KIP. > > > -Matthias > > On 5/29/18 9:14 AM, Konstantin Chukhlomin wrote: > > Thanks, updated the KIP. > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 228+Negative+record+timestamp+support <

Re: [DISCUSSION] KIP-300: Add Windowed KTable API in StreamsBuilder

2018-06-10 Thread Matthias J. Sax
Thanks lot for the KIP. The general idea to allow reading windowed-KTables is very useful! Couple of initial comments/question: About only adding a single `windowedTable()` with no overloads: - retention time is no mandatory parameter and we can always use the default of 1 day - instead of e

Re: [DISCUSS] KIP-307: Allow to define custom processor names with KStreams DSL

2018-06-10 Thread Matthias J. Sax
Just catching up on this thread. I like the general idea. Couple of comments: - I think that adding `Processed` (or maybe a different name?) is a valid proposal for stateless operators that only have a single overload atm. It would align with the overall API design. - for all methods with mult

Re: [DISCUSS] KIP-313: Add KStream.flatTransform and KStream.flatTransformValues

2018-06-10 Thread Matthias J. Sax
Thanks for the KIP. I don't have any comments at this pint. Overall I am +1 on the KIP. -Matthias On 6/8/18 2:56 PM, Bruno Cadonna wrote: > Hi list, > > I created KIP-313 [1] for JIRA issue KAFKA-4217 [2] and I would like to > put the KIP up for discussion. > > Best regards, > Bruno > > > [

Re: [VOTE] KIP-280: Enhanced log compaction

2018-06-10 Thread Ted Yu
bq. When this configuration is set to anything other than "*offset*" or " *timestamp*", then the record headers are scanned for a key matching this value. Can the value be determined now ? My thinking is that what if there is a third compaction strategy proposed in the future ? We should guard aga

Re: [DISCUSS]KIP-216: IQ should throw different exceptions for different errors

2018-06-10 Thread Matthias J. Sax
Vito, what is the status of this KIP? I just re-read it, and have a couple of follow up comments. Why do we discuss the internal exceptions you want to add? Also, do we really need them? Can't we just throw the correct exception directly instead of wrapping it later? When would we throw an `Stat

Re: [DISCUSS] KIP-262 Metadata should include the number of state stores for task

2018-06-10 Thread Matthias J. Sax
Richard, KIP-268 got merged and thus this KIP is unblocked. I just re-read it and think it needs some updates with regard to the upgrade path (ie, you should mention why upgrading is covered). It would also be useful to discuss how the store information is used during assignment. Atm, the KIP on

Re: [DISCUSS]: KIP-230: Name Windowing Joins

2018-06-10 Thread Matthias J. Sax
What is the status of this KIP? I also want to point out, that it seems that there is some overlap with KIP-307 that was proposed recently (I cc'ed Florian who proposed KIP-307). KIP-230 might even be subsumed. I any case, it would be good to sync up and collaborate for both KIPs. -Matthias O

Re: [DISCUSS] KIP-221: Repartition Topic Hints in Streams

2018-06-10 Thread Matthias J. Sax
What is the status of this KIP? -Matthias On 2/13/18 1:43 PM, Matthias J. Sax wrote: > Is there any update for this KIP? > > > -Matthias > > On 12/4/17 2:08 PM, Matthias J. Sax wrote: >> Jeyhun, >> >> thanks for updating the KIP. >> >> I am wondering if you intend to add a new class `Produced

Re: [VOTE] KIP-206: Add support for UUID serialization and deserialization

2018-06-10 Thread Matthias J. Sax
Jakub, it seems that you got enough votes. I am closing the KIP as accepted with - 3 binding votes (Ewen, Rajini, Damian) - 4 non-binding (Ted, Colin, Manikumar, Mickael - one non-binding -1 (Jan) Feel free to update the PR -- it might need a rebase. -Matthias On 5/11/18 3:31 PM, Damia

Re: The purpose of ProducerRecord Headers

2018-06-10 Thread Darion Yaphet
thanks ~ Matthias J. Sax 于2018年6月10日周日 下午3:38写道: > Check out the KIP that added headers: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-82+-+Add+Record+Headers > > -Matthias > > On 6/8/18 8:23 PM, 逐风者的祝福 wrote: > > Hi team: > > When I reading KafkaProducer doSend() and I found eac

Re: [VOTE] KIP-206: Add support for UUID serialization and deserialization

2018-06-10 Thread Jakub Scholz
Hi Matthias, There was some guy who took this KIP over - he had an opened PR and everything so I let him do it. But from the PR it seems that he now abandoned it (https://github.com/apache/kafka/pull/4438) - he didn't responded in a while. I will have a look at it so that it can be fixed and merge

[jira] [Created] (KAFKA-7032) The TimeUnit is neglected by KakfaConsumer#close(long, TimeUnit)

2018-06-10 Thread Chia-Ping Tsai (JIRA)
Chia-Ping Tsai created KAFKA-7032: - Summary: The TimeUnit is neglected by KakfaConsumer#close(long, TimeUnit) Key: KAFKA-7032 URL: https://issues.apache.org/jira/browse/KAFKA-7032 Project: Kafka