Re: [VOTE] KIP-278: Add version option to Kafka's commands

2018-05-11 Thread zhenya Sun
+1 building > 在 2018年5月11日,上午9:51,Ted Yu 写道: > > +1 > > On Thu, May 10, 2018 at 6:42 PM, Sasaki Toru > wrote: > >> Hi all, >> >> I would like to start the vote on KIP-278: Add version option to Kafka's >> commands. >> >> The link to this KIP is here: >>

Re: [VOTE] KIP-278: Add version option to Kafka's commands

2018-05-11 Thread Manikumar
+1 (non-binding) Thanks for the KIP. On Fri, May 11, 2018 at 12:56 PM, zhenya Sun wrote: > +1 building > > 在 2018年5月11日,上午9:51,Ted Yu 写道: > > > > +1 > > > > On Thu, May 10, 2018 at 6:42 PM, Sasaki Toru > > wrote: > > > >> Hi all, > >> > >> I would like to start the vote on KIP-278: Add versio

Re: KIP-244: Add Record Header support to Kafka Streams

2018-05-11 Thread Jorge Esteban Quilcate Otoya
Thanks Guozhang and Matthias! I do also agree with this way of handling headers inheritance. I will add them to the KIP doc. > We can discuss about extending the current protocol and how to enable users > override those rule, and how to expose them in the DSL layer in a future > KIP. About this,

Jenkins build is back to normal : kafka-trunk-jdk8 #2640

2018-05-11 Thread Apache Jenkins Server
See

[jira] [Created] (KAFKA-6898) org.apache.kafka.common.errors.TimeoutException

2018-05-11 Thread Rishi (JIRA)
Rishi created KAFKA-6898: Summary: org.apache.kafka.common.errors.TimeoutException Key: KAFKA-6898 URL: https://issues.apache.org/jira/browse/KAFKA-6898 Project: Kafka Issue Type: Bug Affects Ver

REMINDER: Apache EU Roadshow 2018 schedule announced!

2018-05-11 Thread sharan
Hello Apache Supporters and Enthusiasts This is a reminder that the schedule for the Apache EU Roadshow 2018 in Berlin has been announced. http://apachecon.com/euroadshow18/schedule.html Please note that we will not be running an ApacheCon in Europe this year which means that this Apache EU

Re: [VOTE] KIP-294 - Enable TLS hostname verification by default

2018-05-11 Thread Rajini Sivaram
Hi Jun, I have updated the KIP with examples on setting ssl.endpoint.identification. algorithm to an empty string. It turns out I had to update ConfigCommand to do this for dynamic configs, I have updated the PR as well. Thanks for pointing this out! Regards, Rajini On Fri, May 11, 2018 at 12

Re: [VOTE] KIP-278: Add version option to Kafka's commands

2018-05-11 Thread Jason Gustafson
Thanks for the KIP! +1 (binding) On Fri, May 11, 2018 at 12:35 AM, Manikumar wrote: > +1 (non-binding) > > Thanks for the KIP. > > On Fri, May 11, 2018 at 12:56 PM, zhenya Sun wrote: > > > +1 building > > > 在 2018年5月11日,上午9:51,Ted Yu 写道: > > > > > > +1 > > > > > > On Thu, May 10, 2018 at 6:42

[jira] [Resolved] (KAFKA-5965) Remove Deprecated AdminClient from Streams Resetter Tool

2018-05-11 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-5965. -- Resolution: Fixed Fix Version/s: 2.0.0 > Remove Deprecated AdminClient from Streams Reset

Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop Timeout and Make It Reachable by the End User

2018-05-11 Thread Guozhang Wang
+1 (binding), thanks! Guozhang On Thu, May 10, 2018 at 4:41 PM, Ismael Juma wrote: > Thanks for the KIP, +1 (binding). A few suggestions: > > 1. We normally include the time unit in configs. Not sure if we do it for > command line parameters though, so can we please verify and make it > consi

Re: [VOTE] KIP-278: Add version option to Kafka's commands

2018-05-11 Thread Guozhang Wang
Thanks Toru-san, +1 (binding) On Fri, May 11, 2018 at 8:30 AM, Jason Gustafson wrote: > Thanks for the KIP! +1 (binding) > > On Fri, May 11, 2018 at 12:35 AM, Manikumar > wrote: > > > +1 (non-binding) > > > > Thanks for the KIP. > > > > On Fri, May 11, 2018 at 12:56 PM, zhenya Sun wrote: > > >

[jira] [Resolved] (KAFKA-6394) Prevent misconfiguration of advertised listeners

2018-05-11 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-6394. Resolution: Fixed Fix Version/s: 2.0.0 > Prevent misconfiguration of advertised liste

Re: [VOTE] KIP-278: Add version option to Kafka's commands

2018-05-11 Thread Thomas Crayford
+1 (non-binding) On Fri, May 11, 2018 at 5:17 PM, Guozhang Wang wrote: > Thanks Toru-san, +1 (binding) > > On Fri, May 11, 2018 at 8:30 AM, Jason Gustafson > wrote: > > > Thanks for the KIP! +1 (binding) > > > > On Fri, May 11, 2018 at 12:35 AM, Manikumar > > wrote: > > > > > +1 (non-binding)

Re: KIP-244: Add Record Header support to Kafka Streams

2018-05-11 Thread Guozhang Wang
That's a good question. I think we can manage this in KIP-159. I will go ahead and try to augment that KIP together with the original author Jeyhun. Guozhang On Fri, May 11, 2018 at 12:45 AM, Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Thanks Guozhang and Matthias! I do al

Re: [DISCUSS] KIP-290: Support for wildcard suffixed ACLs

2018-05-11 Thread Andy Coates
i think I'm agreeing with you. I was merely suggesting that having an additional field that controls how the current field is interpreted is more flexible / extensible in the future than using a 'union' style approach, where only one of several possible fields should be populated. But it's a minor

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Andy Coates
Sorry for my lack of response - I've been out of action with a bad back for a few days! I originally had the `Materialized` overloads added to the API. I'll update the KIP / PR with these again. In terms of semantics, as Matthias suggests, these should be consistent with filter() and mapValues(),

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Guozhang Wang
Hi folks, While looking into the overloaded functions, I'm wondering if we can save the transformers without key, i.e. only add two overloaded functions: KTable transformValues(final ValueTransformerWithKeySupplier valueTransformerSupplier, final String... stat

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Andy Coates
With reference to Guozhang's comment: Then are we going to still only allow the valueTransofmer.init() / process() to be able to access N stores, with N stores specified with the stateStoreNames, but not the one specified in materialized.name()? Personally I think it should be the case as the mate

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Andy Coates
Makes sense to me. What do others think? On 11 May 2018 at 10:13, Guozhang Wang wrote: > Hi folks, > > While looking into the overloaded functions, I'm wondering if we can save > the transformers without key, i.e. only add two overloaded functions: > > KTable transformValues(final ValueTransfo

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Damian Guy
I'm a +1 for Guozhang's suggestion On Fri, 11 May 2018 at 10:20 Andy Coates wrote: > Makes sense to me. What do others think? > > On 11 May 2018 at 10:13, Guozhang Wang wrote: > > > Hi folks, > > > > While looking into the overloaded functions, I'm wondering if we can save > > the transformers

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Andy Coates
OK, KIP updated: - added overloads taking `Materialized` - dropped overloads taking `ValueTransformerSupplier` in favour of the `withKey` variants. - added more info around the limitations of the ProcessorContext passed in to the transformer's init calls, i.e. no forward calls allowed or calls t

Re: KIP-244: Add Record Header support to Kafka Streams

2018-05-11 Thread Matthias J. Sax
I am actually not sure about this. Because it's about the semantics at PAPI level, but KIP-159 targets the DSL, it might actually be better to have a separate KIP? -Matthias On 5/11/18 9:26 AM, Guozhang Wang wrote: > That's a good question. I think we can manage this in KIP-159. I will go > ahead

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Andy Coates
Just a thought - but on the subject of disallowing access to the materialized state store from within the transformer's init method... might this not be overly restrictive? Could there be valid uses where read-only access would be useful / valid. On 11 May 2018 at 10:35, Andy Coates wrote: > OK,

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Andy Coates
Thinking that through more - I guess if the user wanted the output to also be fed back in as the input on future computations, they wouldn't use the transformValues() overload with Materialized, but rather create a materialized store and pass it in via stateStoreNames. On 11 May 2018 at 10:42, And

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Guozhang Wang
Yes I was indeed thinking about now allowing `getStateStore()` to with the name specified in Materialized. I understand it is a bit too restrictive, but I cannot think of a elegant way to work around the following: 1) to programmatically enforce that the restore store is read-only. 2) With Materi

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Matthias J. Sax
I don't think it worth to complicate things and restrict the access to the store that is created by the library via `Materialized` parameter. The reason is, that we don't prevent this from happening anyway atm -- users can always create an arbitrary processor and connect a KTable state with the pro

Build failed in Jenkins: kafka-trunk-jdk10 #101

2018-05-11 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-5965: Remove Deprecated AdminClient from Streams Resetter Tool [jason] KAFKA-6394; Add a check to prevent misconfiguration of advertised --

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Andy Coates
I'm no expert, so happy to go with what ever is decided. Implementing it so that a call to getStateStore(queryableStoreName) throws an exception is trivial enough to do, though I can see your point that this might be better done in a more consistent / single place, rather than peppered through the

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Guozhang Wang
Matthias' point is valid, that today we are not effectively preventing users to programmatically access any materialized state store and mutate it on the fly anyways. This is a caveat that we should improve since as Andy asked, the implications of mutating a materialized store is "undefined" as of

[jira] [Resolved] (KAFKA-6813) Remove deprecated APIs from KIP-120 and KIP-182 in Streams

2018-05-11 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-6813. -- Resolution: Fixed > Remove deprecated APIs from KIP-120 and KIP-182 in Streams > ---

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Matthias J. Sax
Sounds good to me to do it in a different KIP (if at all---not convinced yet we need this restriction). -Matthias On 5/11/18 11:36 AM, Guozhang Wang wrote: > Matthias' point is valid, that today we are not effectively preventing > users to programmatically access any materialized state store a

Build failed in Jenkins: kafka-trunk-jdk7 #3423

2018-05-11 Thread Apache Jenkins Server
See -- Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H28 (ubuntu xenial) in workspace

Re: [VOTE] KIP-278: Add version option to Kafka's commands

2018-05-11 Thread Attila Sasvári
+1 (non-binding) Thomas Crayford ezt írta (időpont: 2018. máj. 11., P 18:20): > +1 (non-binding) > > On Fri, May 11, 2018 at 5:17 PM, Guozhang Wang wrote: > > > Thanks Toru-san, +1 (binding) > > > > On Fri, May 11, 2018 at 8:30 AM, Jason Gustafson > > wrote: > > > > > Thanks for the KIP! +1 (b

Build failed in Jenkins: kafka-trunk-jdk7 #3424

2018-05-11 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu xenial) in workspace

Jenkins build is back to normal : kafka-trunk-jdk10 #102

2018-05-11 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk10 #103

2018-05-11 Thread Apache Jenkins Server
See Changes: [github] KAFKA-6813: Remove deprecated APIs in KIP-182, Part III (#4991) -- [...truncated 1.25 MB...] at org.gradle.api.internal.tasks.testing.result

Build failed in Jenkins: kafka-trunk-jdk7 #3425

2018-05-11 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu xenial) in workspace

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Andy Coates
Awesome. Thanks to you both - KIP updated appropriately. On 11 May 2018 at 11:52, Matthias J. Sax wrote: > Sounds good to me to do it in a different KIP (if at all---not convinced > yet we need this restriction). > > > -Matthias > > > > On 5/11/18 11:36 AM, Guozhang Wang wrote: > > Matthias' poi

[VOTE] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Andy Coates
Hi all, I would like to start the vote on KIP-292: Add transformValues() method to KTable The link to this KIP is here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-292%3A+Add+transformValues%28%29+method+to+KTable The discussion thread is here: http://mail-archives.apache.org/mod_mbox/

Re: [VOTE] KIP-292: Add KTable#transformValues() method in Kafka Streams DSL

2018-05-11 Thread Guozhang Wang
+1 (binding) Also slightly changed the title beyond changing [DISCUSS] to [VOTE] since Gmail will collapse these two threads into one, so people may not realize there is a voting started already. Guozhang On Fri, May 11, 2018 at 2:07 PM, Andy Coates wrote: > Hi all, > > I would like to start

Re: [VOTE] KIP-292: Add KTable#transformValues() method in Kafka Streams DSL

2018-05-11 Thread Ted Yu
+1 On Fri, May 11, 2018 at 2:16 PM, Guozhang Wang wrote: > +1 (binding) > > Also slightly changed the title beyond changing [DISCUSS] to [VOTE] since > Gmail will collapse these two threads into one, so people may not realize > there is a voting started already. > > > Guozhang > > > On Fri, May

Re: [VOTE] KIP-292: Add KTable#transformValues() method in Kafka Streams DSL

2018-05-11 Thread Matthias J. Sax
+1 (binding) On 5/11/18 2:17 PM, Ted Yu wrote: > +1 > > On Fri, May 11, 2018 at 2:16 PM, Guozhang Wang wrote: > >> +1 (binding) >> >> Also slightly changed the title beyond changing [DISCUSS] to [VOTE] since >> Gmail will collapse these two threads into one, so people may not realize >> there

Build failed in Jenkins: kafka-trunk-jdk10 #104

2018-05-11 Thread Apache Jenkins Server
See Changes: [wangguoz] HOTFIX: RegexSourceIntegrationTest needs to cleanup shared output topic -- [...truncated 1.50 MB...] kafka.admin.ResetConsumerGroupOffsetTest > t

Build failed in Jenkins: kafka-trunk-jdk8 #2642

2018-05-11 Thread Apache Jenkins Server
See Changes: [wangguoz] MINOR: Count fix and Type alias refactor in Streams Scala API (#4966) [mjsax] MINOR - Fix typo in Streams Dev Guide (#4972) [github] KAFKA-6813: Remove deprecated APIs in KIP-182, Part I

Re: [VOTE] KIP-206: Add support for UUID serialization and deserialization

2018-05-11 Thread Damian Guy
+1 (binding) On Fri, 4 May 2018 at 08:55 Rajini Sivaram wrote: > Hi Brandon, > > +1 (binding) > > Thanks for the KIP! > > Regards, > > Rajini > > On Fri, May 4, 2018 at 2:14 PM, Brandon Kirchner < > brandon.kirch...@gmail.com > > wrote: > > > I'd like to resurrect this one last time, any chance

Build failed in Jenkins: kafka-trunk-jdk7 #3426

2018-05-11 Thread Apache Jenkins Server
See Changes: [wangguoz] MINOR: Count fix and Type alias refactor in Streams Scala API (#4966) [mjsax] MINOR - Fix typo in Streams Dev Guide (#4972) [github] KAFKA-6813: Remove deprecated APIs in KIP-182, Part I

Kafka Connect: New Kafka Source Connector

2018-05-11 Thread McCaig, Rhys
Hi there, Over at Comcast we just open sourced a Kafka source connector for Kafka Connect. (https://github.com/Comcast/MirrorTool-for-Kafka-Connect) We’ve used this as an alternative to MirrorMaker on a couple of projects. While discussing open sourcing the project, we realized that the function

Re: KIP-244: Add Record Header support to Kafka Streams

2018-05-11 Thread Guozhang Wang
Yeah I'm only talking about the DSL part (i.e. how stateful / stateless operators default inheritance protocol would be promised) to be managed with KIP-159. For allowing users to override the default behavior in PAPI, that would be in a different KIP. Guozhang On Fri, May 11, 2018 at 10:41 AM

Re: [DISCUSS] KIP-290: Support for wildcard suffixed ACLs

2018-05-11 Thread Colin McCabe
Hi Andy, I see what you mean. I guess my thought here is that if the fields are private, we can change it later if we need to. I definitely agree that we should use the scheme you describe for sending ACLs over the wire (just the string + version number) cheers, Colin On Fri, May 11, 2018,

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

2018-05-11 Thread Colin McCabe
On Wed, May 9, 2018, at 05:41, Viktor Somogyi wrote: > Hi Colin, > > > We are going to need to create a new version of AlterConfigsRequest to add > > the "incremental" boolean. So while we're doing that, maybe we can change > > the type to NULLABLE_STRING. > > I was just talking to a colleague

Re: [VOTE] KIP-278: Add version option to Kafka's commands

2018-05-11 Thread Colin McCabe
+1 (non-binding) Colin On Fri, May 11, 2018, at 12:35, Attila Sasvári wrote: > +1 (non-binding) > > Thomas Crayford ezt írta (időpont: 2018. máj. > 11., P 18:20): > > > +1 (non-binding) > > > > On Fri, May 11, 2018 at 5:17 PM, Guozhang Wang wrote: > > > > > Thanks Toru-san, +1 (binding) > > >

Build failed in Jenkins: kafka-trunk-jdk10 #105

2018-05-11 Thread Apache Jenkins Server
See Changes: [github] MINOR: Ensure sensor names are unique in Kafka Streams (#5009) -- [...truncated 1.50 MB...] kafka.coordinator.transaction.TransactionCoordinatorTest

Jenkins build is back to normal : kafka-trunk-jdk7 #3427

2018-05-11 Thread Apache Jenkins Server
See

Jenkins build is back to normal : kafka-trunk-jdk8 #2643

2018-05-11 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk8 #2644

2018-05-11 Thread Apache Jenkins Server
See Changes: [github] MINOR: Ensure sensor names are unique in Kafka Streams (#5009) -- [...truncated 423.41 KB...] kafka.utils.json.JsonValueTest > testDecodeString STAR