[GitHub] kafka pull request: KAFKA-2439: Add MirrorMaker service class for ...

2015-08-18 Thread granders
GitHub user granders opened a pull request: https://github.com/apache/kafka/pull/148 KAFKA-2439: Add MirrorMaker service class for system tests Added MirrorMaker service and a few corresponding sanity checks, as well as necessary config template files. A few additional updates to ac

[jira] [Commented] (KAFKA-2439) Add MirrorMakerService to ducktape system tests

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14700909#comment-14700909 ] ASF GitHub Bot commented on KAFKA-2439: --- GitHub user granders opened a pull request:

[jira] [Updated] (KAFKA-2439) Add MirrorMakerService to ducktape system tests

2015-08-18 Thread Geoffrey Anderson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Anderson updated KAFKA-2439: - Reviewer: Ewen Cheslack-Postava > Add MirrorMakerService to ducktape system tests > --

[GitHub] kafka pull request: MINOR: Use `EasyMock.newCapture` instead of de...

2015-08-18 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/149 MINOR: Use `EasyMock.newCapture` instead of deprecated `new Capture` You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka fix-easy-mock-depr

[jira] [Commented] (KAFKA-2385) zookeeper-shell does not work

2015-08-18 Thread Prabhjot Singh Bharaj (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701294#comment-14701294 ] Prabhjot Singh Bharaj commented on KAFKA-2385: -- I had reported the shell does

[jira] [Reopened] (KAFKA-2385) zookeeper-shell does not work

2015-08-18 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira reopened KAFKA-2385: - Ok, I'll check, and in the meanwhile, you can just get a copy of the zk distribution directly

[jira] [Commented] (KAFKA-2203) Get gradle build to work with Java 8

2015-08-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701393#comment-14701393 ] Gwen Shapira commented on KAFKA-2203: - Thanks [~aw]. The report in HADOOP-12129 looks

[jira] [Commented] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

2015-08-18 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701418#comment-14701418 ] Flavio Junqueira commented on KAFKA-1387: - It doesn't look like it 'd be a small c

[jira] [Commented] (KAFKA-2203) Get gradle build to work with Java 8

2015-08-18 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701486#comment-14701486 ] Allen Wittenauer commented on KAFKA-2203: - We've got a ways to go before we do a r

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-18 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/#review95671 --- Ship it! Thanks for the latest patch. +1. I only have a few minor c

[jira] [Commented] (KAFKA-1690) Add SSL support to Kafka Broker, Producer and Consumer

2015-08-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701502#comment-14701502 ] Jun Rao commented on KAFKA-1690: [~sriharsha], thanks for the latest patch. It looks good

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-18 Thread Jun Rao
> On Aug. 3, 2015, 4:50 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java, > > lines 368-381 > > > > > > If handshake status is BUFFER_OVERFLOW, we will return to

[jira] [Commented] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

2015-08-18 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701509#comment-14701509 ] Guozhang Wang commented on KAFKA-1387: -- Thanks [~fpj], that makes sense to me. [~jwle

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-18 Thread Aditya Auradkar
> On Aug. 5, 2015, 4:44 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java, > > line 55 > > > > > > We actually will need different constructors for different versio

[jira] [Commented] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

2015-08-18 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701571#comment-14701571 ] Flavio Junqueira commented on KAFKA-1387: - [~guozhang] it looks like [~jwl...@gmai

Re: [DISCUSS] Client-side Assignment for New Consumer

2015-08-18 Thread Jun Rao
Jason, Thanks for the writeup. A few comments below. 1. When there are multiple common protocols in the JoinGroupRequest, which one would the coordinator pick? 2. If the protocols don't agree, the group construction fails. What exactly does it mean? Do we send an error in every JoinGroupResponse

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-18 Thread Sriharsha Chintalapani
> On Aug. 18, 2015, 4:09 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java, > > line 450 > > > > > > The termination condition doesn't seem quite right. If dst ha

Re: [DISCUSS] Client-side Assignment for New Consumer

2015-08-18 Thread Jason Gustafson
Hi Jun, Answers below: 1. When there are multiple common protocols in the JoinGroupRequest, which one would the coordinator pick? I was intending to use the list to indicate preference. If all group members support protocols ["A", "B"] in that order, then we will choose "A." If some support ["B"

Re: [DISCUSSION] Kafka 0.8.2.2 release?

2015-08-18 Thread Gwen Shapira
Thanks Jun. I updated the list with your suggestions. If anyone feels we are missing a critical patch for 0.8.2.2, please speak up. Gwen On Mon, Aug 17, 2015 at 5:40 PM, Jun Rao wrote: > Hi, Grant, > > I took a look at that list. None of those is really critical as you said. > So, I'd suggest

Re: [DISCUSSION] Kafka 0.8.2.2 release?

2015-08-18 Thread Neha Narkhede
How about looking at the scope for the 0.8.3 release first before we cut yet another point release off of 0.8.2.2? Each release includes some overhead and if there is a larger release in the works, it might be worth working on getting that. My take is that the 2 things the community has been waitin

[jira] [Created] (KAFKA-2442) QuotasTest should not fail when cpu is busy

2015-08-18 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-2442: --- Summary: QuotasTest should not fail when cpu is busy Key: KAFKA-2442 URL: https://issues.apache.org/jira/browse/KAFKA-2442 Project: Kafka Issue Type: Bug R

Re: [DISCUSS] Client-side Assignment for New Consumer

2015-08-18 Thread Jiangjie Qin
Jun, Yes, I agree. If the metadata can be synced quickly there should not be an issue. It just occurred to me that there is a proposal to allow consuming from followers in ISR, that could potentially cause more frequent metadata change for consumers. Would that be an issue? Thanks, Jiangjie (Bec

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-18 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/ --- (Updated Aug. 18, 2015, 6:24 p.m.) Review request for kafka. Bugs: KAFKA-1690

[jira] [Updated] (KAFKA-1690) Add SSL support to Kafka Broker, Producer and Consumer

2015-08-18 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1690: -- Attachment: KAFKA-1690_2015-08-18_11:24:46.patch > Add SSL support to Kafka Brok

[jira] [Commented] (KAFKA-1690) Add SSL support to Kafka Broker, Producer and Consumer

2015-08-18 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701735#comment-14701735 ] Sriharsha Chintalapani commented on KAFKA-1690: --- Updated reviewboard https:/

Re: [DISCUSSION] Kafka 0.8.2.2 release?

2015-08-18 Thread Gwen Shapira
I completely agree that community focus on 0.8.3 is important and don't want to take away from that effort. That said, not everyone will upgrade to 0.8.3 immediately (unfortunately), and there is still value in releasing bugfixes on previous releases. I'm keeping the scope very small, to make the

Re: [DISCUSSION] Kafka 0.8.2.2 release?

2015-08-18 Thread Edward Ribeiro
I sort of follow Daniel Nelson on this issue: cut a 0.8.2.2 but not include much thing besides Snappy fixes. I mean, include a couple of additional critical bug fixes, if really urgent, and that's it. On Tue, Aug 18, 2015 at 3:25 PM, Daniel Nelson wrote: > I am strongly in favor of cutting a 0.8

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-18 Thread Sriharsha Chintalapani
> On Aug. 18, 2015, 4:09 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java, > > line 438 > > > > > > Hmm, do we want to break here? It seems that we want to conti

[jira] [Updated] (KAFKA-2439) Add MirrorMakerService to ducktape system tests

2015-08-18 Thread Geoff Anderson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoff Anderson updated KAFKA-2439: -- Labels: patch-available (was: ) > Add MirrorMakerService to ducktape system tests > ---

Re: [DISCUSSION] Kafka 0.8.2.2 release?

2015-08-18 Thread Andrew Otto
I agree: keep it simple :) The latest stable version of Kafka right now has a critical bug in it. Fixing that would be good enough. 0.8.2.2 should probably just a maintenance/bugfix release. > On Aug 18, 2015, at 14:29, Edward Ribeiro wrote: > > I sort of follow Daniel Nelson on this issue

Re: [DISCUSSION] Kafka 0.8.2.2 release?

2015-08-18 Thread Gwen Shapira
Jun, KAFKA-2147 doesn't seem to have a commit associated with it, so I can't cherrypick just this fix. I suggest leaving this out since there is a 0.8.2.x workaround in the JIRA. Gwen On Mon, Aug 17, 2015 at 5:24 PM, Jun Rao wrote: > Gwen, > > Thanks for putting the list together. > > I'd reco

Re: Kafka KIP meeting Aug. 18

2015-08-18 Thread Jun Rao
The the following are the notes for today's KIP discussion. * client-side assignment strategy: We discussed concerns about rebalancing time due to metadata inconsistency, especially when lots of topics are subscribed. Will discuss a bit more on the mailing list. * CopyCat data api: The discussion

[jira] [Updated] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

2015-08-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2308: Fix Version/s: 0.8.2.2 > New producer + Snappy face un-compression errors after broker restart > ---

[jira] [Updated] (KAFKA-2235) LogCleaner offset map overflow

2015-08-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2235: Fix Version/s: 0.8.2.2 > LogCleaner offset map overflow > -- > >

[jira] [Updated] (KAFKA-2189) Snappy compression of message batches less efficient in 0.8.2.1

2015-08-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2189: Fix Version/s: 0.8.2.2 > Snappy compression of message batches less efficient in 0.8.2.1 > -

[jira] [Updated] (KAFKA-1836) metadata.fetch.timeout.ms set to zero blocks forever

2015-08-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1836: Fix Version/s: 0.8.2.2 > metadata.fetch.timeout.ms set to zero blocks forever >

[jira] [Updated] (KAFKA-1883) NullPointerException in RequestSendThread

2015-08-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1883: Fix Version/s: 0.8.2.2 > NullPointerException in RequestSendThread > ---

[jira] [Updated] (KAFKA-2096) Enable keepalive socket option for broker to prevent socket leak

2015-08-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2096: Fix Version/s: 0.8.2.2 > Enable keepalive socket option for broker to prevent socket leak >

[jira] [Updated] (KAFKA-2114) Unable to change min.insync.replicas default

2015-08-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2114: Fix Version/s: 0.8.2.2 > Unable to change min.insync.replicas default >

[jira] [Updated] (KAFKA-1057) Trim whitespaces from user specified configs

2015-08-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1057: Fix Version/s: 0.8.2.2 > Trim whitespaces from user specified configs >

[jira] [Updated] (KAFKA-1668) TopicCommand doesn't warn if --topic argument doesn't match any topics

2015-08-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1668: Fix Version/s: 0.8.2.2 > TopicCommand doesn't warn if --topic argument doesn't match any topics > --

[jira] [Updated] (KAFKA-1758) corrupt recovery file prevents startup

2015-08-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1758: Fix Version/s: 0.8.2.2 > corrupt recovery file prevents startup > --

Re: [DISCUSSION] Kafka 0.8.2.2 release?

2015-08-18 Thread Gwen Shapira
Any objections if I leave KAFKA-2114 (setting min.insync.replicas default) out? The test code is using changes that were done after 0.8.2.x cut-off, which makes it difficult to cherry-pick. Gwen On Tue, Aug 18, 2015 at 12:16 PM, Gwen Shapira wrote: > Jun, > > KAFKA-2147 doesn't seem to have

[GitHub] kafka pull request: KAFKA-2436; log.retention.hours should be hono...

2015-08-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (KAFKA-2436) log.retention.hours should be honored by LogManager

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701894#comment-14701894 ] ASF GitHub Bot commented on KAFKA-2436: --- Github user asfgit closed the pull request

[jira] [Updated] (KAFKA-2436) log.retention.hours should be honored by LogManager

2015-08-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2436: Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Pu

[jira] [Updated] (KAFKA-2136) Client side protocol changes to return quota delays

2015-08-18 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2136: - Attachment: KAFKA-2136_2015-08-18_13:19:57.patch > Client side protocol changes to return

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-18 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/ --- (Updated Aug. 18, 2015, 8:20 p.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Commented] (KAFKA-2136) Client side protocol changes to return quota delays

2015-08-18 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701925#comment-14701925 ] Aditya A Auradkar commented on KAFKA-2136: -- Updated reviewboard https://reviews.a

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-18 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/ --- (Updated Aug. 18, 2015, 8:24 p.m.) Review request for kafka, Joel Koshy and Jun

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-18 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/ --- (Updated Aug. 18, 2015, 8:24 p.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Commented] (KAFKA-2136) Client side protocol changes to return quota delays

2015-08-18 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701929#comment-14701929 ] Aditya A Auradkar commented on KAFKA-2136: -- Updated reviewboard https://reviews.a

[jira] [Updated] (KAFKA-2136) Client side protocol changes to return quota delays

2015-08-18 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2136: - Attachment: KAFKA-2136_2015-08-18_13:24:00.patch > Client side protocol changes to return

Re: Kafka KIP meeting Aug. 18

2015-08-18 Thread Flavio Junqueira
Thanks for the notes, Jun. There was a mention of single-writer behavior, if I understood correctly, in the context of the new consumer, and I was wondering if that's specific to the new consumer work or if it's going to have any dependency or relation to KIP-27. -Flavio > On 18 Aug 2015, at 2

Re: Kafka KIP meeting Aug. 18

2015-08-18 Thread Jun Rao
Yes, that's related to the zombie consumer. Basically, if a consumer is in a long GC, it may be taken out of the group. However, when the consumer wakes up from the GC, it may still be able to consume data that it's no longer responsible for. We protect this a little bit by not allowing a zombie co

[jira] [Commented] (KAFKA-1070) Auto-assign node id

2015-08-18 Thread Alex Etling (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702030#comment-14702030 ] Alex Etling commented on KAFKA-1070: Hello Kafka Geniuses, I have a question rega

Re: [DISCUSS] Client-side Assignment for New Consumer

2015-08-18 Thread Jason Gustafson
Follow-up from the kip call: 1. Onur brought up the question of whether this protocol provides enough coordination capabilities to be generally useful in practice (is that accurate, Onur?). If it doesn't, then each use case would probably need a dependence on zookeeper anyway, and we haven't reall

[jira] [Commented] (KAFKA-1070) Auto-assign node id

2015-08-18 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702059#comment-14702059 ] Sriharsha Chintalapani commented on KAFKA-1070: --- [~paetling] Here auto-assig

[jira] [Commented] (KAFKA-2367) Add Copycat runtime data API

2015-08-18 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702063#comment-14702063 ] Neha Narkhede commented on KAFKA-2367: -- I think there are various tradeoffs, as with

[jira] [Commented] (KAFKA-2041) Add ability to specify a KeyClass for KafkaLog4jAppender

2015-08-18 Thread Benoy Antony (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702161#comment-14702161 ] Benoy Antony commented on KAFKA-2041: - [~junrao], Would you be able to review the late

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-18 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/#review95793 --- clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.ja

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-18 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/#review95798 --- Ship it! Looks good to me. Could you rebase? - Jun Rao On Aug. 1

[jira] [Created] (KAFKA-2443) Expose windowSize on Measurable

2015-08-18 Thread Aditya Auradkar (JIRA)
Aditya Auradkar created KAFKA-2443: -- Summary: Expose windowSize on Measurable Key: KAFKA-2443 URL: https://issues.apache.org/jira/browse/KAFKA-2443 Project: Kafka Issue Type: Task

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-18 Thread Aditya Auradkar
> On Aug. 18, 2015, 11:33 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/ClientQuotaManager.scala, line 147 > > > > > > The window used here is a bit different from that used in > > Rate.measure() and it

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-18 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/ --- (Updated Aug. 19, 2015, 12:24 a.m.) Review request for kafka. Bugs: KAFKA-169

[jira] [Updated] (KAFKA-1690) Add SSL support to Kafka Broker, Producer and Consumer

2015-08-18 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1690: -- Attachment: KAFKA-1690_2015-08-18_17:24:48.patch > Add SSL support to Kafka Brok

[jira] [Commented] (KAFKA-1690) Add SSL support to Kafka Broker, Producer and Consumer

2015-08-18 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702223#comment-14702223 ] Sriharsha Chintalapani commented on KAFKA-1690: --- Updated reviewboard https:/

Re: [DISCUSSION] Kafka 0.8.2.2 release?

2015-08-18 Thread Daniel Nelson
I am strongly in favor of cutting a 0.8.2.2 release, but I don’t think that it needs to include anything other than the fix for Snappy that kicked off this discussion in the first place. If there are additional critical issues that can be included without delaying the process, I see no downside.

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-18 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/#review95765 --- I haven't finished going through the latest patch, but discussed con

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-18 Thread Sriharsha Chintalapani
> On Aug. 19, 2015, 1:56 a.m., Joel Koshy wrote: > > clients/src/main/java/org/apache/kafka/common/utils/Utils.java, line 520 > > > > > > second flip after `BUFFER_OVERFLOW` in `handshakeWrap` - you had > > mention

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-18 Thread Sriharsha Chintalapani
> On Aug. 19, 2015, 1:56 a.m., Joel Koshy wrote: > > clients/src/main/java/org/apache/kafka/common/utils/Utils.java, line 520 > > > > > > second flip after `BUFFER_OVERFLOW` in `handshakeWrap` - you had > > mention

Build failed in Jenkins: Kafka-trunk #590

2015-08-18 Thread Apache Jenkins Server
See Changes: [cshapi] KAFKA-2436; log.retention.hours should be honored by LogManager -- [...truncated 1501 lines...] kafka.api.test.ProducerCompressionTest > testCompression[2] PASSED kafka.api.Prod

[jira] [Updated] (KAFKA-2330) Vagrantfile sets global configs instead of per-provider override configs

2015-08-18 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2330: - Reviewer: Gwen Shapira (was: Joe Stein) > Vagrantfile sets global configs instead

[jira] [Commented] (KAFKA-2330) Vagrantfile sets global configs instead of per-provider override configs

2015-08-18 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702443#comment-14702443 ] Ewen Cheslack-Postava commented on KAFKA-2330: -- [~gwenshap] Reassigned to you

[jira] [Updated] (KAFKA-1690) Add SSL support to Kafka Broker, Producer and Consumer

2015-08-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1690: --- Resolution: Fixed Status: Resolved (was: Patch Available) [~sriharsha], thanks a lot for your enduran

Re: Review Request 36652: Patch for KAFKA-2351

2015-08-18 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/#review95824 --- Patch needs a rebase. core/src/main/scala/kafka/network/SocketServ

[jira] [Commented] (KAFKA-1690) Add SSL support to Kafka Broker, Producer and Consumer

2015-08-18 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702548#comment-14702548 ] Sriharsha Chintalapani commented on KAFKA-1690: --- Thanks a lot [~junrao] [~jj

[jira] [Commented] (KAFKA-2377) Add copycat system tests

2015-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702585#comment-14702585 ] ASF GitHub Bot commented on KAFKA-2377: --- GitHub user ewencp opened a pull request:

[GitHub] kafka pull request: KAFKA-2377: Add basic system test for copycat ...

2015-08-18 Thread ewencp
GitHub user ewencp opened a pull request: https://github.com/apache/kafka/pull/150 KAFKA-2377: Add basic system test for copycat using source and sink file connectors. Tests standalone mode by running separate source and sink connectors, catting data into the source file, and v

[jira] [Updated] (KAFKA-2377) Add copycat system tests

2015-08-18 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2377: - Reviewer: Gwen Shapira Status: Patch Available (was: Open) [~gwenshap] assi