[jira] [Commented] (KAFKA-2329) Consumers balance fails when multiple consumers are started simultaneously.

[ https://issues.apache.org/jira/browse/KAFKA-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634222#comment-14634222 ] Guozhang Wang commented on KAFKA-2329: -- Thanks for the patch [~zklapow], a couple com

[jira] [Commented] (KAFKA-2350) Add KafkaConsumer pause capability

[ https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634229#comment-14634229 ] Yasuhiro Matsuda commented on KAFKA-2350: - Can we have TopicPartition rather than

[jira] [Commented] (KAFKA-2337) Verify that metric names will not collide when creating new topics

[ https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634247#comment-14634247 ] Gwen Shapira commented on KAFKA-2337: - Pushed to trunk. Thanks for the patch [~granth

[jira] [Commented] (KAFKA-2342) transient unit test failure in testConsumptionWithBrokerFailures

[ https://issues.apache.org/jira/browse/KAFKA-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634266#comment-14634266 ] ASF GitHub Bot commented on KAFKA-2342: --- GitHub user hachikuji opened a pull request

[GitHub] kafka pull request: KAFKA-2342; fix transient unit test failure Co...

GitHub user hachikuji opened a pull request: https://github.com/apache/kafka/pull/88 KAFKA-2342; fix transient unit test failure ConsumerBounceTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/hachikuji/kafka KAFKA-2342 Alter

[jira] [Commented] (KAFKA-2342) transient unit test failure in testConsumptionWithBrokerFailures

[ https://issues.apache.org/jira/browse/KAFKA-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634274#comment-14634274 ] Jason Gustafson commented on KAFKA-2342: [~junrao], I found a case where a rebalan

[GitHub] kafka pull request: Fixed javadoc for committed return value

GitHub user sslavic opened a pull request: https://github.com/apache/kafka/pull/89 Fixed javadoc for committed return value If no offset has been committed, then committed method does not return (null) value, instead NoOffsetForPartitionException is thrown in that case. You can mer

Re: Review Request 34492: Patch for KAFKA-2210

> On July 16, 2015, 2:16 a.m., Jun Rao wrote: > > Thanks for the patch. A few comments below. > > > > Also, > > 1. For making user/group case-insensitive, could you start a discussion > > thread on the dev mailing list to see if anyone has concerns on this? > > 2. Got the following compilation

[GitHub] kafka pull request: KAFKA-2328; merge-kafka-pr.py script should no...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[jira] [Commented] (KAFKA-2328) merge-kafka-pr.py script should not leave user in a detached branch

[ https://issues.apache.org/jira/browse/KAFKA-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634279#comment-14634279 ] ASF GitHub Bot commented on KAFKA-2328: --- Github user asfgit closed the pull request

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/ --- (Updated July 20, 2015, 11:42 p.m.) Review request for kafka. Bugs: KAFKA-221

[jira] [Commented] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634280#comment-14634280 ] Parth Brahmbhatt commented on KAFKA-2210: - Updated reviewboard https://reviews.apa

Re: Review Request 34492: Patch for KAFKA-2210

> On July 16, 2015, 10:32 p.m., Edward Ribeiro wrote: > > core/src/main/scala/kafka/security/auth/Operation.scala, lines 43-44 > > > > > > +1. As of today, it spills out a Match error that can be confusing to > > fig

[jira] [Updated] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2210: Attachment: KAFKA-2210_2015-07-20_16:42:18.patch > KafkaAuthorizer: Add all public entities,

[jira] [Updated] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2210: Status: Patch Available (was: In Progress) > KafkaAuthorizer: Add all public entities, conf

[jira] [Updated] (KAFKA-2328) merge-kafka-pr.py script should not leave user in a detached branch

[ https://issues.apache.org/jira/browse/KAFKA-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2328: Resolution: Fixed Reviewer: Gwen Shapira Fix Version/s: 0.8.3 Status: Reso

[jira] [Commented] (KAFKA-2350) Add KafkaConsumer pause capability

[ https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634294#comment-14634294 ] Jason Gustafson commented on KAFKA-2350: I don't see why not. In that case, I assu

[jira] [Comment Edited] (KAFKA-2350) Add KafkaConsumer pause capability

[ https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634294#comment-14634294 ] Jason Gustafson edited comment on KAFKA-2350 at 7/20/15 11:49 PM: --

[jira] [Commented] (KAFKA-2350) Add KafkaConsumer pause capability

[ https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634296#comment-14634296 ] Edward Ribeiro commented on KAFKA-2350: --- Nit: wouldn't the inverse of ``pause`` to b

Build failed in Jenkins: KafkaPreCommit #158

See Changes: [cshapi] KAFKA-2337; Verify that metric names will not collide when creating new topics; patched by Grant Henke; reviewed by Edward Ribeiro, Ashish Singh and Gwen Shapira -- [...tru

[jira] [Commented] (KAFKA-2350) Add KafkaConsumer pause capability

[ https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634322#comment-14634322 ] Yasuhiro Matsuda commented on KAFKA-2350: - To me the state preservation is not a r

[jira] [Commented] (KAFKA-824) java.lang.NullPointerException in commitOffsets

[ https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634327#comment-14634327 ] Parth Brahmbhatt commented on KAFKA-824: [~junrao] Looked at the fix code and ensur

Jenkins build is back to normal : Kafka-trunk #550

See

[jira] [Updated] (KAFKA-2337) Verify that metric names will not collide when creating new topics

[ https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-2337: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) > Ve

Build failed in Jenkins: KafkaPreCommit #159

See Changes: [cshapi] KAFKA-2328; merge-kafka-pr.py script should not leave user in a detached branch -- [...truncated 803 lines...] kafka.log.OffsetMapTest > testClear PASSED kafka.log.LogManage

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review92341 --- core/src/main/scala/kafka/security/auth/Acl.scala (line 86)

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review92345 --- core/src/main/scala/kafka/security/auth/Acl.scala (line 71)

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review92347 --- core/src/main/scala/kafka/security/auth/PermissionType.scala (line

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review92349 --- core/src/main/scala/kafka/security/auth/Acl.scala (line 136)

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review92350 --- core/src/main/scala/kafka/server/KafkaApis.scala (line 620)

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review92351 --- core/src/main/scala/kafka/security/auth/Acl.scala (line 86)

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review92352 --- core/src/main/scala/kafka/security/auth/KafkaPrincipal.scala (line

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review92353 --- core/src/main/scala/kafka/security/auth/KafkaPrincipal.scala (line

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review92354 --- core/src/main/scala/kafka/security/auth/Operation.scala (line 43) <

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review92355 --- core/src/main/scala/kafka/server/KafkaApis.scala (line 148)

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review92356 --- core/src/main/scala/kafka/server/KafkaApis.scala (line 536)

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review92357 --- core/src/main/scala/kafka/server/KafkaApis.scala (line 136)

[jira] [Commented] (KAFKA-2275) Add a ListTopics() API to the new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634404#comment-14634404 ] Ashish K Singh commented on KAFKA-2275: --- [~hachikuji] thanks for your response. I wa

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review92358 --- core/src/main/scala/kafka/server/KafkaApis.scala (line 163)

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review92359 --- core/src/main/scala/kafka/security/auth/PermissionType.scala (line

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review92361 --- core/src/main/scala/kafka/security/auth/PermissionType.scala (line

Re: Review Request 33620: Patch for KAFKA-1690

> On June 30, 2015, 3:03 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java, > > line 67 > > > > > > Shouldn't we only start the ssl handshake after the raw socket >

Re: Review Request 33620: Patch for KAFKA-1690

> On June 30, 2015, 3:03 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/network/SocketServer.scala, line 393 > > > > > > This parameter doesn't seem to be used. We can remove it. I am using for metrics > On Jun

Re: Review Request 33620: Patch for KAFKA-1690

> On June 30, 2015, 5:20 p.m., Joel Koshy wrote: > > clients/src/main/java/org/apache/kafka/common/network/Channel.java, lines > > 148-150 > > > > > > This should be caught by checkstyle - can you double-check? If we

Re: Review Request 33620: Patch for KAFKA-1690

> On June 24, 2015, 4:39 p.m., Jiangjie Qin wrote: > > clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java, > > lines 75-78 > > > > > > Can they be replaced by clear() method? These are set o

Re: Review Request 33620: Patch for KAFKA-1690

> On May 22, 2015, 12:33 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java, > > line 294 > > > > > > Not sure why we are looping back here. If the HandshakeStatus is

[jira] [Updated] (KAFKA-2100) Client Error doesn't preserve or display original server error code when it is an unknown code

[ https://issues.apache.org/jira/browse/KAFKA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2100: Assignee: David Jacot (was: Gwen Shapira) > Client Error doesn't preserve or display original serve

[jira] [Commented] (KAFKA-2100) Client Error doesn't preserve or display original server error code when it is an unknown code

[ https://issues.apache.org/jira/browse/KAFKA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634435#comment-14634435 ] Gwen Shapira commented on KAFKA-2100: - Go ahead, all yours :) > Client Error doesn't

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634465#comment-14634465 ] Edward Ribeiro commented on KAFKA-2338: --- Hi [~gwenshap], whenever you have a free cy

[jira] [Created] (KAFKA-2351) Brokers are having a problem shutting down correctly

Mayuresh Gharat created KAFKA-2351: -- Summary: Brokers are having a problem shutting down correctly Key: KAFKA-2351 URL: https://issues.apache.org/jira/browse/KAFKA-2351 Project: Kafka Issue

[GitHub] kafka pull request: KAFKA-1621 : Standardize --messages option

Github user rekhajoshm closed the pull request at: https://github.com/apache/kafka/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[jira] [Commented] (KAFKA-1621) Standardize --messages option in perf scripts

[ https://issues.apache.org/jira/browse/KAFKA-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634555#comment-14634555 ] ASF GitHub Bot commented on KAFKA-1621: --- Github user rekhajoshm closed the pull requ

Re: Review Request 36578: Patch for KAFKA-2338

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/#review92374 --- In addition to inline comments, the patch fell out of sync recently

<    1   2