[jira] [Created] (KAFKA-2320) Configure GitHub pull request build in Jenkins

Ismael Juma created KAFKA-2320: -- Summary: Configure GitHub pull request build in Jenkins Key: KAFKA-2320 URL: https://issues.apache.org/jira/browse/KAFKA-2320 Project: Kafka Issue Type: Task

[jira] [Created] (KAFKA-2321) Introduce CONTRIBUTING.md

Ismael Juma created KAFKA-2321: -- Summary: Introduce CONTRIBUTING.md Key: KAFKA-2321 URL: https://issues.apache.org/jira/browse/KAFKA-2321 Project: Kafka Issue Type: Improvement Repor

[jira] [Commented] (KAFKA-2320) Configure GitHub pull request build in Jenkins

[ https://issues.apache.org/jira/browse/KAFKA-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618177#comment-14618177 ] Ismael Juma commented on KAFKA-2320: This needs to be done by someone that has permiss

Review Request 36298: Patch for KAFKA-2321

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36298/ --- Review request for kafka. Bugs: KAFKA-2321 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-2321) Introduce CONTRIBUTING.md

[ https://issues.apache.org/jira/browse/KAFKA-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618182#comment-14618182 ] Ismael Juma commented on KAFKA-2321: Created reviewboard https://reviews.apache.org/r/

[jira] [Updated] (KAFKA-2321) Introduce CONTRIBUTING.md

[ https://issues.apache.org/jira/browse/KAFKA-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2321: --- Status: Patch Available (was: Open) > Introduce CONTRIBUTING.md > - > >

[jira] [Updated] (KAFKA-2321) Introduce CONTRIBUTING.md

[ https://issues.apache.org/jira/browse/KAFKA-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2321: --- Attachment: KAFKA-2321.patch > Introduce CONTRIBUTING.md > - > >

Re: Review Request 36298: Patch for KAFKA-2321

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36298/ --- (Updated July 8, 2015, 8:13 a.m.) Review request for kafka. Bugs: KAFKA-2321

[jira] [Commented] (KAFKA-2321) Introduce CONTRIBUTING.md

[ https://issues.apache.org/jira/browse/KAFKA-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618193#comment-14618193 ] Ismael Juma commented on KAFKA-2321: This should only be merged after KAFKA-2187 is me

Re: [DISCUSS] Using GitHub Pull Requests for contributions and code review

An update on this. On Thu, Apr 30, 2015 at 2:12 PM, Ismael Juma wrote: > >1. CI builds triggered by GitHub PRs (this is supported by Apache >Infra, we need to request it for Kafka and provide whatever configuration >is needed) > > Filed https://issues.apache.org/jira/browse/KAFKA-232

[jira] [Commented] (KAFKA-1372) Upgrade to Gradle 1.10

[ https://issues.apache.org/jira/browse/KAFKA-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618260#comment-14618260 ] ASF GitHub Bot commented on KAFKA-1372: --- Github user sslavic closed the pull request

[GitHub] kafka pull request: KAFKA-1372 Upgrade to Gradle 1.10

Github user sslavic closed the pull request at: https://github.com/apache/kafka/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] kafka pull request: Upgrade Gradle wrapper to Gradle 2.0

Github user sslavic closed the pull request at: https://github.com/apache/kafka/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (KAFKA-1559) Upgrade Gradle wrapper to Gradle 2.0

[ https://issues.apache.org/jira/browse/KAFKA-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618264#comment-14618264 ] ASF GitHub Bot commented on KAFKA-1559: --- Github user sslavic closed the pull request

[jira] [Created] (KAFKA-2322) Use Java 7 features to improve code quality

Ismael Juma created KAFKA-2322: -- Summary: Use Java 7 features to improve code quality Key: KAFKA-2322 URL: https://issues.apache.org/jira/browse/KAFKA-2322 Project: Kafka Issue Type: Improvement

[jira] [Updated] (KAFKA-1372) Upgrade to Gradle 1.10

[ https://issues.apache.org/jira/browse/KAFKA-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stevo Slavic updated KAFKA-1372: Resolution: Duplicate Status: Resolved (was: Patch Available) Resolving as duplicate of KAF

[jira] [Created] (KAFKA-2323) Simplify ScalaTest dependency versions

Ismael Juma created KAFKA-2323: -- Summary: Simplify ScalaTest dependency versions Key: KAFKA-2323 URL: https://issues.apache.org/jira/browse/KAFKA-2323 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-2324) Update to Scala 2.11.7

Ismael Juma created KAFKA-2324: -- Summary: Update to Scala 2.11.7 Key: KAFKA-2324 URL: https://issues.apache.org/jira/browse/KAFKA-2324 Project: Kafka Issue Type: Improvement Reporter

[jira] [Created] (KAFKA-2325) ConsumerCoordinatorResponseTest doesn't compile with Scala 2.9.x

Ismael Juma created KAFKA-2325: -- Summary: ConsumerCoordinatorResponseTest doesn't compile with Scala 2.9.x Key: KAFKA-2325 URL: https://issues.apache.org/jira/browse/KAFKA-2325 Project: Kafka I

[jira] [Commented] (KAFKA-2325) ConsumerCoordinatorResponseTest doesn't compile with Scala 2.9.x

[ https://issues.apache.org/jira/browse/KAFKA-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618490#comment-14618490 ] Ismael Juma commented on KAFKA-2325: Alternatively, we could decide to drop Scala 2.9

Review Request 36306: Patch for KAFKA-2323

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36306/ --- Review request for kafka. Bugs: KAFKA-2323 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-2323) Simplify ScalaTest dependency versions

[ https://issues.apache.org/jira/browse/KAFKA-2323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618550#comment-14618550 ] Ismael Juma commented on KAFKA-2323: Created reviewboard https://reviews.apache.org/r/

[jira] [Updated] (KAFKA-2323) Simplify ScalaTest dependency versions

[ https://issues.apache.org/jira/browse/KAFKA-2323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2323: --- Attachment: KAFKA-2323.patch > Simplify ScalaTest dependency versions > --

[jira] [Updated] (KAFKA-2323) Simplify ScalaTest dependency versions

[ https://issues.apache.org/jira/browse/KAFKA-2323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2323: --- Status: Patch Available (was: Open) > Simplify ScalaTest dependency versions > --

Re: Review Request 36306: Patch for KAFKA-2323

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36306/ --- (Updated July 8, 2015, 1:11 p.m.) Review request for kafka. Bugs: KAFKA-2323

Review Request 36307: Patch for KAFKA-2324

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36307/ --- Review request for kafka. Bugs: KAFKA-2324 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-2324) Update to Scala 2.11.7

[ https://issues.apache.org/jira/browse/KAFKA-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618594#comment-14618594 ] Ismael Juma commented on KAFKA-2324: Created reviewboard https://reviews.apache.org/r/

[jira] [Updated] (KAFKA-2324) Update to Scala 2.11.7

[ https://issues.apache.org/jira/browse/KAFKA-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2324: --- Attachment: KAFKA-2324.patch > Update to Scala 2.11.7 > -- > > Key

Re: Review Request 36307: Patch for KAFKA-2324

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36307/ --- (Updated July 8, 2015, 1:39 p.m.) Review request for kafka. Bugs: KAFKA-2324

[jira] [Updated] (KAFKA-2324) Update to Scala 2.11.7

[ https://issues.apache.org/jira/browse/KAFKA-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2324: --- Status: Patch Available (was: Open) > Update to Scala 2.11.7 > -- > >

Re: Review Request 36307: Patch for KAFKA-2324

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36307/#review90891 --- Ship it! Ship It! - Sriharsha Chintalapani On July 8, 2015, 1:39

[jira] [Commented] (KAFKA-2325) ConsumerCoordinatorResponseTest doesn't compile with Scala 2.9.x

[ https://issues.apache.org/jira/browse/KAFKA-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618609#comment-14618609 ] Sriharsha Chintalapani commented on KAFKA-2325: --- [~ijuma] lets' reopen the t

Re: Dropping support for Scala 2.9.x

Hi, The responses in this thread were positive, but there weren't many. A few months passed and Sriharsha encouraged me to reopen the thread given that the 2.9 build has been broken for at least a week[1] and no-one seemed to notice. Do we want to invest more time so that the 2.9 build continues

Re: Dropping support for Scala 2.9.x

+1 for dropping 2.9 On Wed, Jul 8, 2015 at 9:15 AM, Sriharsha Chintalapani wrote: > I am +1 on dropping 2.9.x support. > > Thanks, > Harsha > > > On July 8, 2015 at 7:08:12 AM, Ismael Juma (mli...@juma.me.uk) wrote: > > Hi, > > The responses in this thread were positive, but there weren't many.

Re: Dropping support for Scala 2.9.x

I am +1 on dropping 2.9.x support. Thanks,  Harsha On July 8, 2015 at 7:08:12 AM, Ismael Juma (mli...@juma.me.uk) wrote: Hi, The responses in this thread were positive, but there weren't many. A few months passed and Sriharsha encouraged me to reopen the thread given that the 2.9 build h

[jira] [Commented] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618803#comment-14618803 ] Sriharsha Chintalapani commented on KAFKA-2298: --- [~lindong] [~jjkoshy] I've

[jira] [Commented] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618867#comment-14618867 ] Ewen Cheslack-Postava commented on KAFKA-2308: -- [~gwenshap] The test case you

[jira] [Commented] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618873#comment-14618873 ] Gwen Shapira commented on KAFKA-2308: - yes, I saw the Snappy test case too :) Since i

[jira] [Commented] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1461#comment-1461 ] Guozhang Wang commented on KAFKA-2308: -- Agree, we do not need a test case inside Kafk

[jira] [Commented] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618901#comment-14618901 ] Gwen Shapira commented on KAFKA-2308: - Was that a "ship it", [~guozhang]? :) > New pr

Re: Dropping support for Scala 2.9.x

+1. Scala 2.9 has been 4 years old and I think it is time to drop it. On Wed, Jul 8, 2015 at 7:22 AM, Grant Henke wrote: > +1 for dropping 2.9 > > On Wed, Jul 8, 2015 at 9:15 AM, Sriharsha Chintalapani > wrote: > > > I am +1 on dropping 2.9.x support. > > > > Thanks, > > Harsha > > > > > > On

[jira] [Commented] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618921#comment-14618921 ] Guozhang Wang commented on KAFKA-2308: -- I was unit testing the patch while writing th

Re: Review Request 36290: Patch for KAFKA-2308

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36290/#review90920 --- Ship it! Ship It! - Guozhang Wang On July 8, 2015, 2:47 a.m., Gw

[jira] [Updated] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2308: - Fix Version/s: 0.8.3 > New producer + Snappy face un-compression errors after broker restart > ---

[jira] [Updated] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2308: - Resolution: Fixed Status: Resolved (was: Patch Available) > New producer + Snappy face un

[jira] [Updated] (KAFKA-2316) Drop java 1.6 support

[ https://issues.apache.org/jira/browse/KAFKA-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2316: Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) >

[jira] [Commented] (KAFKA-2316) Drop java 1.6 support

[ https://issues.apache.org/jira/browse/KAFKA-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618976#comment-14618976 ] Gwen Shapira commented on KAFKA-2316: - +1. Committed and pushed to trunk. > Drop java

[jira] [Commented] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618981#comment-14618981 ] Gwen Shapira commented on KAFKA-2308: - Thanks :) > New producer + Snappy face un-comp

Build failed in Jenkins: Kafka-trunk #534

See Changes: [cshapi] KAFKA-2316: Drop java 1.6 support; patched by Sriharsha Chintalapani reviewed by Ismael Juma and Gwen Shapira -- Started by user gwenshap Building remotely on ubuntu-6 (docker U

Build failed in Jenkins: KafkaPreCommit #142

See Changes: [wangguoz] KAFKA-2308: make MemoryRecords idempotent; reviewed by Guozhang Wang [cshapi] KAFKA-2316: Drop java 1.6 support; patched by Sriharsha Chintalapani reviewed by Ismael Juma and Gwen Shapira ---

[jira] [Commented] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619059#comment-14619059 ] Dong Lin commented on KAFKA-2298: - [~sriharsha] Sorry for the inconvenience. But the patch

[jira] [Commented] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619060#comment-14619060 ] Sriharsha Chintalapani commented on KAFKA-2298: --- [~lindong] ahh never mind t

Re: Dropping support for Scala 2.9.x

+1 On Wed, Jul 8, 2015 at 9:52 AM, Guozhang Wang wrote: > +1. > > Scala 2.9 has been 4 years old and I think it is time to drop it. > > On Wed, Jul 8, 2015 at 7:22 AM, Grant Henke wrote: > > > +1 for dropping 2.9 > > > > On Wed, Jul 8, 2015 at 9:15 AM, Sriharsha Chintalapani > > wrote: > > > >

[jira] [Commented] (KAFKA-2316) Drop java 1.6 support

[ https://issues.apache.org/jira/browse/KAFKA-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619087#comment-14619087 ] Ismael Juma commented on KAFKA-2316: It looks like this broke Jenkins: https://builds

[jira] [Commented] (KAFKA-2316) Drop java 1.6 support

[ https://issues.apache.org/jira/browse/KAFKA-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619092#comment-14619092 ] Ismael Juma commented on KAFKA-2316: I don't have access to the config, which may be m

[jira] [Commented] (KAFKA-2316) Drop java 1.6 support

[ https://issues.apache.org/jira/browse/KAFKA-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619093#comment-14619093 ] Gwen Shapira commented on KAFKA-2316: - ouch, yeah. I guess Jenkins is running with Jav

[jira] [Commented] (KAFKA-2316) Drop java 1.6 support

[ https://issues.apache.org/jira/browse/KAFKA-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619143#comment-14619143 ] Gwen Shapira commented on KAFKA-2316: - Apache Member [~jarcec] volunteered to help out

[jira] [Commented] (KAFKA-2316) Drop java 1.6 support

[ https://issues.apache.org/jira/browse/KAFKA-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619146#comment-14619146 ] Jarek Jarcec Cecho commented on KAFKA-2316: --- I've configured the job to use Java

Build failed in Jenkins: Kafka-trunk #535

See -- [...truncated 444 lines...] org.apache.kafka.common.record.RecordTest > testFields[48] PASSED org.apache.kafka.common.record.RecordTest > testChecksum[48] PASSED org.apache.kafka.common.record.RecordT

Build failed in Jenkins: Kafka-trunk #536

See -- [...truncated 4674 lines...] kafka.coordinator.ConsumerGroupMetadataTest > testPreparingRebalanceToDeadTransition PASSED kafka.coordinator.ConsumerGroupMetadataTest > testRebalancingToStableTransition

[jira] [Commented] (KAFKA-2316) Drop java 1.6 support

[ https://issues.apache.org/jira/browse/KAFKA-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619199#comment-14619199 ] Ismael Juma commented on KAFKA-2316: Thank you [~jarcec], any chance you could also up

[jira] [Commented] (KAFKA-2316) Drop java 1.6 support

[ https://issues.apache.org/jira/browse/KAFKA-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619271#comment-14619271 ] Jarek Jarcec Cecho commented on KAFKA-2316: --- I've just updated the second job as

Review Request 36333: Patch for KAFKA-2123

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36333/ --- Review request for kafka. Bugs: KAFKA-2123 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-2123) Make new consumer offset commit API use callback + future

[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619386#comment-14619386 ] Jason Gustafson commented on KAFKA-2123: Created reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-2123) Make new consumer offset commit API use callback + future

[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2123: --- Attachment: KAFKA-2123.patch > Make new consumer offset commit API use callback + future > ---

[jira] [Commented] (KAFKA-2123) Make new consumer offset commit API use callback + future

[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619432#comment-14619432 ] Jason Gustafson commented on KAFKA-2123: [~ewencp], [~guozhang], apologies for the

Re: Dropping support for Scala 2.9.x

We should consider deprecating the scala API so scala version doesn't even matter anymore for folks... we could even pin the broker to a specific Scala version too Of course this makes sense for the Java produce but maybe not just yet for the consumer, maybe 0.9.0. Not having to build in 0.8.

[jira] [Commented] (KAFKA-1479) Logs filling up while Kafka ReplicaFetcherThread tries to retrieve partition info for deleted topics

I am observing log filling up on kafka_2.10-0.8.2.0. Following are the logs on one of kafka node: On Topic Creation: [2015-07-07 20:28:17,579] INFO [ReplicaFetcherManager on broker 0] Removed fetcher for partitions [tempv1,0] (kafka.server.ReplicaFetcherManager) [2015-07-07 20:28:17,582] INFO Comp

[jira] [Commented] (KAFKA-2319) After controlled shutdown: IllegalStateException: Kafka scheduler has not been started

[ https://issues.apache.org/jira/browse/KAFKA-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619671#comment-14619671 ] Jason Gustafson commented on KAFKA-2319: Seems like there might be a race conditio

Review Request 36341: Patch for KAFKA-2311

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36341/ --- Review request for kafka. Bugs: KAFKA-2311 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2311) Consumer's ensureNotClosed method not thread safe

[ https://issues.apache.org/jira/browse/KAFKA-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2311: -- Attachment: KAFKA-2311.patch > Consumer's ensureNotClosed method not thread safe > -

[jira] [Commented] (KAFKA-2311) Consumer's ensureNotClosed method not thread safe

[ https://issues.apache.org/jira/browse/KAFKA-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619682#comment-14619682 ] Tim Brooks commented on KAFKA-2311: --- Created reviewboard https://reviews.apache.org/r/36

[jira] [Commented] (KAFKA-2311) Consumer's ensureNotClosed method not thread safe

[ https://issues.apache.org/jira/browse/KAFKA-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619684#comment-14619684 ] Tim Brooks commented on KAFKA-2311: --- I removed the unnecessary close check as suggested

Re: Review Request 36341: Patch for KAFKA-2311

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36341/#review91035 --- Ship it! Ship It! - Sriharsha Chintalapani On July 9, 2015, 1:04

Re: Review Request 36333: Patch for KAFKA-2123

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36333/#review91012 --- Browsed through the patch, overall looks very promising. I am not v

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/#review91038 --- Thanks for the new patch. Just a couple of minor comments below. c

Re: Review Request 34554: Patch for KAFKA-2205

> On July 7, 2015, 2:18 a.m., Jun Rao wrote: > > Thanks for the patch. A few more comments below. > > > > 1. The patch doesn't apply. Could you rebase? > > 2. Also, we need the logic to read all existing client configs. Is that in > > a separate jira? > > Aditya Auradkar wrote: > 1. Will d

Re: Review Request 36333: Patch for KAFKA-2123

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36333/#review91016 --- clients/src/main/java/org/apache/kafka/clients/consumer/internals/C

Re: Build failed in Jenkins: KafkaPreCommit #142

Joel, this looks like it's failing for basically the same file set as the last fix. We probably want to just ignore all of build/, not just build/rat/rat-report.xml. I would say rat may end up being too much of a hassle, but it already caught invalid license headers in another case... -Ewen On W

Re: request forwarding in Kafka?

ping~ On Tue, Jul 7, 2015 at 6:27 PM, Qi Xu wrote: > Hi Kafka folks, > I'm investigating about using Kafka as a data ingress endpoint for our > analytic service. > In our scenario, Kafka cluster is behind NLB which has a public IP, and > the data source service is under another public IP. Basi

Build failed in Jenkins: KafkaPreCommit #142

Agreed that we should change it to exclude build/** - however, build 142 failure does not seem to be rat-related is it? E.g., compare the console output with an earlier build (138 I think). Sorry I can't verify/debug right now, but can look tomorrow. On Wednesday, July 8, 2015, Ewen Cheslack-Posta