[jira] [Created] (KAFKA-2299) kafka-patch-review tool does not correctly capture testing done

Ashish K Singh created KAFKA-2299: - Summary: kafka-patch-review tool does not correctly capture testing done Key: KAFKA-2299 URL: https://issues.apache.org/jira/browse/KAFKA-2299 Project: Kafka

Review Request 35822: Patch for KAFKA-2299

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35822/ --- Review request for kafka. Bugs: KAFKA-2299 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2299) kafka-patch-review tool does not correctly capture testing done

[ https://issues.apache.org/jira/browse/KAFKA-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2299: -- Status: Patch Available (was: Open) > kafka-patch-review tool does not correctly capture testin

[jira] [Updated] (KAFKA-2299) kafka-patch-review tool does not correctly capture testing done

[ https://issues.apache.org/jira/browse/KAFKA-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2299: -- Attachment: KAFKA-2299.patch > kafka-patch-review tool does not correctly capture testing done >

[jira] [Commented] (KAFKA-2299) kafka-patch-review tool does not correctly capture testing done

[ https://issues.apache.org/jira/browse/KAFKA-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599028#comment-14599028 ] Ashish K Singh commented on KAFKA-2299: --- Created reviewboard https://reviews.apache.

[jira] [Commented] (KAFKA-2299) kafka-patch-review tool does not correctly capture testing done

[ https://issues.apache.org/jira/browse/KAFKA-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599029#comment-14599029 ] Ashish K Singh commented on KAFKA-2299: --- [~nehanarkhede] do you mind taking a look a

[jira] [Commented] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599317#comment-14599317 ] Jason Rosenberg commented on KAFKA-1901: [~omkreddy] Yes, that sounds find. Prefe

[jira] [Commented] (KAFKA-2203) Get gradle build to work with Java 8

[ https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599556#comment-14599556 ] Jeff Maxwell commented on KAFKA-2203: - The KAFKA-2294 patch allows java 8 builds to co

[jira] [Updated] (KAFKA-972) MetadataRequest returns stale list of brokers

[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-972: -- Attachment: BrokerMetadataTest.scala Sample Failing Tests: - testBrokerMetadataOnClusterWithNoTopics - te

[jira] [Commented] (KAFKA-2203) Get gradle build to work with Java 8

[ https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599666#comment-14599666 ] Ewen Cheslack-Postava commented on KAFKA-2203: -- The drawback is that I don't

[jira] [Commented] (KAFKA-2203) Get gradle build to work with Java 8

[ https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599681#comment-14599681 ] Gwen Shapira commented on KAFKA-2203: - This should be done pre-commit and nearly every

[jira] [Commented] (KAFKA-2199) Make signing artifacts optional, setting maven repository possible from command line

[ https://issues.apache.org/jira/browse/KAFKA-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599700#comment-14599700 ] Manikumar Reddy commented on KAFKA-2199: ./gradlew build is failing with below er

Re: Review Request 33620: Patch for KAFKA-1690

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/#review89063 --- Thanks for the patch, Sriharsha. A few comments below. clients/src

[jira] [Created] (KAFKA-2300) Error in controller log when broker tries to rejoin cluster

Johnny Brown created KAFKA-2300: --- Summary: Error in controller log when broker tries to rejoin cluster Key: KAFKA-2300 URL: https://issues.apache.org/jira/browse/KAFKA-2300 Project: Kafka Issu

Review Request 35832: Patch for KAFKA-2199

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35832/ --- Review request for kafka. Bugs: KAFKA-2199 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2199) Make signing artifacts optional, setting maven repository possible from command line

[ https://issues.apache.org/jira/browse/KAFKA-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2199: - Attachment: KAFKA-2199.patch > Make signing artifacts optional, setting maven repo

[jira] [Commented] (KAFKA-2199) Make signing artifacts optional, setting maven repository possible from command line

[ https://issues.apache.org/jira/browse/KAFKA-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599738#comment-14599738 ] Ewen Cheslack-Postava commented on KAFKA-2199: -- Created reviewboard https://r

[jira] [Commented] (KAFKA-2199) Make signing artifacts optional, setting maven repository possible from command line

[ https://issues.apache.org/jira/browse/KAFKA-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599743#comment-14599743 ] Ewen Cheslack-Postava commented on KAFKA-2199: -- [~omkreddy] Sorry about that,

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- (Updated June 24, 2015, 5:20 p.m.) Review request for kafka. Bugs: KAFKA-2132

[jira] [Updated] (KAFKA-2132) Move Log4J appender to a separate module

[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2132: -- Attachment: KAFKA-2132_2015-06-24_10:19:56.patch > Move Log4J appender to a separate module > --

[jira] [Commented] (KAFKA-2132) Move Log4J appender to a separate module

[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599770#comment-14599770 ] Ashish K Singh commented on KAFKA-2132: --- Updated reviewboard https://reviews.apache.

[jira] [Commented] (KAFKA-2203) Get gradle build to work with Java 8

[ https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599771#comment-14599771 ] Ewen Cheslack-Postava commented on KAFKA-2203: -- [~gwenshap] Agreed that preco

Re: Review Request 33614: Patch for KAFKA-2132

> On June 16, 2015, 1:31 a.m., Jun Rao wrote: > > Thanks for the patch. There seems to be a compilation error. > > > > :log4j-appender:compileTestJava > > /Users/junrao/intellij/kafka/log4j-appender/src/test/java/org/apache/kafka/log4jappender/MockKafkaLog4jAppender.java:27: > > cannot find sym

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- (Updated June 24, 2015, 5:25 p.m.) Review request for kafka. Bugs: KAFKA-2132

[jira] [Commented] (KAFKA-2132) Move Log4J appender to a separate module

[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599778#comment-14599778 ] Ashish K Singh commented on KAFKA-2132: --- Updated reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-2132) Move Log4J appender to a separate module

[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2132: -- Attachment: KAFKA-2132_2015-06-24_10:25:43.patch > Move Log4J appender to a separate module > --

[jira] [Commented] (KAFKA-2203) Get gradle build to work with Java 8

[ https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599797#comment-14599797 ] Jeff Maxwell commented on KAFKA-2203: - FWIW Spring's solution appears to be dedicated

Re: [DISCUSS] KIP-26 - Add Copycat, a connector framework for data import/export

Hey Sriram, Good question here was the thinking: 1. I think the argument we are making is that a stream processing framework is the right way to do complex transformations. We can bake in some mechanism for simple, single-row transforms in copycat, but for anything more complex copycat is really

[jira] [Commented] (KAFKA-2203) Get gradle build to work with Java 8

[ https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599823#comment-14599823 ] Gwen Shapira commented on KAFKA-2203: - Having pre-commit comments on a JIRA will be si

Re: Review Request 35791: Patch for KAFKA-2298

> On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 282 > > > > > > Do you think we should just move the disconnected.add() into the

Re: [GitHub] kafka pull request: Kafka 2276

Github either lets you do inline comments on the diff ("Files Changed" tab) or on the entire commit ("Conversation"). One of the things review board does right that's a bit frustrating in Github his that you can't group a bunch of comments into a single review and post it all at once (and get only

Re: [GitHub] kafka pull request: Kafka 2276

> There are loads of other improvements that could me > made too -- for example, I'd love seeing Docker support, which would make > running tests way cheaper/simpler. Haha, that was my first thought when I saw Vagrant in there - why not Docker? :) I didn't realize we already had Vagrant integratio

[jira] [Created] (KAFKA-2301) Deprecate ConsumerOffsetChecker

Ashish K Singh created KAFKA-2301: - Summary: Deprecate ConsumerOffsetChecker Key: KAFKA-2301 URL: https://issues.apache.org/jira/browse/KAFKA-2301 Project: Kafka Issue Type: Sub-task

Re: Review Request 28096: Patch for KAFKA-313

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28096/ --- (Updated June 24, 2015, 6:14 p.m.) Review request for kafka, Gwen Shapira, Jare

[jira] [Commented] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerGroupCommand

[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599872#comment-14599872 ] Ashish K Singh commented on KAFKA-313: -- Updated reviewboard https://reviews.apache.org

[jira] [Updated] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerGroupCommand

[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-313: - Attachment: KAFKA-313_2015-06-24_11:14:24.patch > Add JSON/CSV output and looping options to Consum

Re: Review Request 35791: Patch for KAFKA-2298

> On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 282 > > > > > > Do you think we should just move the disconnected.add() into the

[jira] [Commented] (KAFKA-2300) Error in controller log when broker tries to rejoin cluster

[ https://issues.apache.org/jira/browse/KAFKA-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599926#comment-14599926 ] Kurt Harriger commented on KAFKA-2300: -- Looking at the code it appears once the contr

Re: Review Request 35791: Patch for KAFKA-2298

> On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 282 > > > > > > Do you think we should just move the disconnected.add() into the

Re: [GitHub] kafka pull request: Kafka 2276

Hi Gwen, A couple other thoughts: services/templates These are jinja2 templates which can be populated with values as desired. Although currently many individual configs in various templates have preset values, we can easily make these more parametrizable (presumably with default values). There

Re: Review Request 35791: Patch for KAFKA-2298

> On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 282 > > > > > > Do you think we should just move the disconnected.add() into the

[jira] [Updated] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2298: Attachment: KAFKA-2298_2015-06-24_13:00:39.patch > Client Selector can drop connections on InvalidReceiveExc

Re: Review Request 35791: Patch for KAFKA-2298

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/ --- (Updated June 24, 2015, 8 p.m.) Review request for kafka. Bugs: KAFKA-2298

[jira] [Commented] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600047#comment-14600047 ] Dong Lin commented on KAFKA-2298: - Updated reviewboard https://reviews.apache.org/r/35791/

Re: Review Request 35791: Patch for KAFKA-2298

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/#review89241 --- Ship it! Ship It! - Jason Gustafson On June 24, 2015, 8 p.m., Do

[jira] [Commented] (KAFKA-2203) Get gradle build to work with Java 8

[ https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600093#comment-14600093 ] Jakob Homan commented on KAFKA-2203: A couple data points: * Samza has a script that r

[jira] [Commented] (KAFKA-2301) Deprecate ConsumerOffsetChecker

[ https://issues.apache.org/jira/browse/KAFKA-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600256#comment-14600256 ] Ashish K Singh commented on KAFKA-2301: --- Created reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-2301) Deprecate ConsumerOffsetChecker

[ https://issues.apache.org/jira/browse/KAFKA-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2301: -- Attachment: KAFKA-2301.patch > Deprecate ConsumerOffsetChecker > ---

Review Request 35850: Patch for KAFKA-2301

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/ --- Review request for kafka. Bugs: KAFKA-2301 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2301) Deprecate ConsumerOffsetChecker

[ https://issues.apache.org/jira/browse/KAFKA-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2301: -- Status: Patch Available (was: Open) > Deprecate ConsumerOffsetChecker > ---

[jira] [Commented] (KAFKA-282) Currently iterated chunk is not cleared during consumer shutdown

[ https://issues.apache.org/jira/browse/KAFKA-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600318#comment-14600318 ] Matthieu Sprunck commented on KAFKA-282: I still have this issue with the API versi

Re: Review Request 35850: Patch for KAFKA-2301

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/#review89301 --- Is this what was intended by "deprecate"? I'm not sure there's been

[jira] [Assigned] (KAFKA-972) MetadataRequest returns stale list of brokers

[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh reassigned KAFKA-972: Assignee: Ashish K Singh > MetadataRequest returns stale list of brokers > -

[jira] [Comment Edited] (KAFKA-972) MetadataRequest returns stale list of brokers

[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600602#comment-14600602 ] Ashish K Singh edited comment on KAFKA-972 at 6/25/15 3:10 AM: --

[jira] [Comment Edited] (KAFKA-972) MetadataRequest returns stale list of brokers

[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600602#comment-14600602 ] Ashish K Singh edited comment on KAFKA-972 at 6/25/15 3:10 AM: --

[jira] [Commented] (KAFKA-972) MetadataRequest returns stale list of brokers

[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600602#comment-14600602 ] Ashish K Singh commented on KAFKA-972: -- Hey Guys, I spent some time reproducing the i