Re: Metrics package discussion

2015-03-29 Thread Jun Rao
There is another thing to consider. We plan to reuse the client components on the server side over time. For example, as part of the security work, we are looking into replacing the server side network code with the client network code (KAFKA-1928). However, the client network already has metrics b

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

2015-03-29 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385848#comment-14385848 ] Jun Rao commented on KAFKA-1634: Perhaps, we can do KAFKA-1841 together with KAFKA-2068. T

[jira] [Commented] (KAFKA-2068) Replace OffsetCommit Request/Response with org.apache.kafka.common.requests equivalent

2015-03-29 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385850#comment-14385850 ] Jun Rao commented on KAFKA-2068: We may want to consider if it's better to do KAFKA-1841 t

Re: Review Request 28769: Patch for KAFKA-1809

2015-03-29 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28769/#review78160 --- Thanks for the latest patch. A few more comments below. clients/sr

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

2015-03-29 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385906#comment-14385906 ] Jun Rao commented on KAFKA-1809: Thanks for the latest patch. Reviewed. Could you also pro

[jira] [Commented] (KAFKA-2046) Delete topic still doesn't work

2015-03-29 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385996#comment-14385996 ] Neha Narkhede commented on KAFKA-2046: -- [~onurkaraman] Shouldn't controller.message.q

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-29 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385999#comment-14385999 ] Neha Narkhede commented on KAFKA-527: - [~guozhang] +1. Will be great to re-run the test

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-03-29 Thread Parth Brahmbhatt
Hi Gwen, Thanks a lot for taking the time to review this. I have tried to address all your questions below. Thanks Parth On 3/28/15, 8:08 PM, "Gwen Shapira" mailto:gshap...@cloudera.com>> wrote: Preparing for Tuesday meeting, I went over the KIP :) First, Parth did an amazing job, the KIP is

[jira] [Commented] (KAFKA-2029) Improving controlled shutdown for rolling updates

2015-03-29 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386002#comment-14386002 ] Jiangjie Qin commented on KAFKA-2029: - [~dmitrybugaychenko] I was trying to apply the

Re: Review Request 31967: Patch for KAFKA-1546

2015-03-29 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review78166 --- Ship it! Ship It! - Neha Narkhede On March 27, 2015, 6:58 p.m.,

[jira] [Commented] (KAFKA-2046) Delete topic still doesn't work

2015-03-29 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386014#comment-14386014 ] Onur Karaman commented on KAFKA-2046: - Correct. Basically Clark and I had two separate

[jira] [Commented] (KAFKA-2046) Delete topic still doesn't work

2015-03-29 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386015#comment-14386015 ] Sriharsha Chintalapani commented on KAFKA-2046: --- [~nehanarkhede] [~onurkaram

[jira] [Updated] (KAFKA-1848) Checking shutdown during each iteration of ZookeeperConsumerConnector

2015-03-29 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1848: Fix Version/s: (was: 0.9.0) 0.8.3 > Checking shutdown during each iteration o

[jira] [Commented] (KAFKA-2046) Delete topic still doesn't work

2015-03-29 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386021#comment-14386021 ] Neha Narkhede commented on KAFKA-2046: -- [~onurkaraman] Could [~clarkhaskins] reproduc

[jira] [Commented] (KAFKA-1716) hang during shutdown of ZookeeperConsumerConnector

2015-03-29 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386019#comment-14386019 ] Jiangjie Qin commented on KAFKA-1716: - [~dchu] Do you mean that the fetchers have neve

[jira] [Issue Comment Deleted] (KAFKA-1716) hang during shutdown of ZookeeperConsumerConnector

2015-03-29 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1716: Comment: was deleted (was: [~dchu] Do you mean that the fetchers have never been created? That's a

[jira] [Commented] (KAFKA-1716) hang during shutdown of ZookeeperConsumerConnector

2015-03-29 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386022#comment-14386022 ] Jiangjie Qin commented on KAFKA-1716: - [~dchu] Do you mean that the fetchers have neve

[jira] [Commented] (KAFKA-1983) TestEndToEndLatency can be unreliable after hard kill

2015-03-29 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386028#comment-14386028 ] Neha Narkhede commented on KAFKA-1983: -- cc [~junrao] > TestEndToEndLatency can be un

[jira] [Updated] (KAFKA-2034) sourceCompatibility not set in Kafka build.gradle

2015-03-29 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2034: - Labels: newbie (was: ) > sourceCompatibility not set in Kafka build.gradle >

[jira] [Updated] (KAFKA-2034) sourceCompatibility not set in Kafka build.gradle

2015-03-29 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2034: - Component/s: build > sourceCompatibility not set in Kafka build.gradle > -

[jira] [Commented] (KAFKA-1215) Rack-Aware replica assignment option

2015-03-29 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386037#comment-14386037 ] Neha Narkhede commented on KAFKA-1215: -- [~allenxwang] This was inactive for a while,

[jira] [Commented] (KAFKA-1293) Mirror maker housecleaning

2015-03-29 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386039#comment-14386039 ] Neha Narkhede commented on KAFKA-1293: -- cc [~junrao] > Mirror maker housecleaning >

[jira] [Comment Edited] (KAFKA-1293) Mirror maker housecleaning

2015-03-29 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386039#comment-14386039 ] Neha Narkhede edited comment on KAFKA-1293 at 3/30/15 12:15 AM:

[jira] [Commented] (KAFKA-1983) TestEndToEndLatency can be unreliable after hard kill

2015-03-29 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386040#comment-14386040 ] Sriharsha Chintalapani commented on KAFKA-1983: --- [~gchao] Here are the steps

[jira] [Commented] (KAFKA-1548) Refactor the "replica_id" in requests

2015-03-29 Thread Santosh Pingale (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386050#comment-14386050 ] Santosh Pingale commented on KAFKA-1548: [~gwenshap]/[~guozhang] Can I pick this

Re: Review Request 32519: Patch for KAFKA-2050

2015-03-29 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32519/#review78167 --- Ship it! Ship It! - Neha Narkhede On March 26, 2015, 2:36 a.m.,

[jira] [Updated] (KAFKA-1994) Evaluate performance effect of chroot check on Topic creation

2015-03-29 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1994: - Reviewer: Jun Rao > Evaluate performance effect of chroot check on Topic creation > --

[jira] [Commented] (KAFKA-2046) Delete topic still doesn't work

2015-03-29 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386228#comment-14386228 ] Onur Karaman commented on KAFKA-2046: - Yeah the issue still happens on [~clarkhaskins]