Re: [DISCUSS] KIPs

2015-02-06 Thread Guozhang Wang
Here are my cents: We could use "lazy" as the default policy for KIP, i.e. : 1. Once a KIP is created at least one committer should engage and provide feedbacks within a few days; 2. If the committer(s) think it may be a bigger issue / change and requires broader discussion, she(they) may call ou

[jira] [Commented] (KAFKA-1904) run sanity failed test

2015-02-06 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308964#comment-14308964 ] Andrii Biletskyi commented on KAFKA-1904: - [~joestein] - I was able to run tests b

Fwd: [jira] [Created] (AURORA-985) Move Aurora website source to subdirectory of git repo

2015-02-06 Thread Joe Stein
this looks like it might help us too with getting the release documentation content/changes along with code & test contributions in patches without the extra step with the site in the commits with svn -- Forwarded message -- From: Dave Lester (JIRA) Date: Tue, Dec 23, 2014 at 5:30

Re: [jira] [Created] (AURORA-985) Move Aurora website source to subdirectory of git repo

2015-02-06 Thread Gwen Shapira
strong +1 In addition to keeping the docs updated in sync with the patches, and helping us avoid two source control systems, this will also allow automated integration with https://readthedocs.org/, to make the docs immediately available online, versioned and searchable. Gwen On Fri, Feb 6, 2015

[jira] [Commented] (KAFKA-1476) Get a list of consumer groups

2015-02-06 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309529#comment-14309529 ] Neha Narkhede commented on KAFKA-1476: -- [~onurkaraman] To answer your questions below

Re: [jira] [Created] (AURORA-985) Move Aurora website source to subdirectory of git repo

2015-02-06 Thread Neha Narkhede
+1 from me too. I've seen the best way to keep docs in sync with the code is to have contributors submit changes to both as part of the same patch. Otherwise we keep playing catchup with the changing codebase. On Fri, Feb 6, 2015 at 9:07 AM, Gwen Shapira wrote: > strong +1 > > In addition to kee

Re: [DISCUSS] ConfigDec Broker Changes on Trunk

2015-02-06 Thread Jeff Holoman
I think this is a good change. Is there general agreement that we are moving forward with this approach? It would be nice to start using this for future work. Thanks Jeff On Tue, Feb 3, 2015 at 9:34 AM, Joe Stein wrote: > I updated the RB changing some of the HIGH to MEDIUM and LOW. > > There

[jira] [Resolved] (KAFKA-1730) add the doc for the new java producer in 0.8.2

2015-02-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1730. Resolution: Fixed Assignee: Manikumar Reddy Thanks for the metrics doc patch. +1 and committed to site

Re: Review Request 27391: Fix KAFKA-1634

2015-02-06 Thread Guozhang Wang
> On Feb. 4, 2015, 2:15 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/api/OffsetCommitRequest.scala, line 48 > > > > > > I our convention is to include the if in the previous line. I checked the code base and

Re: Review Request 27391: Fix KAFKA-1634

2015-02-06 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27391/ --- (Updated Feb. 6, 2015, 7:01 p.m.) Review request for kafka. Bugs: KAFKA-1634

[jira] [Updated] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

2015-02-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1634: - Attachment: KAFKA-1634_2015-02-06_11:01:08.patch > Improve semantics of timestamp in OffsetCommitR

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

2015-02-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309645#comment-14309645 ] Guozhang Wang commented on KAFKA-1634: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1884) New Producer blocks forever for Invalid topic names

2015-02-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309671#comment-14309671 ] Guozhang Wang commented on KAFKA-1884: -- I think the behavior that producer's sender t

Re: [DISCUSS] ConfigDec Broker Changes on Trunk

2015-02-06 Thread Joe Stein
I created KIP-12 https://cwiki.apache.org/confluence/display/KAFKA/KIP-12+change+broker+configuration+properties+to+be+consistent+with+the+rest+of+the+code and linked it to this thread and the JIRA with the v1 patch. The rebased version with updates for the current review should be ready to review

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations

2015-02-06 Thread Joe Stein
I updated the installation and sample usage for the existing patches on the KIP site https://cwiki.apache.org/confluence/display/KAFKA/KIP-4+-+Command+line+and+centralized+administrative+operations There are still a few pending items here. 1) There was already some discussion about using the Brok

Re: Review Request 30063: Patch for KAFKA-1840

2015-02-06 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/#review71482 --- Ship it! Ship It! - Guozhang Wang On Feb. 1, 2015, 8:17 a.m., Ji

Re: [DISCUSS] KIPs

2015-02-06 Thread Joe Stein
Guozhang's idea is interesting. It does promote collaboration. Not all KIPs are created equally and anyone (including the person reviewing it) would be able to call out and request a stronger vote for it to go in. I think that having 3 x +1 is good (sometimes) because it reduces the risk of thing

Re: [DISCUSS] KIPs

2015-02-06 Thread Jay Kreps
I think we are focused on making committing new changes easier, but what we have seen is actually that isn't the bulk of the work (especially with this kind of "public interface" change where it generally has a big user impact). I think we actually really need the core committers and any other inte

Review Request 30743: Patch for KAFKA-1839

2015-02-06 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30743/ --- Review request for kafka. Bugs: KAFKA-1839 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1729) add doc for Kafka-based offset management in 0.8.2

2015-02-06 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309817#comment-14309817 ] Joel Koshy commented on KAFKA-1729: --- I will be making a few more edits after some feedba

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-02-06 Thread Francois Saint-Jacques (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309966#comment-14309966 ] Francois Saint-Jacques commented on KAFKA-1367: --- Instead of silently removin

[jira] [Commented] (KAFKA-1919) Metadata request issued with no backoff in new producer if there are no topics

2015-02-06 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310112#comment-14310112 ] Steven Zhen Wu commented on KAFKA-1919: --- [~jkreps] I tried your patch, it seems to f

[jira] [Commented] (KAFKA-1333) Add consumer co-ordinator module to the server

2015-02-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310119#comment-14310119 ] Guozhang Wang commented on KAFKA-1333: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1333) Add consumer co-ordinator module to the server

2015-02-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1333: - Attachment: KAFKA-1333_2015-02-06_15:02:48.patch > Add consumer co-ordinator module to the server

[jira] [Commented] (KAFKA-1884) New Producer blocks forever for Invalid topic names

2015-02-06 Thread Pradeep Gollakota (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310241#comment-14310241 ] Pradeep Gollakota commented on KAFKA-1884: -- [~guozhang] That's what I figured at

[jira] [Commented] (KAFKA-1884) New Producer blocks forever for Invalid topic names

2015-02-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310283#comment-14310283 ] Guozhang Wang commented on KAFKA-1884: -- That is a bit weird, the metadata requests sh

[jira] [Commented] (KAFKA-1884) New Producer blocks forever for Invalid topic names

2015-02-06 Thread Pradeep Gollakota (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310548#comment-14310548 ] Pradeep Gollakota commented on KAFKA-1884: -- I guess that makes sense... I'll conf

[jira] [Commented] (KAFKA-1865) Investigate adding a flush() call to new producer API

2015-02-06 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310590#comment-14310590 ] Jay Kreps commented on KAFKA-1865: -- A key aspect of this that isn't obvious is that flush