[jira] [Commented] (KAFKA-345) Add a listener to ZookeeperConsumerConnector to get notified on rebalance events

2014-11-15 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213469#comment-14213469 ] Jiangjie Qin commented on KAFKA-345: Updated reviewboard https://reviews.apache.org/r/2

Re: Review Request 28025: Patch for KAFKA-345

2014-11-15 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28025/ --- (Updated Nov. 15, 2014, 9:01 a.m.) Review request for kafka. Bugs: KAFKA-345

[jira] [Updated] (KAFKA-345) Add a listener to ZookeeperConsumerConnector to get notified on rebalance events

2014-11-15 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-345: --- Attachment: KAFKA-345_2014-11-15_01:00:55.patch > Add a listener to ZookeeperConsumerConnector to get n

Re: Review Request 28025: Patch for KAFKA-345

2014-11-15 Thread Jiangjie Qin
> On Nov. 14, 2014, 11:36 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/javaapi/consumer/ConsumerRebalanceListener.java, > > line 24 > > > > > > Can we instead just have an interface for this? We don't need to

Re: Review Request 28025: Patch for KAFKA-345

2014-11-15 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28025/ --- (Updated Nov. 15, 2014, 9:20 a.m.) Review request for kafka. Bugs: KAFKA-345

[jira] [Commented] (KAFKA-345) Add a listener to ZookeeperConsumerConnector to get notified on rebalance events

2014-11-15 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213474#comment-14213474 ] Jiangjie Qin commented on KAFKA-345: Updated reviewboard https://reviews.apache.org/r/2

[jira] [Updated] (KAFKA-345) Add a listener to ZookeeperConsumerConnector to get notified on rebalance events

2014-11-15 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-345: --- Attachment: KAFKA-345_2014-11-15_01:19:56.patch > Add a listener to ZookeeperConsumerConnector to get n

[jira] [Commented] (KAFKA-1751) handle "broker not exists" and "topic not exists" scenarios

2014-11-15 Thread Dmitry Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213517#comment-14213517 ] Dmitry Pekar commented on KAFKA-1751: - The implementation of KAFKA-1751 adds validatio

[jira] [Updated] (KAFKA-1515) Wake-up Sender upon blocked on fetching leader metadata

2014-11-15 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1515: - Fix Version/s: (was: 0.9.0) 0.8.2 P > Wake-up Sender upon blocked on fetching lead

[jira] [Issue Comment Deleted] (KAFKA-1515) Wake-up Sender upon blocked on fetching leader metadata

2014-11-15 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1515: - Comment: was deleted (was: P) > Wake-up Sender upon blocked on fetching leader metadata > ---

Re: Review Request 27990: Patch for KAFKA-1751

2014-11-15 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27990/#review61644 --- Looks great! Few comments and nitpicks below. core/src/main/scala

[jira] [Updated] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerOffsetChecker

2014-11-15 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh updated KAFKA-313: - Summary: Add JSON/CSV output and looping options to ConsumerOffsetChecker (was: Add JSON o

Review Request 28096: KAFKA-313: Add JSON/CSV output and looping options to ConsumerOffsetChecker

2014-11-15 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28096/ --- Review request for kafka, Gwen Shapira, Jarek Cecho, and Joel Koshy. Bugs: KAFK

[jira] [Updated] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerOffsetChecker

2014-11-15 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh updated KAFKA-313: - Attachment: KAFKA-313.patch Adds --loop N and --output.format options. Supports csv and jso

[jira] [Commented] (KAFKA-1664) Kafka does not properly parse multiple ZK nodes with non-root chroot

2014-11-15 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213707#comment-14213707 ] Ashish Kumar Singh commented on KAFKA-1664: --- [~gwenshap] I am thinking of taking

[jira] [Created] (KAFKA-1773) Add a tool to check available consumer groups

2014-11-15 Thread Ashish Kumar Singh (JIRA)
Ashish Kumar Singh created KAFKA-1773: - Summary: Add a tool to check available consumer groups Key: KAFKA-1773 URL: https://issues.apache.org/jira/browse/KAFKA-1773 Project: Kafka Issue T

[jira] [Assigned] (KAFKA-1773) Add a tool to check available consumer groups

2014-11-15 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh reassigned KAFKA-1773: - Assignee: Ashish Kumar Singh > Add a tool to check available consumer groups > --

[jira] [Commented] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerOffsetChecker

2014-11-15 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213746#comment-14213746 ] Ashish Kumar Singh commented on KAFKA-313: -- [~jjkoshy] while working on this I rea

Review Request 28100: KAFKA-1773: Add a tool to check available consumer groups

2014-11-15 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28100/ --- Review request for kafka, Gwen Shapira, Jarek Cecho, and Joel Koshy. Bugs: KAFK

[jira] [Comment Edited] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerOffsetChecker

2014-11-15 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213706#comment-14213706 ] Ashish Kumar Singh edited comment on KAFKA-313 at 11/15/14 9:00 PM: -

[jira] [Updated] (KAFKA-1773) Add a tool to check available consumer groups

2014-11-15 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh updated KAFKA-1773: -- Status: Patch Available (was: Open) > Add a tool to check available consumer groups > -

[jira] [Commented] (KAFKA-1773) Add a tool to check available consumer groups

2014-11-15 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213760#comment-14213760 ] Ashish Kumar Singh commented on KAFKA-1773: --- RB: https://reviews.apache.org/r/28

[jira] [Updated] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerOffsetChecker

2014-11-15 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh updated KAFKA-313: - Status: Patch Available (was: Open) > Add JSON/CSV output and looping options to ConsumerO

Re: Review Request 28100: Patch for KAFKA-1773

2014-11-15 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28100/ --- (Updated Nov. 16, 2014, 1:48 a.m.) Review request for kafka, Gwen Shapira, Jare

[jira] [Updated] (KAFKA-1773) Add a tool to check available consumer groups

2014-11-15 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh updated KAFKA-1773: -- Attachment: KAFKA-1773.patch > Add a tool to check available consumer groups > -

[jira] [Created] (KAFKA-1774) REPL and Shell Client for Admin Message RQ/RP

2014-11-15 Thread Joe Stein (JIRA)
Joe Stein created KAFKA-1774: Summary: REPL and Shell Client for Admin Message RQ/RP Key: KAFKA-1774 URL: https://issues.apache.org/jira/browse/KAFKA-1774 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-1775) Re-factor TopicCommand into thew handerAdminMessage call

2014-11-15 Thread Joe Stein (JIRA)
Joe Stein created KAFKA-1775: Summary: Re-factor TopicCommand into thew handerAdminMessage call Key: KAFKA-1775 URL: https://issues.apache.org/jira/browse/KAFKA-1775 Project: Kafka Issue Type: S

[jira] [Updated] (KAFKA-1775) Re-factor TopicCommand into thew handerAdminMessage call

2014-11-15 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1775: - Description: kafka-topic.sh should become kafka --topic --everything else the same from the CLI perspecti

[jira] [Created] (KAFKA-1776) re-factor out existing tools that have been implemented behind the CLI

2014-11-15 Thread Joe Stein (JIRA)
Joe Stein created KAFKA-1776: Summary: re-factor out existing tools that have been implemented behind the CLI Key: KAFKA-1776 URL: https://issues.apache.org/jira/browse/KAFKA-1776 Project: Kafka

[jira] [Updated] (KAFKA-1775) Re-factor TopicCommand into thew handerAdminMessage call

2014-11-15 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1775: - Description: kafka-topic.sh should become kafka --topic --everything else the same from the CLI perspecti

[jira] [Updated] (KAFKA-1775) Re-factor TopicCommand into thew handerAdminMessage call

2014-11-15 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1775: - Description: kafka-topic.sh should become kafka --topic --everything else the same from the CLI perspecti

[jira] [Created] (KAFKA-1777) Re-factor reasign-partitions into CLI

2014-11-15 Thread Joe Stein (JIRA)
Joe Stein created KAFKA-1777: Summary: Re-factor reasign-partitions into CLI Key: KAFKA-1777 URL: https://issues.apache.org/jira/browse/KAFKA-1777 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-1778) Create new re-elect controller admin function

2014-11-15 Thread Joe Stein (JIRA)
Joe Stein created KAFKA-1778: Summary: Create new re-elect controller admin function Key: KAFKA-1778 URL: https://issues.apache.org/jira/browse/KAFKA-1778 Project: Kafka Issue Type: Sub-task

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-15 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/ --- (Updated Nov. 16, 2014, 6:42 a.m.) Review request for kafka. Bugs: KAFKA-1743

[jira] [Updated] (KAFKA-1743) ConsumerConnector.commitOffsets in 0.8.2 is not backward compatible

2014-11-15 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1743: --- Attachment: KAFKA-1743_2014-11-16_12:11:51.patch > ConsumerConnector.commitOffsets in 0.8.2 is

[jira] [Commented] (KAFKA-1743) ConsumerConnector.commitOffsets in 0.8.2 is not backward compatible

2014-11-15 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213869#comment-14213869 ] Manikumar Reddy commented on KAFKA-1743: Updated reviewboard https://reviews.apach

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-15 Thread Manikumar Reddy O
> On Nov. 14, 2014, 7:29 p.m., Jun Rao wrote: > > Thanks for the patch. For clarity, in ZookeeperConsumerConnector, instead > > of having the following, > > def commitOffsets(isAutoCommit: Boolean = true) > > > > could we break it into two separate methods, same as what's defined in > > Con

[jira] [Updated] (KAFKA-1776) Re-factor out existing tools that have been implemented behind the CLI

2014-11-15 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1776: - Summary: Re-factor out existing tools that have been implemented behind the CLI (was: re-factor out exist