Re: Review Request 24704: Patch for KAFKA-1499

2014-09-24 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/ --- (Updated Sept. 24, 2014, 8:52 a.m.) Review request for kafka. Bugs: KAFKA-149

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-09-24 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146084#comment-14146084 ] Manikumar Reddy commented on KAFKA-1499: Updated reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-1499) Broker-side compression configuration

2014-09-24 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1499: --- Attachment: KAFKA-1499_2014-09-24_14:20:33.patch > Broker-side compression configuration > ---

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-09-24 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146091#comment-14146091 ] Manikumar Reddy commented on KAFKA-1499: Updated reviewboard https://reviews.apach

Re: Review Request 24704: Patch for KAFKA-1499

2014-09-24 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/ --- (Updated Sept. 24, 2014, 8:57 a.m.) Review request for kafka. Bugs: KAFKA-149

[jira] [Updated] (KAFKA-1499) Broker-side compression configuration

2014-09-24 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1499: --- Attachment: KAFKA-1499_2014-09-24_14:24:54.patch > Broker-side compression configuration > ---

Re: Review Request 24704: Patch for KAFKA-1499

2014-09-24 Thread Manikumar Reddy O
> On Sept. 23, 2014, 8:51 p.m., Joel Koshy wrote: > > core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala, line 69 > > > > > > Can you fix all the whitespace inconsistencies in this patch? We > > generally u

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-24 Thread saurabh agarwal (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146173#comment-14146173 ] saurabh agarwal commented on KAFKA-1555: min.isr feature is critical for us. In ou

[jira] [Commented] (KAFKA-1490) remove gradlew initial setup output from source distribution

2014-09-24 Thread Szczepan Faber (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146197#comment-14146197 ] Szczepan Faber commented on KAFKA-1490: --- Hey guys, This is Szczepan from the gradle

[jira] [Commented] (KAFKA-1490) remove gradlew initial setup output from source distribution

2014-09-24 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146289#comment-14146289 ] Joe Stein commented on KAFKA-1490: -- Thanks [~szczepiq] for jumping in I think the current

[jira] [Comment Edited] (KAFKA-1490) remove gradlew initial setup output from source distribution

2014-09-24 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146289#comment-14146289 ] Joe Stein edited comment on KAFKA-1490 at 9/24/14 1:31 PM: --- Than

[jira] [Updated] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-24 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Creasy updated KAFKA-404: -- Attachment: (was: KAFKA-404-auto-create-zookeeper-chroot-on-start-up-v4.patch) > When using

[jira] [Commented] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-24 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146337#comment-14146337 ] Jonathan Creasy commented on KAFKA-404: --- Removed v4, found a problem, will re-add it

How producer gets the acknowledgement back

2014-09-24 Thread Sreenivasulu Nallapati
Hello, Can you please help me to get the acknowledgement in producer? After setting the property *request.required.acks to 1, *how producer gets the acknowledgement back? I am trying to get the acknowledgement in java producer. Thanks Sreeni

Review Request 25992: Patch for KAFKA-1645

2014-09-24 Thread Joe Stein
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25992/ --- Review request for kafka. Bugs: KAFKA-1645 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1645) some more jars in our src release

2014-09-24 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146344#comment-14146344 ] Joe Stein commented on KAFKA-1645: -- Created reviewboard https://reviews.apache.org/r/2599

[jira] [Updated] (KAFKA-1645) some more jars in our src release

2014-09-24 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1645: - Assignee: Joe Stein Status: Patch Available (was: Open) > some more jars in our src release > -

[jira] [Updated] (KAFKA-1645) some more jars in our src release

2014-09-24 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1645: - Attachment: KAFKA-1645.patch > some more jars in our src release > - > >

[jira] [Commented] (KAFKA-1490) remove gradlew initial setup output from source distribution

2014-09-24 Thread Szczepan Faber (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146346#comment-14146346 ] Szczepan Faber commented on KAFKA-1490: --- Hey, Thanks for info! What's the purpose o

[jira] [Commented] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-24 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146356#comment-14146356 ] Jonathan Creasy commented on KAFKA-404: --- New v4, works, all tests pass also > When u

[jira] [Updated] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-24 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Creasy updated KAFKA-404: -- Attachment: KAFKA-404-auto-create-zookeeper-chroot-on-start-up-v4.patch > When using chroot path,

[jira] [Commented] (KAFKA-1490) remove gradlew initial setup output from source distribution

2014-09-24 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146365#comment-14146365 ] Joe Stein commented on KAFKA-1490: -- A source release is meant for general public consumpt

[jira] [Comment Edited] (KAFKA-1490) remove gradlew initial setup output from source distribution

2014-09-24 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146365#comment-14146365 ] Joe Stein edited comment on KAFKA-1490 at 9/24/14 2:33 PM: --- A so

[jira] [Commented] (KAFKA-1490) remove gradlew initial setup output from source distribution

2014-09-24 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146377#comment-14146377 ] Jake Farrell commented on KAFKA-1490: - I do not see what the issue is with having a bo

Re: Review Request 22131: Patch for KAFKA-1477

2014-09-24 Thread Rajasekar Elango
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review54412 --- core/src/main/scala/kafka/utils/ZkUtils.scala

[jira] [Commented] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication

2014-09-24 Thread Rajasekar Elango (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146395#comment-14146395 ] Rajasekar Elango commented on KAFKA-1477: - [~gwenshap] config/server.security.prop

[jira] [Commented] (KAFKA-1649) Protocol documentation does not indicate that ReplicaNotAvailable can be ignored

2014-09-24 Thread Hernan Rivas Inaka (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146407#comment-14146407 ] Hernan Rivas Inaka commented on KAFKA-1649: --- Thanks, my confluence username is:

[jira] [Commented] (KAFKA-1490) remove gradlew initial setup output from source distribution

2014-09-24 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146437#comment-14146437 ] Manikumar Reddy commented on KAFKA-1490: 1. I am getting following exception afte

[jira] [Commented] (KAFKA-1490) remove gradlew initial setup output from source distribution

2014-09-24 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146448#comment-14146448 ] Joe Stein commented on KAFKA-1490: -- In your first step you needed to have gradle installe

[jira] [Updated] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

2014-09-24 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1650: Attachment: KAFKA-1650.patch > Mirror Maker could lose data on unclean shutdown. > -

Review Request 25995: Patch for KAFKA-1650

2014-09-24 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/ --- Review request for kafka. Bugs: KAFKA-1650 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

2014-09-24 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1650: Status: Patch Available (was: Open) > Mirror Maker could lose data on unclean shutdown. > -

[jira] [Commented] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

2014-09-24 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146484#comment-14146484 ] Jiangjie Qin commented on KAFKA-1650: - Created reviewboard https://reviews.apache.org/

Re: Review Request 24704: Patch for KAFKA-1499

2014-09-24 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54421 --- core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala

Re: Review Request 24704: Patch for KAFKA-1499

2014-09-24 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54423 --- Ship it! Ship It! - Joel Koshy On Sept. 24, 2014, 8:57 a.m., Man

Re: Review Request 25944: Patch for KAFKA-1013

2014-09-24 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review54329 --- core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala

Re: Review Request 25944: Patch for KAFKA-1013

2014-09-24 Thread Mayuresh Gharat
> On Sept. 24, 2014, 5:13 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/OffsetClient.scala, line 1 > > > > > > I think kafka.client would be a better place for this than kafka.tools > > > > In fact

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-24 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146751#comment-14146751 ] Sriram Subramanian commented on KAFKA-1555: --- Jun, I am not arguing that we shou

[jira] [Commented] (KAFKA-1490) remove gradlew initial setup output from source distribution

2014-09-24 Thread Szczepan Faber (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146755#comment-14146755 ] Szczepan Faber commented on KAFKA-1490: --- Thanks for info. I'll send an email to the

[jira] [Comment Edited] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-24 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146751#comment-14146751 ] Sriram Subramanian edited comment on KAFKA-1555 at 9/24/14 9:32 PM:

[jira] [Commented] (KAFKA-1490) remove gradlew initial setup output from source distribution

2014-09-24 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146952#comment-14146952 ] Joe Stein commented on KAFKA-1490: -- [~szczepiq] Thanks! Hans just shot me the thread disc

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-09-24 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147187#comment-14147187 ] Joel Koshy commented on KAFKA-1499: --- [~omkreddy] I thought I would try this locally but

[jira] [Commented] (KAFKA-1476) Get a list of consumer groups

2014-09-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147189#comment-14147189 ] Neha Narkhede commented on KAFKA-1476: -- [~balaji.sesha...@dish.com] Wondering if you

Re: Review Request 25944: Patch for KAFKA-1013

2014-09-24 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review54487 --- Can you consolidate the import and export offsets tools into a singl

[jira] [Commented] (KAFKA-1476) Get a list of consumer groups

2014-09-24 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147200#comment-14147200 ] BalajiSeshadri commented on KAFKA-1476: --- Will do by this week end. > Get a list of

Re: How producer gets the acknowledgement back

2014-09-24 Thread Guozhang Wang
Hi, In the new (Java) producer, you can pass in a callback function in the Future send(ProducerRecord record, Callback callback) call, which will be triggered when the ack is received. Alternatively, you can also call Future.get() on the returned future metadata, which will block until the ack

[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-09-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147241#comment-14147241 ] Neha Narkhede commented on KAFKA-1618: -- Thanks for the latest patch, [~balaji.sesha..

[jira] [Commented] (KAFKA-1019) kafka-preferred-replica-election.sh will fail without clear error message if /brokers/topics/[topic]/partitions does not exist

2014-09-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147244#comment-14147244 ] Neha Narkhede commented on KAFKA-1019: -- Thanks for checking, [~sriharsha]. I wonder i

[jira] [Updated] (KAFKA-1019) kafka-preferred-replica-election.sh will fail without clear error message if /brokers/topics/[topic]/partitions does not exist

2014-09-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1019: - Reviewer: Neha Narkhede > kafka-preferred-replica-election.sh will fail without clear error messag

[jira] [Updated] (KAFKA-1645) some more jars in our src release

2014-09-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1645: - Reviewer: Jun Rao > some more jars in our src release > - > >

[jira] [Closed] (KAFKA-1649) Protocol documentation does not indicate that ReplicaNotAvailable can be ignored

2014-09-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1649. > Protocol documentation does not indicate that ReplicaNotAvailable can be > ignored >

[jira] [Commented] (KAFKA-1649) Protocol documentation does not indicate that ReplicaNotAvailable can be ignored

2014-09-24 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147250#comment-14147250 ] Joe Stein commented on KAFKA-1649: -- [~hernaninaka] I added your username for edits on the

[jira] [Commented] (KAFKA-1611) Improve system test configuration

2014-09-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147335#comment-14147335 ] Neha Narkhede commented on KAFKA-1611: -- Thanks [~gwenshap] > Improve system test con

[jira] [Closed] (KAFKA-1611) Improve system test configuration

2014-09-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1611. > Improve system test configuration > - > > Key: KAFKA-1

Re: How producer gets the acknowledgement back

2014-09-24 Thread Steven Wu
It may be too late to change the Producer API now. I always find "ListenableFuture" is very nice/usable. It essentially adds callback to Future. It's a lot easier to chain/combine ListenableFuture. http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/util/concurrent/ListenableF

Re: Review Request 25992: Patch for KAFKA-1645

2014-09-24 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25992/#review54508 --- Ship it! Could you also remove the migration test cases in system_

[jira] [Commented] (KAFKA-1645) some more jars in our src release

2014-09-24 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147342#comment-14147342 ] Jun Rao commented on KAFKA-1645: Thanks for the patch. +1. Committed to trunk after fixing

[jira] [Comment Edited] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-24 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146337#comment-14146337 ] Jonathan Creasy edited comment on KAFKA-404 at 9/25/14 4:16 AM: -

[jira] [Issue Comment Deleted] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-24 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Creasy updated KAFKA-404: -- Comment: was deleted (was: New v4, works, all tests pass also) > When using chroot path, create

[jira] [Updated] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-09-24 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BalajiSeshadri updated KAFKA-1618: -- Attachment: KAFKA-1618-ALL.patch [~nehanarkhede] Please review > Exception thrown when running

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-24 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147352#comment-14147352 ] Jun Rao commented on KAFKA-1555: Sriram, With this patch, I am thinking that the ack mode

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-24 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147353#comment-14147353 ] Joe Stein commented on KAFKA-1555: -- << drop the support of ack > 1 +1 > provide strong c

[jira] [Updated] (KAFKA-1645) some more jars in our src release

2014-09-24 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1645: --- Resolution: Fixed Status: Resolved (was: Patch Available) > some more jars in our src release > -

[jira] [Comment Edited] (KAFKA-1476) Get a list of consumer groups

2014-09-24 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147200#comment-14147200 ] BalajiSeshadri edited comment on KAFKA-1476 at 9/25/14 4:29 AM:

[jira] [Comment Edited] (KAFKA-1476) Get a list of consumer groups

2014-09-24 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147200#comment-14147200 ] BalajiSeshadri edited comment on KAFKA-1476 at 9/25/14 4:29 AM:

[jira] [Commented] (KAFKA-1634) Update protocol wiki to reflect the new offset management feature

2014-09-24 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147354#comment-14147354 ] Jun Rao commented on KAFKA-1634: One use case is that if a client never wants the offset t

[jira] [Commented] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147362#comment-14147362 ] Neha Narkhede commented on KAFKA-404: - Thanks for the latest patch. I think there is a

[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-09-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147365#comment-14147365 ] Neha Narkhede commented on KAFKA-1618: -- Thanks for the patch, though I couldn't apply

[jira] [Updated] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-24 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Creasy updated KAFKA-404: -- Attachment: KAFKA-404-auto-create-zookeeper-chroot-on-start-up-v5.patch I added a unit test for t

[jira] [Commented] (KAFKA-1634) Update protocol wiki to reflect the new offset management feature

2014-09-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147368#comment-14147368 ] Neha Narkhede commented on KAFKA-1634: -- How general is that use case and if it just a

[jira] [Updated] (KAFKA-1648) Round robin consumer balance throws an NPE when there are no topics

2014-09-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1648: - Reviewer: Joel Koshy Assigning this to Joel for review as he probably has the most context on this

[jira] [Commented] (KAFKA-328) Write unit test for kafka server startup and shutdown API

2014-09-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147374#comment-14147374 ] Neha Narkhede commented on KAFKA-328: - Thanks for the patch, [~balaji.sesha...@dish.com

Build failed in Jenkins: Kafka-trunk #276

2014-09-24 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1645; some more jars in our src release; patched by Joe Stein; reviewed by Jun Rao -- Started by an SCM change Building remotely on ubuntu3 (Ubuntu ubuntu) in workspace <

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2014-09-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1646: - Labels: newbie patch (was: patch) > Improve consumer read performance for Windows > -

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2014-09-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1646: - Assignee: (was: Jay Kreps) > Improve consumer read performance for Windows > -

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2014-09-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147377#comment-14147377 ] Neha Narkhede commented on KAFKA-1367: -- bq. I definitely agree with Magnus Edenhill t

[jira] [Updated] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-24 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Creasy updated KAFKA-404: -- Attachment: (was: KAFKA-404-auto-create-zookeeper-chroot-on-start-up-v5.patch) > When using

[jira] [Updated] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-24 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Creasy updated KAFKA-404: -- Attachment: KAFKA-404-auto-create-zookeeper-chroot-on-start-up-v5.patch Confirmed, unit test fail

Re: Review Request 25944: Patch for KAFKA-1013

2014-09-24 Thread Mayuresh Gharat
> On Sept. 25, 2014, 12:54 a.m., Neha Narkhede wrote: > > Can you consolidate the import and export offsets tools into a single tool? > > We already have https://issues.apache.org/jira/browse/KAFKA-1476 filed to > > consolidate tools and it will be great to not create too many redundant > > to

Re: Review Request 25886: KAFKA-1555: provide strong consistency with reasonable availability

2014-09-24 Thread Gwen Shapira
> On Sept. 24, 2014, 5:06 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/cluster/Partition.scala, lines 272-276 > > > > > > Perhaps we should just do > > leaderReplica.log.get.config.minInSyncReplicas. Thank you!

Re: Review Request 25886: KAFKA-1555: provide strong consistency with reasonable availability

2014-09-24 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25886/ --- (Updated Sept. 25, 2014, 5:23 a.m.) Review request for kafka. Changes ---

[jira] [Updated] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-24 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1555: Attachment: KAFKA-1555.4.patch > provide strong consistency with reasonable availability > -

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-24 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147394#comment-14147394 ] Gwen Shapira commented on KAFKA-1555: - +1 for dropping ack > 1 The whole Jira started

Review Request 26018: Patch for KAFKA-404

2014-09-24 Thread Jonathan Creasy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26018/ --- Review request for kafka. Bugs: KAFKA-404 https://issues.apache.org/jira/br

[jira] [Commented] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-24 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147396#comment-14147396 ] Jonathan Creasy commented on KAFKA-404: --- Created reviewboard https://reviews.apache.o

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-24 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147395#comment-14147395 ] Gwen Shapira commented on KAFKA-1555: - Also, attached a version of the patch with few

Review Request 26019: Patch for KAFKA-404

2014-09-24 Thread Jonathan Creasy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26019/ --- Review request for kafka. Bugs: KAFKA-404 https://issues.apache.org/jira/br

[jira] [Updated] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-24 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Creasy updated KAFKA-404: -- Attachment: KAFKA-404.patch > When using chroot path, create chroot on startup if it doesn't exis

[jira] [Updated] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-24 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Creasy updated KAFKA-404: -- Attachment: KAFKA-404.patch > When using chroot path, create chroot on startup if it doesn't exis

[jira] [Commented] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-24 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147397#comment-14147397 ] Jonathan Creasy commented on KAFKA-404: --- Created reviewboard https://reviews.apache.o

[jira] [Issue Comment Deleted] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-24 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Creasy updated KAFKA-404: -- Comment: was deleted (was: Created reviewboard https://reviews.apache.org/r/26018/diff/ against

[jira] [Updated] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-24 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Creasy updated KAFKA-404: -- Attachment: (was: KAFKA-404.patch) > When using chroot path, create chroot on startup if it d

Re: Review Request 26019: Patch for KAFKA-404

2014-09-24 Thread Jonathan Creasy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26019/ --- (Updated Sept. 25, 2014, 5:34 a.m.) Review request for kafka. Bugs: KAFKA-404

Re: Review Request 26019: Patch for KAFKA-404

2014-09-24 Thread Jonathan Creasy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26019/ --- (Updated Sept. 25, 2014, 5:37 a.m.) Review request for kafka. Bugs: KAFKA-404

Re: Review Request 24704: Patch for KAFKA-1499

2014-09-24 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/ --- (Updated Sept. 25, 2014, 5:38 a.m.) Review request for kafka. Bugs: KAFKA-149

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-09-24 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147429#comment-14147429 ] Manikumar Reddy commented on KAFKA-1499: Updated reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-1499) Broker-side compression configuration

2014-09-24 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1499: --- Attachment: KAFKA-1499_2014-09-25_11:05:57.patch > Broker-side compression configuration > ---

Re: Review Request 24704: Patch for KAFKA-1499

2014-09-24 Thread Jonathan Creasy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54513 --- Ship it! Ship It! - Jonathan Creasy On Sept. 25, 2014, 5:38 a.m.

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-09-24 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147434#comment-14147434 ] Manikumar Reddy commented on KAFKA-1499: i missed a line in LogConfig. Uploaded ne

[jira] [Created] (KAFKA-1651) Removed some extra whitespace in KafkaServer.scala

2014-09-24 Thread Jonathan Creasy (JIRA)
Jonathan Creasy created KAFKA-1651: -- Summary: Removed some extra whitespace in KafkaServer.scala Key: KAFKA-1651 URL: https://issues.apache.org/jira/browse/KAFKA-1651 Project: Kafka Issue Ty

  1   2   >