[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-08-03 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084033#comment-14084033 ] Gwen Shapira commented on KAFKA-1555: - If we go with the idea that ack=2 means "at le

Review Request 24214: Patch for KAFKA-1374

2014-08-03 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24214/ --- Review request for kafka. Bugs: KAFKA-1374 https://issues.apache.org/jira/b

[jira] [Assigned] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2014-08-03 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy reassigned KAFKA-1374: -- Assignee: Manikumar Reddy > LogCleaner (compaction) does not support compressed topics

[jira] [Updated] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2014-08-03 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1374: --- Attachment: KAFKA-1374.patch > LogCleaner (compaction) does not support compressed topics > -

[jira] [Commented] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2014-08-03 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084044#comment-14084044 ] Manikumar Reddy commented on KAFKA-1374: Created reviewboard https://reviews.apach

[jira] [Commented] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2014-08-03 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084047#comment-14084047 ] Manikumar Reddy commented on KAFKA-1374: In this patch, LogCleaner decompress the

Re: Review Request 24196: Patch for KAFKA-1567

2014-08-03 Thread Jiangjie Qin
> On Aug. 1, 2014, 11:33 p.m., Guozhang Wang wrote: > > To be more precisely, in the old clients we have four stats classes: > > > > 1. ProducerTopicStats > > 2. ProducerRequestStats > > 3. ProducerStats > > 4. FetchRequestAndResponseStats > > 5. ConsumerTopicStats > > > > Among them: > > > >

Re: Review Request 24196: Patch for KAFKA-1567

2014-08-03 Thread Jun Rao
> On Aug. 1, 2014, 11:33 p.m., Guozhang Wang wrote: > > To be more precisely, in the old clients we have four stats classes: > > > > 1. ProducerTopicStats > > 2. ProducerRequestStats > > 3. ProducerStats > > 4. FetchRequestAndResponseStats > > 5. ConsumerTopicStats > > > > Among them: > > > >

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-08-03 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084265#comment-14084265 ] Jun Rao commented on KAFKA-1555: Gwen, I like what you suggested. We can introduce a new

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-08-03 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084280#comment-14084280 ] Gwen Shapira commented on KAFKA-1555: - Perfect. The producer can catch the error and

Newer Zookeeper?

2014-08-03 Thread Gwen Shapira
Hi, Kafka currently builds against Zookeeper 3.3.4, which is quite old. Perhaps we should move to the more recent 3.4.x branch? I tested the change on my system and the only impact is to EmbeddedZookeeper used in tests (it uses NIOServerCnxn.factory, which was refactored into its own class in 3.