Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/ --- (Updated June 3, 2014, 10:53 a.m.) Review request for kafka. Bugs: KAFKA-1477

[jira] [Updated] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication

[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1477: --- Attachment: KAFKA-1477_2014-06-03_13:46:17.patch > add authentication layer and initial JKS x509 impl

[jira] [Commented] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication

[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016379#comment-14016379 ] Ivan Lyutov commented on KAFKA-1477: Updated reviewboard https://reviews.apache.org/r/

Re: Review Request 22131: Patch for KAFKA-1477

> On June 3, 2014, 3:14 a.m., Joe Stein wrote: > > core/src/main/scala/kafka/network/BlockingChannel.scala, line 80 > > > > > > is this change and the ones below it, are they really required? Yes. Otherwise, there will

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44618 --- core/src/main/scala/kafka/network/BlockingChannel.scala

Re: Review Request 22131: Patch for KAFKA-1477

> On June 3, 2014, 12:37 p.m., Joe Stein wrote: > > core/src/main/scala/kafka/network/BlockingChannel.scala, line 80 > > > > > > ok, then can you make that log line info instead of debug please. > > thanks! never min

[jira] [Commented] (KAFKA-1456) Add LZ4 and LZ4C as a compression codec

[ https://issues.apache.org/jira/browse/KAFKA-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016476#comment-14016476 ] Joe Stein commented on KAFKA-1456: -- Looks like a good point. I have been looking through

[jira] [Commented] (KAFKA-924) Specify console consumer properties via a single --property command line parameter

[ https://issues.apache.org/jira/browse/KAFKA-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016560#comment-14016560 ] Jun Rao commented on KAFKA-924: --- Thanks for the followup patch. Committed to trunk. > Specif

Build failed in Jenkins: Kafka-trunk #197

See Changes: [junrao] kafka-924 (follow-up); Specify console consumer properties via a single --property command line parameter;; patched by Sriharsha Chintalapani; reviewed by Jun Rao -- [...trunc

Re: Review Request 21937: Patch for KAFKA-1316

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21937/ --- (Updated June 3, 2014, 6:15 p.m.) Review request for kafka. Summary (updated)

[jira] [Commented] (KAFKA-1316) Refactor Sender

[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016946#comment-14016946 ] Jay Kreps commented on KAFKA-1316: -- Updated reviewboard https://reviews.apache.org/r/2193

[jira] [Updated] (KAFKA-1316) Refactor Sender

[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1316: - Attachment: KAFKA-1316_2014-06-03_11:15:38.patch > Refactor Sender > --- > >

Re: Build failed in Jenkins: Kafka-trunk #197

Jun, Why do we have test failures post KAFKA-924? Thanks, Neha On Tue, Jun 3, 2014 at 11:12 AM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See > > Changes: > > [junrao] kafka-924 (follow-up); Specify console consumer prop

[jira] [Created] (KAFKA-1482) Transient test failures for kafka.admin.DeleteTopicTest

Guozhang Wang created KAFKA-1482: Summary: Transient test failures for kafka.admin.DeleteTopicTest Key: KAFKA-1482 URL: https://issues.apache.org/jira/browse/KAFKA-1482 Project: Kafka Issue T

[jira] [Updated] (KAFKA-1482) Transient test failures for kafka.admin.DeleteTopicTest

[ https://issues.apache.org/jira/browse/KAFKA-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1482: - Description: A couple of test cases have timing related transient test failures: kafka.admin.Del

[jira] [Commented] (KAFKA-1479) Logs filling up while Kafka ReplicaFetcherThread tries to retrieve partition info for deleted topics

[ https://issues.apache.org/jira/browse/KAFKA-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017044#comment-14017044 ] Manasi Manasi commented on KAFKA-1479: -- Nope. That didn't solve the problem. I still

[jira] [Comment Edited] (KAFKA-1479) Logs filling up while Kafka ReplicaFetcherThread tries to retrieve partition info for deleted topics

[ https://issues.apache.org/jira/browse/KAFKA-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017044#comment-14017044 ] Manasi Manasi edited comment on KAFKA-1479 at 6/3/14 7:47 PM: --

Re: Build failed in Jenkins: Kafka-trunk #197

I have seen those port reusing issues before. So, this is unrelated to the followup patch in KAFKA-924, which only fixes system tests. I was trying to wait until unit tests get more stable before fixing the port reuse issue. Thanks, Jun On Tue, Jun 3, 2014 at 11:23 AM, Neha Narkhede wrote: >

[DISCUSS] Kafka Security Specific Features

Hi,I wanted to re-ignite the discussion around Apache Kafka Security. This is a huge bottleneck (non-starter in some cases) for a lot of organizations (due to regulatory, compliance and other requirements). Below are my suggestions for specific changes in Kafka to accommodate security requirements

Re: [DISCUSS] Kafka Security Specific Features

... client specific presented information, signed in some way, listing topic permissions. read, write, list. TLS lends itself to client certificates. On Jun 3, 2014, at 12:57 PM, Joe Stein wrote: > 4) Authorization > > We should have a policy of "404" for data, topics, partitions (etc) if >

Re: Build failed in Jenkins: Kafka-trunk #197

I see. So presumably some unit test breaks and causes others to fail due to port reuse. Probably we still have some transient unit test failures. On Tue, Jun 3, 2014 at 12:56 PM, Jun Rao wrote: > I have seen those port reusing issues before. So, this is unrelated to the > followup patch in KA

[jira] [Updated] (KAFKA-1469) Util.abs function does not return correct absolute values for negative values

[ https://issues.apache.org/jira/browse/KAFKA-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Geller updated KAFKA-1469: Attachment: KAFKA-1469.patch > Util.abs function does not return correct absolute values fo

[jira] [Updated] (KAFKA-1469) Util.abs function does not return correct absolute values for negative values

[ https://issues.apache.org/jira/browse/KAFKA-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Geller updated KAFKA-1469: Labels: newbie patch (was: newbie) Status: Patch Available (was: Open) > Util.abs fun

[jira] [Commented] (KAFKA-1469) Util.abs function does not return correct absolute values for negative values

[ https://issues.apache.org/jira/browse/KAFKA-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017113#comment-14017113 ] Sebastian Geller commented on KAFKA-1469: - This patch handles MinValue as describe

[jira] [Commented] (KAFKA-1456) Add LZ4 and LZ4C as a compression codec

[ https://issues.apache.org/jira/browse/KAFKA-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017133#comment-14017133 ] Jay Kreps commented on KAFKA-1456: -- Guys, does this add a runtime dependency on this jar

[jira] [Commented] (KAFKA-1456) Add LZ4 and LZ4C as a compression codec

[ https://issues.apache.org/jira/browse/KAFKA-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017149#comment-14017149 ] Joe Stein commented on KAFKA-1456: -- it shouldn't since the imports are all within the cas

[jira] [Created] (KAFKA-1483) Split Brain about Leader Partitions

Guozhang Wang created KAFKA-1483: Summary: Split Brain about Leader Partitions Key: KAFKA-1483 URL: https://issues.apache.org/jira/browse/KAFKA-1483 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1316) Refactor Sender

[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017182#comment-14017182 ] Jay Kreps commented on KAFKA-1316: -- Updated reviewboard https://reviews.apache.org/r/2193

Re: Review Request 21937: Patch for KAFKA-1316

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21937/ --- (Updated June 3, 2014, 9:33 p.m.) Review request for kafka. Bugs: KAFKA-1316

[jira] [Updated] (KAFKA-1316) Refactor Sender

[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1316: - Attachment: KAFKA-1316_2014-06-03_14:33:33.patch > Refactor Sender > --- > >

Review Request 22220: Fix KAFKA-1473

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/0/ --- Review request for kafka. Bugs: KAFKA-1473 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1473) transient unit test failure in testRequestHandlingDuringDeleteTopic

[ https://issues.apache.org/jira/browse/KAFKA-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1473: - Attachment: KAFKA-1473.patch > transient unit test failure in testRequestHandlingDuringDeleteTopi

[jira] [Commented] (KAFKA-1473) transient unit test failure in testRequestHandlingDuringDeleteTopic

[ https://issues.apache.org/jira/browse/KAFKA-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017184#comment-14017184 ] Guozhang Wang commented on KAFKA-1473: -- Created reviewboard https://reviews.apache.or

Re: [DISCUSS] Kafka Security Specific Features

I think that¹s one option. What I would offer here is that we need to separate out the concepts of authorization and authentication. Authentication should definitely be modular, so that we can plug in appropriate schemes depending on the organization. For example, you may want client certificates,

[jira] [Commented] (KAFKA-1456) Add LZ4 and LZ4C as a compression codec

[ https://issues.apache.org/jira/browse/KAFKA-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017243#comment-14017243 ] James Oliver commented on KAFKA-1456: - The Java client uses reflection to invoke the c

[jira] [Commented] (KAFKA-1479) Logs filling up while Kafka ReplicaFetcherThread tries to retrieve partition info for deleted topics

[ https://issues.apache.org/jira/browse/KAFKA-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017264#comment-14017264 ] Manasi Manasi commented on KAFKA-1479: -- Ok, resolved the issue. Basically deleted dat

[jira] [Commented] (KAFKA-1456) Add LZ4 and LZ4C as a compression codec

[ https://issues.apache.org/jira/browse/KAFKA-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017270#comment-14017270 ] Steven Schlansker commented on KAFKA-1456: -- lz4-java tracks the lack of the commo

[jira] [Commented] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication

[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017326#comment-14017326 ] Jun Rao commented on KAFKA-1477: Thanks for the patch. A couple comments. 1. Since this i

[jira] [Updated] (KAFKA-1475) Kafka consumer stops LeaderFinder/FetcherThreads, but application does not know

[ https://issues.apache.org/jira/browse/KAFKA-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hang Qi updated KAFKA-1475: --- Attachment: 5055aeee-zk.txt > Kafka consumer stops LeaderFinder/FetcherThreads, but application does not > k

[jira] [Commented] (KAFKA-1475) Kafka consumer stops LeaderFinder/FetcherThreads, but application does not know

[ https://issues.apache.org/jira/browse/KAFKA-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017341#comment-14017341 ] Hang Qi commented on KAFKA-1475: Hi Guozhang, Thanks for your reply, in this case, we hav

C# client and wiki update

Hey guys. I have created a C# client for kafka and would like to get it added to the wiki. I have signed up to the wiki, but it does not provide me with the permissions to make the changes myself. Here is the project link on github: https://github.com/Jroland/kafka-net Pure C# client with full

Re: C# client and wiki update

Added it - https://cwiki.apache.org/confluence/display/KAFKA/Clients#Clients-.net. Thanks for the contribution! On Tue, Jun 3, 2014 at 9:39 PM, James Roland wrote: > Hey guys. I have created a C# client for kafka and would like to get it > added to the wiki. I have signed up to the wiki, but