Review Request 20252: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20252/ --- Review request for kafka. Bugs: KAFKA-1356 https://issues.apache.org/jira/b

Re: Review Request 20252: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20252/ --- (Updated April 11, 2014, 7:41 a.m.) Review request for kafka. Bugs: KAFKA-135

Re: Review Request 20252: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20252/ --- (Updated April 11, 2014, 7:42 a.m.) Review request for kafka. Bugs: KAFKA-135

[jira] [Updated] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1356: Attachment: KAFKA-1356.patch > Topic metadata requests takes too long to process >

[jira] [Commented] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966312#comment-13966312 ] Timothy Chen commented on KAFKA-1356: - Created reviewboard https://reviews.apache.org/

Re: Please create a DOAP for your project

On 11 April 2014 10:55, Juan Pablo Santos Rodríguez wrote: > Hi Sebb, > > JSPWiki's DOAP file is under > http://svn.apache.org/repos/asf/jspwiki/site/doap/doap-jspwiki.rdf, with > http://projects.apache.org/projects/jspwiki.html pointing to that URL. Is > there something we've missed? > Yes, the

[jira] [Created] (KAFKA-1388) Kafka sources and javadoc missing from Maven central

Andras Sereny created KAFKA-1388: Summary: Kafka sources and javadoc missing from Maven central Key: KAFKA-1388 URL: https://issues.apache.org/jira/browse/KAFKA-1388 Project: Kafka Issue Type

[jira] [Commented] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1394#comment-1394 ] Guozhang Wang commented on KAFKA-1387: -- Hi Fedor, do you think this is caused by the

[jira] [Resolved] (KAFKA-1388) Kafka sources and javadoc missing from Maven central

[ https://issues.apache.org/jira/browse/KAFKA-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stevo Slavic resolved KAFKA-1388. - Resolution: Duplicate Resolving as duplicate of KAFKA-1362 > Kafka sources and javadoc missing f

Re: Review Request 20190: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20190/#review39992 --- Ship it! core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 20232: Avoid sending all topic metadata on state changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20232/#review40159 --- Ship it! Ship It! - Guozhang Wang On April 10, 2014, 9:02 p.m.,

[jira] [Commented] (KAFKA-1382) Update zkVersion on partition state update failures

[ https://issues.apache.org/jira/browse/KAFKA-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966743#comment-13966743 ] Jun Rao commented on KAFKA-1382: Joel, Yes, that's a good point. When the leader tries to

[jira] [Commented] (KAFKA-1352) Reduce logging on the server

[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966807#comment-13966807 ] Neha Narkhede commented on KAFKA-1352: -- [~guozhang] I think it will be easier to revi

Re: Review Request 20232: Avoid sending all topic metadata on state changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20232/#review40166 --- Ship it! Ship It! - Neha Narkhede On April 10, 2014, 9:02 p.m.,

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated April 11, 2014, 5:54 p.m.) Review request for kafka. Bugs: KAFKA-132

[jira] [Updated] (KAFKA-1328) Add new consumer APIs

[ https://issues.apache.org/jira/browse/KAFKA-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1328: - Attachment: KAFKA-1328_2014-04-11_10:54:19.patch > Add new consumer APIs > -

[jira] [Commented] (KAFKA-1328) Add new consumer APIs

[ https://issues.apache.org/jira/browse/KAFKA-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966873#comment-13966873 ] Neha Narkhede commented on KAFKA-1328: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1352) Reduce logging on the server

[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966886#comment-13966886 ] Joel Koshy commented on KAFKA-1352: --- +1 on having example output to help review. It woul

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated April 11, 2014, 6:16 p.m.) Review request for kafka. Bugs: KAFKA-132

[jira] [Commented] (KAFKA-1328) Add new consumer APIs

[ https://issues.apache.org/jira/browse/KAFKA-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966911#comment-13966911 ] Neha Narkhede commented on KAFKA-1328: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1328) Add new consumer APIs

[ https://issues.apache.org/jira/browse/KAFKA-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1328: - Attachment: KAFKA-1328_2014-04-11_11:16:44.patch > Add new consumer APIs > -

[jira] [Commented] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966947#comment-13966947 ] Jun Rao commented on KAFKA-1356: Updated reviewboard against branch origin/trunk > Topic

[jira] [Updated] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1356: --- Attachment: KAFKA-1356_2014-04-11_11:39:10.patch > Topic metadata requests takes too long to process > --

[jira] [Commented] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966954#comment-13966954 ] Jun Rao commented on KAFKA-1356: Upload another patch for the following fix. RB doesn't wo

[jira] [Updated] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1356: --- Attachment: KAFKA-1356.patch > Topic metadata requests takes too long to process > --

[jira] [Commented] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967094#comment-13967094 ] Jun Rao commented on KAFKA-1356: Created reviewboard https://reviews.apache.org/r/20272/

Review Request 20272: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20272/ --- Review request for kafka. Bugs: KAFKA-1356 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1359: - Attachment: KAFKA-1359_2014-04-11_14:20:45.patch > Add topic/broker metrics once new topic/broker

Re: Review Request 20050: Fix KAFKA-1359: incorporate Jun's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/ --- (Updated April 11, 2014, 9:20 p.m.) Review request for kafka. Summary (update

[jira] [Commented] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967107#comment-13967107 ] Guozhang Wang commented on KAFKA-1359: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1337) Rationalize new producer configs

[ https://issues.apache.org/jira/browse/KAFKA-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967133#comment-13967133 ] Jun Rao commented on KAFKA-1337: Thanks for the delta patch. Committed to trunk. > Ration

[jira] [Commented] (KAFKA-1352) Reduce logging on the server

[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967146#comment-13967146 ] Jun Rao commented on KAFKA-1352: We should probably log those in a single line. 2014/04/11

[jira] [Commented] (KAFKA-1352) Reduce logging on the server

[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967159#comment-13967159 ] Joel Koshy commented on KAFKA-1352: --- In this specific case given that there are a few fi

Build failed in Jenkins: Kafka-trunk #161

See Changes: [junrao] kafka-1337; follow-up patch to add broker list for new producer in system test overriden function; patched by Guozhang Wang; reviewed by Neha Narkhede, Jun Rao -- [...truncated

[jira] [Commented] (KAFKA-1352) Reduce logging on the server

[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967265#comment-13967265 ] Guozhang Wang commented on KAFKA-1352: -- The proposed RB was mainly on reducing redund

[jira] [Commented] (KAFKA-1352) Reduce logging on the server

[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967297#comment-13967297 ] Guozhang Wang commented on KAFKA-1352: -- We have this describe() function that have th

Re: Review Request 20186: Patch for KAFKA-1377

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20186/ --- (Updated April 12, 2014, 12:42 a.m.) Review request for kafka. Bugs: KAFKA-13

[jira] [Commented] (KAFKA-1377) transient unit test failure in LogOffsetTest

[ https://issues.apache.org/jira/browse/KAFKA-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967303#comment-13967303 ] Jun Rao commented on KAFKA-1377: Updated reviewboard https://reviews.apache.org/r/20186/

[jira] [Updated] (KAFKA-1377) transient unit test failure in LogOffsetTest

[ https://issues.apache.org/jira/browse/KAFKA-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1377: --- Attachment: KAFKA-1377_2014-04-11_17:42:13.patch > transient unit test failure in LogOffsetTest > ---

Re: Review Request 20186: Patch for KAFKA-1377

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20186/ --- (Updated April 12, 2014, 1:14 a.m.) Review request for kafka. Bugs: KAFKA-137

[jira] [Updated] (KAFKA-1377) transient unit test failure in LogOffsetTest

[ https://issues.apache.org/jira/browse/KAFKA-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1377: --- Attachment: KAFKA-1377_2014-04-11_18:14:45.patch > transient unit test failure in LogOffsetTest > ---

[jira] [Commented] (KAFKA-1377) transient unit test failure in LogOffsetTest

[ https://issues.apache.org/jira/browse/KAFKA-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967323#comment-13967323 ] Jun Rao commented on KAFKA-1377: Updated reviewboard https://reviews.apache.org/r/20186/

Re: Review Request 20189: Patch for KAFKA-1378

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20189/ --- (Updated April 12, 2014, 1:21 a.m.) Review request for kafka. Bugs: KAFKA-137

[jira] [Commented] (KAFKA-1378) transient unit test failure in LogRecoveryTest

[ https://issues.apache.org/jira/browse/KAFKA-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967331#comment-13967331 ] Jun Rao commented on KAFKA-1378: Updated reviewboard https://reviews.apache.org/r/20189/

[jira] [Updated] (KAFKA-1378) transient unit test failure in LogRecoveryTest

[ https://issues.apache.org/jira/browse/KAFKA-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1378: --- Attachment: KAFKA-1378_2014-04-11_18:21:34.patch > transient unit test failure in LogRecoveryTest > -

Re: Review Request 20186: Patch for KAFKA-1377

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20186/#review40193 --- Ship it! Ship It! - Guozhang Wang On April 12, 2014, 1:14 a.m.,

Re: Review Request 20189: Patch for KAFKA-1378

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20189/#review40195 --- core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala

Re: Review Request 20185: Patch for KAFKA-1381

> On April 10, 2014, 4:27 p.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala, line 175 > > > > > > Trying to understand why we are removing this? It's fine if we do, just > > c

Re: Review Request 20185: Patch for KAFKA-1381

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20185/ --- (Updated April 12, 2014, 1:39 a.m.) Review request for kafka. Bugs: KAFKA-138

[jira] [Commented] (KAFKA-1381) transient unit test failure in AddPartitionsTest

[ https://issues.apache.org/jira/browse/KAFKA-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967337#comment-13967337 ] Jun Rao commented on KAFKA-1381: Updated reviewboard https://reviews.apache.org/r/20185/

[jira] [Updated] (KAFKA-1381) transient unit test failure in AddPartitionsTest

[ https://issues.apache.org/jira/browse/KAFKA-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1381: --- Attachment: KAFKA-1381_2014-04-11_18:39:42.patch > transient unit test failure in AddPartitionsTest > ---

Re: Review Request 20143: Patch for KAFKA-1363

> On April 10, 2014, 6:24 a.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/controller/TopicDeletionManager.scala, line 104 > > > > > > Why do we need to call this function here? This is needed to unblock await

Re: Review Request 20143: Patch for KAFKA-1363

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20143/#review40200 --- Ship it! Ship It! - Jun Rao On April 9, 2014, 6:38 p.m., Timothy

[jira] [Commented] (KAFKA-1363) testTopicConfigChangesDuringDeleteTopic hangs

[ https://issues.apache.org/jira/browse/KAFKA-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967376#comment-13967376 ] Jun Rao commented on KAFKA-1363: Thanks for the patch. +1 and committed to trunk. > testT