Re: Review Request 18299: Fix KAFKA-1253

2014-03-07 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/#review36525 --- Does the unit test pass? It seems to hang on ProducerFailureHandling

Re: Review Request 18299: Fix KAFKA-1253

2014-03-07 Thread Guozhang Wang
> On March 7, 2014, 5:58 p.m., Jun Rao wrote: > > Does the unit test pass? It seems to hang on ProducerFailureHandlingTest. It does pass on my machine. Is the handing issue persistent or it is transient? > On March 7, 2014, 5:58 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/c

Re: Review Request 18774: Patch for KAFKA-1240

2014-03-07 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18774/#review36554 --- core/src/main/scala/kafka/utils/Utils.scala

[jira] [Updated] (KAFKA-1300) Added WaitForReplaction admin tool.

2014-03-07 Thread Brenden Matthews (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brenden Matthews updated KAFKA-1300: Labels: patch (was: ) Status: Patch Available (was: Open) > Added WaitForReplaction a

[jira] [Created] (KAFKA-1300) Added WaitForReplaction admin tool.

2014-03-07 Thread Brenden Matthews (JIRA)
Brenden Matthews created KAFKA-1300: --- Summary: Added WaitForReplaction admin tool. Key: KAFKA-1300 URL: https://issues.apache.org/jira/browse/KAFKA-1300 Project: Kafka Issue Type: New Featu

[jira] [Updated] (KAFKA-1300) Added WaitForReplaction admin tool.

2014-03-07 Thread Brenden Matthews (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brenden Matthews updated KAFKA-1300: Attachment: 0001-Added-WaitForReplaction-admin-tool.patch > Added WaitForReplaction admin t

[jira] [Updated] (KAFKA-1300) Added WaitForReplaction admin tool.

2014-03-07 Thread Brenden Matthews (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brenden Matthews updated KAFKA-1300: Description: I have created a tool similar to the broker shutdown tool for doing rolling r

Re: Review Request 18299: Fix KAFKA-1253

2014-03-07 Thread Guozhang Wang
> On March 7, 2014, 5:58 p.m., Jun Rao wrote: > > build.gradle, lines 40-71 > > > > > > This should be uncommented. The un-commentating missed my commit last time, will fix. > On March 7, 2014, 5:58 p.m., Jun Rao wro

Re: Review Request 18299: Fix KAFKA-1253

2014-03-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 8, 2014, 12:34 a.m.) Review request for kafka. Bugs: KAFKA-125

[jira] [Updated] (KAFKA-1253) Implement compression in new producer

2014-03-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1253: - Attachment: KAFKA-1253_2014-03-07_16:34:33.patch > Implement compression in new producer > --

Re: Review Request 18299: Fix KAFKA-1253

2014-03-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 8, 2014, 12:36 a.m.) Review request for kafka. Bugs: KAFKA-125

[jira] [Commented] (KAFKA-1253) Implement compression in new producer

2014-03-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924565#comment-13924565 ] Guozhang Wang commented on KAFKA-1253: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 18774: Patch for KAFKA-1240

2014-03-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18774/#review36588 --- core/src/main/scala/kafka/utils/Utils.scala

[jira] [Commented] (KAFKA-1275) fixes for quickstart documentation

2014-03-07 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924661#comment-13924661 ] Joe Stein commented on KAFKA-1275: -- [~jkreps] looks fantastic! > fixes for quickstart d

Re: [VOTE] Apache Kafka Release 0.8.1 - Candidate 2

2014-03-07 Thread Joe Stein
If we do not have the votes by Monday we can extend the voting. Not sure if an issue came up on the list and I missed it (catching up on emails). On Wed, Mar 5, 2014 at 1:59 AM, Joe Stein wrote: > This is the second candidate for release of Apache Kafka 0.8.1. > > This release candidate fixes t

Re: [VOTE] Apache Kafka Release 0.8.1 - Candidate 2

2014-03-07 Thread Jun Rao
+1. Verified quickstart and unit tests. Thanks, Jun On Tue, Mar 4, 2014 at 10:59 PM, Joe Stein wrote: > This is the second candidate for release of Apache Kafka 0.8.1. > > This release candidate fixes the following two JIRA > KAFKA-1288and > K