[jira] [Commented] (KAFKA-930) Integrate preferred replica election logic into kafka

2014-02-25 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911396#comment-13911396 ] Sriram Subramanian commented on KAFKA-930: -- final changes pushed to 0.8.1 and trun

Re: [DISCUSS] 0.8.1 Release

2014-02-25 Thread Jun Rao
Hi, Joe, Both KAFKA-1271 and KAFKA-930 have been checked into the 0.8.1. branch. The only remaining thing is to update the doc. We can start the release vote and prepare the doc change in parallel. Thanks, Jun On Wed, Feb 19, 2014 at 10:38 PM, Joe Stein wrote: > sounds good, I updated JIRA t

Re: [DISCUSS] 0.8.1 Release

2014-02-25 Thread Joe Stein
Ok /*** Joe Stein Founder, Principal Consultant Big Data Open Source Security LLC http://www.stealth.ly Twitter: @allthingshadoop / On Feb 25, 2014, at 11:22 AM, Jun Rao wrote: > Hi, Joe, > > Both KAFKA-

Re: Review Request 18102: New Producer Integration Test Phase II

2014-02-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/#review35418 --- clients/src/main/java/org/apache/kafka/common/protocol/Errors.java

Re: Review Request 18102: New Producer Integration Test Phase II

2014-02-25 Thread Guozhang Wang
> On Feb. 25, 2014, 4:39 a.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 222 > > > > > > Why are we using instanceof instead of catching the individual

[jira] [Resolved] (KAFKA-1278) More flexible helper scripts

2014-02-25 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1278. Resolution: Fixed Fix Version/s: 0.8.2 Assignee: Nathan Brown Thanks for the new patch. +1

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

2014-02-25 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/#review35422 --- Could we extend ProducerSendTest to test sending/reading compressed

Re: Review Request 18102: New Producer Integration Test Phase II

2014-02-25 Thread Guozhang Wang
> On Feb. 25, 2014, 4:39 a.m., Jay Kreps wrote: > > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala, > > line 163 > > > > > > It might be simpler to do something like > > if(producer1 !

[jira] [Commented] (KAFKA-260) Add audit trail to kafka

2014-02-25 Thread Roger Hoover (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911909#comment-13911909 ] Roger Hoover commented on KAFKA-260: "It also makes false negatives possible since if y

Re: Review Request 18343: KAFKA-1250: Add logging to new Kafka producer.

2014-02-25 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18343/#review35431 --- A few remaining things that we need to take care of - 1. Adding pro

[jira] [Updated] (KAFKA-1276) Provide a list of config overrides available when running kafka.topics

2014-02-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1276: - Assignee: Jay Kreps > Provide a list of config overrides available when running kafka.topics > --

[jira] [Resolved] (KAFKA-1276) Provide a list of config overrides available when running kafka.topics

2014-02-25 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1276. Resolution: Fixed Fix Version/s: 0.8.2 This is already committed to trunk. > Provide a list of conf

[jira] [Created] (KAFKA-1280) exclude kafka-clients jar from dependant-libs dir

2014-02-25 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1280: -- Summary: exclude kafka-clients jar from dependant-libs dir Key: KAFKA-1280 URL: https://issues.apache.org/jira/browse/KAFKA-1280 Project: Kafka Issue Type: Bug Affec

Review Request 18486: Patch for KAFKA-1280

2014-02-25 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18486/ --- Review request for kafka. Bugs: KAFKA-1280 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1280) exclude kafka-clients jar from dependant-libs dir

2014-02-25 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1280: --- Attachment: KAFKA-1280.patch > exclude kafka-clients jar from dependant-libs dir > --

[jira] [Commented] (KAFKA-1280) exclude kafka-clients jar from dependant-libs dir

2014-02-25 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912196#comment-13912196 ] Jun Rao commented on KAFKA-1280: Created reviewboard https://reviews.apache.org/r/18486/

Re: Review Request 18486: Patch for KAFKA-1280

2014-02-25 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18486/#review35482 --- Ship it! Ship It! - Neha Narkhede On Feb. 25, 2014, 10:50 p.m.,

Re: Review Request 18102: New Producer Integration Test Phase II

2014-02-25 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/#review35468 --- clients/src/main/java/org/apache/kafka/clients/producer/RecordMetad

[jira] [Created] (KAFKA-1281) add the new producer to existing tools

2014-02-25 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1281: -- Summary: add the new producer to existing tools Key: KAFKA-1281 URL: https://issues.apache.org/jira/browse/KAFKA-1281 Project: Kafka Issue Type: Bug Affects Versions

[jira] [Created] (KAFKA-1282) Disconnect idle socket connection in Selector

2014-02-25 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1282: -- Summary: Disconnect idle socket connection in Selector Key: KAFKA-1282 URL: https://issues.apache.org/jira/browse/KAFKA-1282 Project: Kafka Issue Type: Bug Affects V

Re: Review Request 18102: Integration Test for New Producer: Part II

2014-02-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 26, 2014, 12:58 a.m.) Review request for kafka. Summary (update

Re: Review Request 18102: Integration Test for New Producer: Part II

2014-02-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 26, 2014, 12:59 a.m.) Review request for kafka. Bugs: KAFKA-126

[jira] [Commented] (KAFKA-1260) Integration Test for New Producer Part II: Broker Failure Handling

2014-02-25 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912347#comment-13912347 ] Guozhang Wang commented on KAFKA-1260: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1281) add the new producer to existing tools

2014-02-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1281: - Fix Version/s: 0.9.0 > add the new producer to existing tools > -

[jira] [Updated] (KAFKA-1260) Integration Test for New Producer Part II: Broker Failure Handling

2014-02-25 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1260: - Attachment: KAFKA-1260_2014-02-25_16:58:27.patch > Integration Test for New Producer Part II: Bro

[jira] [Updated] (KAFKA-1281) add the new producer to existing tools

2014-02-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1281: - Component/s: producer > add the new producer to existing tools > ---

[jira] [Updated] (KAFKA-1282) Disconnect idle socket connection in Selector

2014-02-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1282: - Fix Version/s: 0.9.0 > Disconnect idle socket connection in Selector > --

[jira] [Updated] (KAFKA-1282) Disconnect idle socket connection in Selector

2014-02-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1282: - Component/s: producer > Disconnect idle socket connection in Selector >

[jira] [Commented] (KAFKA-1227) Code dump of new producer

2014-02-25 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912363#comment-13912363 ] Jun Rao commented on KAFKA-1227: Accumulated some more review comments. 20. Regarding VIP

Re: Review Request 18102: Integration Test for New Producer: Part II

2014-02-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 26, 2014, 1:46 a.m.) Review request for kafka. Bugs: KAFKA-1260

Re: Review Request 18102: Integration Test for New Producer: Part II

2014-02-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 26, 2014, 1:46 a.m.) Review request for kafka. Bugs: KAFKA-1260

[jira] [Commented] (KAFKA-1260) Integration Test for New Producer Part II: Broker Failure Handling

2014-02-25 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912393#comment-13912393 ] Guozhang Wang commented on KAFKA-1260: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1260) Integration Test for New Producer Part II: Broker Failure Handling

2014-02-25 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1260: - Attachment: KAFKA-1260_2014-02-25_17:46:14.patch > Integration Test for New Producer Part II: Bro

[jira] [Commented] (KAFKA-1262) Producer halts on broker bounces

2014-02-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912406#comment-13912406 ] Neha Narkhede commented on KAFKA-1262: -- We saw this issue again today. > Producer ha

[jira] [Resolved] (KAFKA-1280) exclude kafka-clients jar from dependant-libs dir

2014-02-25 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1280. Resolution: Fixed Fix Version/s: 0.8.2 Thanks for the review. Committed to trunk. > exclude kafka-c

Re: Review Request 18343: KAFKA-1250: Add logging to new Kafka producer.

2014-02-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18343/#review35507 --- A bunch of other places where I used println but would love to get l

Re: Review Request 18102: Integration Test for New Producer: Part II

2014-02-25 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/#review35508 --- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProduc

[jira] [Commented] (KAFKA-1281) add the new producer to existing tools

2014-02-25 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912494#comment-13912494 ] Jay Kreps commented on KAFKA-1281: -- I mean we don't need a new version, we just need to s

Re: Review Request 18343: KAFKA-1250: Add logging to new Kafka producer.

2014-02-25 Thread Jay Kreps
> On Feb. 25, 2014, 7:14 p.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 122 > > > > > > could we also have config.logOveridden() ? We have two thin

Re: Review Request 18343: Patch for KAFKA-1250

2014-02-25 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18343/ --- (Updated Feb. 26, 2014, 5:32 a.m.) Review request for kafka. Summary (updated

[jira] [Updated] (KAFKA-1250) Add slf4j logging to new producer

2014-02-25 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1250: - Attachment: KAFKA-1250_2014-02-25_21:31:44.patch > Add slf4j logging to new producer > --

[jira] [Commented] (KAFKA-1250) Add slf4j logging to new producer

2014-02-25 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912540#comment-13912540 ] Jay Kreps commented on KAFKA-1250: -- Updated reviewboard against branch trunk > Add slf4