[jira] [Commented] (KAFKA-1081) kafka-run-class.sh is broken

2013-10-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793789#comment-13793789 ] Jun Rao commented on KAFKA-1081: Thanks for the patch. +1. Could you patch for trunk as we

Re: Review Request 14582: Upgrading zkclient to verion 0.4. Adds retry logic in case of a failed ZooKeeper session re-establishment.

2013-10-13 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14582/#review26969 --- The way that we have a ZkNonReconnector and a ZkReconnector is a bit

[jira] [Commented] (KAFKA-1082) zkclient dies after UnknownHostException in zk reconnect

2013-10-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793853#comment-13793853 ] Jun Rao commented on KAFKA-1082: Thanks for the patch. Commented on the RB. Also, we need

[jira] [Commented] (KAFKA-1084) Validate properties for custom serializers

2013-10-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793854#comment-13793854 ] Jun Rao commented on KAFKA-1084: Thanks for the patch. Do you think the patch in KAFKA-104