[jira] [Commented] (KAFKA-881) Kafka broker not respecting log.roll.hours

2013-10-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787655#comment-13787655 ] Jun Rao commented on KAFKA-881: --- How about the following: In log, maintaining an expectedRoll

[jira] [Updated] (KAFKA-1076) system tests in 0.8 are broken due to wrong log4j config

2013-10-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1076: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the review. Committed to 0.8.

[jira] [Closed] (KAFKA-1076) system tests in 0.8 are broken due to wrong log4j config

2013-10-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao closed KAFKA-1076. -- > system tests in 0.8 are broken due to wrong log4j config > --

Re: Review Request 14497: Patch for KAFKA-1075

2013-10-06 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14497/#review26712 --- With the new change, will a rebalance be triggered on a consumer whe

Re: Review Request 14496: incorporating review feedback

2013-10-06 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14496/#review26714 --- core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala

Re: Review Request 14496: incorporating review feedback

2013-10-06 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14496/#review26717 --- Ship it! Ship It! - Neha Narkhede On Oct. 5, 2013, 6:02 p.m., Ju

Re: Review Request 14496: incorporating review feedback

2013-10-06 Thread Neha Narkhede
> On Oct. 6, 2013, 8 p.m., Swapnil Ghike wrote: > > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, lines 61-65 > > > > > > Instead of asking the user to store the output of a dryrun into a JSON > > fi

Re: Review Request 14496: incorporating review feedback

2013-10-06 Thread Guozhang Wang
> On Oct. 6, 2013, 8 p.m., Swapnil Ghike wrote: > > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, lines 61-65 > > > > > > Instead of asking the user to store the output of a dryrun into a JSON > > fi