Re: Review Request 14013: Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

> On Sept. 8, 2013, 4:56 p.m., Neha Narkhede wrote: > > core/build.sbt, line 26 > > > > > > Does Scala 2.10 require scalatest 1.9.1? > > How about Scala 2.9.x ? There wasn't a 2.10 build of scalatest version 1.8 s

[jira] [Commented] (KAFKA-1050) Support for "no data loss" mode

[ https://issues.apache.org/jira/browse/KAFKA-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761970#comment-13761970 ] Neha Narkhede commented on KAFKA-1050: -- For 2, we have KAFKA-1028 filed and I had som

Re: Review Request 14013: Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14013/#review25992 --- Ship it! Ship It! - Neha Narkhede On Sept. 9, 2013, 12:40 a.m.,

[jira] [Work started] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-1028 started by Neha Narkhede. > per topic configuration of preference for consistency over availability > -

[jira] [Updated] (KAFKA-1046) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

[ https://issues.apache.org/jira/browse/KAFKA-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1046: - Attachment: Screen Shot 2013-09-09 at 9.34.09 AM.png Intellij throws errors while compiling Annot

Re: Review Request 14013: Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

> On Sept. 8, 2013, 10:47 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/utils/Annotations_2.9+.scala, lines 1-38 > > > > > > How does this affect IDEs like Intellij? Are you able to build the > > project in IDE wit

[jira] [Commented] (KAFKA-1036) Unable to rename replication offset checkpoint in windows

[ https://issues.apache.org/jira/browse/KAFKA-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762052#comment-13762052 ] Timothy Chen commented on KAFKA-1036: - Hi Jun, I just realized I don't have clearance

Re: Patch for mmap + windows

Btw, I've been running this patch in our cloud env and it's been working fine so far. I actually filed another bug as I saw another problem on windows locally ( https://issues.apache.org/jira/browse/KAFKA-1036). Tim On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps wrote: > That would be great! > >

Re: Patch for mmap + windows

So guys, do we want to do these in 0.8? The first patch was a little involved but I think it would be good to have windows support in 0.8 and it sounds like Tim is able to get things working after these changes. -Jay On Mon, Sep 9, 2013 at 10:19 AM, Timothy Chen wrote: > Btw, I've been running

Re: Review Request 14013: Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

> On Sept. 8, 2013, 4:56 p.m., Neha Narkhede wrote: > > core/build.sbt, line 26 > > > > > > Does Scala 2.10 require scalatest 1.9.1? > > How about Scala 2.9.x ? > > Christopher Freeman wrote: > There wasn't a

[jira] Subscription: outstanding kafka patches

Issue Subscription Filter: outstanding kafka patches (71 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1046 Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1050) Support for "no data loss" mode

[ https://issues.apache.org/jira/browse/KAFKA-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762070#comment-13762070 ] Jay Kreps commented on KAFKA-1050: -- Hey Justin, yeah the two things I wanted to clarify:

[jira] [Commented] (KAFKA-1049) Encoder implementations are required to provide an undocumented constructor.

[ https://issues.apache.org/jira/browse/KAFKA-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762193#comment-13762193 ] Jay Kreps commented on KAFKA-1049: -- I agree that an init() method avoids the non-type-che

[jira] [Commented] (KAFKA-1049) Encoder implementations are required to provide an undocumented constructor.

[ https://issues.apache.org/jira/browse/KAFKA-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762209#comment-13762209 ] Jason Rosenberg commented on KAFKA-1049: Perhaps it would be cleaner to have the a

Review Request 14041: KAFKA-1030

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14041/ --- Review request for kafka. Repository: kafka Description --- Using the ap

[jira] [Updated] (KAFKA-1046) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

[ https://issues.apache.org/jira/browse/KAFKA-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Freeman updated KAFKA-1046: --- Attachment: (was: kafka_2_10_refactor_0.8.patch) > Added support for Scala 2.

[jira] [Updated] (KAFKA-1046) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

[ https://issues.apache.org/jira/browse/KAFKA-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Freeman updated KAFKA-1046: --- Attachment: kafka_2_10_refactor_0.8.patch > Added support for Scala 2.10 builds w

Re: Patch for mmap + windows

+1 for windows support on 0.8 Thanks, Neha On Mon, Sep 9, 2013 at 10:48 AM, Jay Kreps wrote: > So guys, do we want to do these in 0.8? The first patch was a little > involved but I think it would be good to have windows support in 0.8 and it > sounds like Tim is able to get things working afte

[jira] [Commented] (KAFKA-1046) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

[ https://issues.apache.org/jira/browse/KAFKA-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762380#comment-13762380 ] Neha Narkhede commented on KAFKA-1046: -- Chris helped figure out how to get the Intell

Re: Review Request 14041: KAFKA-1030

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14041/ --- (Updated Sept. 9, 2013, 9:30 p.m.) Review request for kafka. Repository: kafk

Re: Review Request 14041: KAFKA-1030

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14041/ --- (Updated Sept. 9, 2013, 9:30 p.m.) Review request for kafka. Bugs: KAFKA-1030

Re: Review Request 14041: MetadataResponse during Consumer's Rebalance Process maybe Stale

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14041/ --- (Updated Sept. 9, 2013, 9:31 p.m.) Review request for kafka. Summary (updated

Re: review board is available

Same concern. It seems that ReviewBoard would not, say, mark the JIRA as patch available when request is published. Does that mean we have to keep doing this manually still? Guozhang On Sun, Sep 8, 2013 at 10:04 AM, Neha Narkhede wrote: > This is great. So far I reviewed 2 patches using reviewb

Re: Patch for mmap + windows

Cool can we get a reviewer for KAFKA-1008 then? I can take on the other issue for the checkpoint files. -Jay On Mon, Sep 9, 2013 at 3:16 PM, Neha Narkhede wrote: > +1 for windows support on 0.8 > > Thanks, > Neha > > > On Mon, Sep 9, 2013 at 10:48 AM, Jay Kreps wrote: > > > So guys, do we want

Re: Patch for mmap + windows

I did take a look at KAFKA-1008 a while back and added some comments. On 9/9/13 3:52 PM, "Jay Kreps" wrote: >Cool can we get a reviewer for KAFKA-1008 then? I can take on the other >issue for the checkpoint files. > >-Jay > > >On Mon, Sep 9, 2013 at 3:16 PM, Neha Narkhede >wrote: > >> +1 for win

Re: Review Request 14041: MetadataResponse during Consumer's Rebalance Process maybe Stale

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14041/#review26005 --- core/src/main/scala/kafka/client/ClientUtils.scala

Re: Review Request 14041: MetadataResponse during Consumer's Rebalance Process maybe Stale

> On Sept. 9, 2013, 11:44 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/client/ClientUtils.scala, line 100 > > > > > > The concern I have with this change is the potential performance hit to > > the consume

Re: Patch for mmap + windows

Hi Sriram, If Elizabeth isn't able to respond to your feedback, I wonder if you can fix the patch and apply it? It will be great to have this patch in 0.8. Thanks, Tim On Mon, Sep 9, 2013 at 3:56 PM, Sriram Subramanian < srsubraman...@linkedin.com> wrote: > I did take a look at KAFKA-1008 a

Re: Patch for mmap + windows

I think Srirams complaint is that I haven't yet addressed his concerns :-) Sent from my iPhone On Sep 9, 2013, at 3:56 PM, Sriram Subramanian wrote: > I did take a look at KAFKA-1008 a while back and added some comments. > > On 9/9/13 3:52 PM, "Jay Kreps" wrote: > >> Cool can we get a revie

Re: review board is available

Yeah the lack of integration is kind of maddening if you have ever used github. My recommendation is that we treat Review Board as just a patch viewer and discussion tool. In other words you must have a JIRA and a link to the appropriate review board there. We should make no effort to use review b

Re: Review Request 14041: MetadataResponse during Consumer's Rebalance Process maybe Stale

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14041/#review26012 --- core/src/main/scala/kafka/client/ClientUtils.scala