Re: Client improvement discussion

2013-08-03 Thread Chris Hogue
Hi Jay. Agreed, we're planning to try to do the compression before the producer with 0.8 as we get back to this part, hopefully this week. I saw your other JIRA issue about the copying in the code path so that looks promising as well. Thanks for all the responses, really appreciate the effort and

[jira] [Commented] (KAFKA-881) Kafka broker not respecting log.roll.hours

2013-08-03 Thread Dan F (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728571#comment-13728571 ] Dan F commented on KAFKA-881: - Sam: Thanks for that. It would be comforting to know if/when we

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2013-08-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728575#comment-13728575 ] Jay Kreps commented on KAFKA-527: - The general idea of the refactoring would be to allow di

[jira] [Commented] (KAFKA-996) Capitalize first letter for log entries

2013-08-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728577#comment-13728577 ] Jay Kreps commented on KAFKA-996: - +1 but can we apply this on trunk? We are trying to mini

[jira] [Closed] (KAFKA-994) High level consumer doesn't throw an exception when the message it is trying to fetch exceeds the configured fetch size

2013-08-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps closed KAFKA-994. --- > High level consumer doesn't throw an exception when the message it is trying > to fetch exceeds the configu

[jira] [Commented] (KAFKA-992) Double Check on Broker Registration to Avoid False NodeExist Exception

2013-08-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728583#comment-13728583 ] Jay Kreps commented on KAFKA-992: - This is good, this can go on trunk, right?

[jira] [Updated] (KAFKA-995) Enforce that the value for replica.fetch.max.bytes is always >= the value for message.max.bytes

2013-08-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-995: Fix Version/s: 0.8.1 > Enforce that the value for replica.fetch.max.bytes is always >= the value for >

[jira] [Commented] (KAFKA-995) Enforce that the value for replica.fetch.max.bytes is always >= the value for message.max.bytes

2013-08-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728585#comment-13728585 ] Jay Kreps commented on KAFKA-995: - Committed on trunk. > Enforce that the

[jira] [Resolved] (KAFKA-985) Increasing log retention quickly overflows scala Int

2013-08-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-985. - Resolution: Fixed Fix Version/s: (was: 0.9) 0.8.1 Ack, nice catch.

[jira] [Commented] (KAFKA-984) Avoid a full rebalance in cases when a new topic is discovered but container/broker set stay the same

2013-08-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728597#comment-13728597 ] Jay Kreps commented on KAFKA-984: - Guys I don't think we should be doing massive surgery on

[jira] [Commented] (KAFKA-984) Avoid a full rebalance in cases when a new topic is discovered but container/broker set stay the same

2013-08-03 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728601#comment-13728601 ] Sriram Subramanian commented on KAFKA-984: -- Agreed. I share the same thought and h

[jira] [Updated] (KAFKA-718) kafka-run-class.sh should use reasonable gc settings

2013-08-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-718: Attachment: KAFKA-718-v4.patch New patch. Rebased. Fixed logging in tools so that we no longer spew crazy lo

Two patches needing review

2013-08-03 Thread Jay Kreps
This is a set of good housekeeping things for 0.8 open source release: https://issues.apache.org/jira/browse/KAFKA-718 This is just a small set of trivial cleanups that are very visible: - Fix logging for tools so we don't spew log messages in with tool output - Fix GC settings so we don't default

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-08-03 Thread stephen samuel (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728695#comment-13728695 ] stephen samuel commented on KAFKA-717: -- I've forked Kafka and patched 0.8 client code

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-08-03 Thread Rob Withers (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728704#comment-13728704 ] Rob Withers commented on KAFKA-717: --- I just realized that this is as it should be. The b