Sam Meder created KAFKA-994:
---
Summary: High level consumer doesn't throw an exception when the
message it is trying to fetch exceeds the configured fetch size
Key: KAFKA-994
URL: https://issues.apache.org/jira/browse/KA
We put together a test case that showws the exception is never thrown. I looked
into it a bit more and filed https://issues.apache.org/jira/browse/KAFKA-994
which has the details.
/Sam
On Aug 1, 2013, at 7:03 AM, Jun Rao wrote:
> If you look at ConsumerIterator, we will throw MessageSizeTooLa
Seems like a good idea to enforce this? Maybe something like this:
diff --git a/core/src/main/scala/kafka/server/KafkaConfig.scala
b/core/src/main/scala/kafka/server/KafkaConfig.scala
index a64b210..1c3bfdd 100644
--- a/core/src/main/scala/kafka/server/KafkaConfig.scala
+++ b/core/src/main/scala/
Yes. It's good to enforce that. Could you file a jira and attach your patch
there?
Thanks,
Jun
On Thu, Aug 1, 2013 at 7:39 AM, Sam Meder wrote:
> Seems like a good idea to enforce this? Maybe something like this:
>
> diff --git a/core/src/main/scala/kafka/server/KafkaConfig.scala
> b/core/src/
[
https://issues.apache.org/jira/browse/KAFKA-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Meder updated KAFKA-994:
Description:
The high level consumer code is supposed to throw an exception when it
encounters a message th
[
https://issues.apache.org/jira/browse/KAFKA-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Meder updated KAFKA-994:
Fix Version/s: 0.8
Status: Patch Available (was: Open)
> High level consumer doesn't throw a
[
https://issues.apache.org/jira/browse/KAFKA-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Meder updated KAFKA-994:
Attachment: messageSize.patch
> High level consumer doesn't throw an exception when the message it is tr
Sam Meder created KAFKA-995:
---
Summary: Enforce that the value for replica.fetch.max.bytes is
always >= the value for message.max.bytes
Key: KAFKA-995
URL: https://issues.apache.org/jira/browse/KAFKA-995
Pro
[
https://issues.apache.org/jira/browse/KAFKA-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Meder updated KAFKA-995:
Status: Patch Available (was: Open)
> Enforce that the value for replica.fetch.max.bytes is always >= t
[
https://issues.apache.org/jira/browse/KAFKA-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Meder updated KAFKA-995:
Attachment: replica_fetch_size_config.patch
> Enforce that the value for replica.fetch.max.bytes is alwa
[
https://issues.apache.org/jira/browse/KAFKA-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726525#comment-13726525
]
Jun Rao commented on KAFKA-994:
---
Thanks for filing this jira. Looks like a real issue. Just c
[
https://issues.apache.org/jira/browse/KAFKA-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726535#comment-13726535
]
Sam Meder commented on KAFKA-994:
-
Yea, I realized that after the initial write-up, the att
[
https://issues.apache.org/jira/browse/KAFKA-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726536#comment-13726536
]
Jay Kreps commented on KAFKA-994:
-
Ack, nice catch.
> High level consumer
[
https://issues.apache.org/jira/browse/KAFKA-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-996:
Attachment: KAFKA-996.v1.patch
Need to be rebased once 0.8 fixes are merged to trunk.
Guozhang Wang created KAFKA-996:
---
Summary: Capitalize first letter for log entries
Key: KAFKA-996
URL: https://issues.apache.org/jira/browse/KAFKA-996
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-996:
Status: Patch Available (was: Open)
> Capitalize first letter for log entries
> ---
[
https://issues.apache.org/jira/browse/KAFKA-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726576#comment-13726576
]
Guozhang Wang commented on KAFKA-967:
-
Jun, before this patch each message will use a d
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-992:
Attachment: KAFKA-992.v2.patch
Unit tests passed
> Double Check on Broker Registrat
Issue Subscription
Filter: outstanding kafka patches (70 issues)
The list of outstanding kafka patches
Subscriber: kafka-mailing-list
Key Summary
KAFKA-996 Capitalize first letter for log entries
https://issues.apache.org/jira/browse/KAFKA-996
KAFKA-995 Enforce that
[
https://issues.apache.org/jira/browse/KAFKA-881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Meder updated KAFKA-881:
Attachment: kafka-roll-0.8.patch
> Kafka broker not respecting log.roll.hours
>
[
https://issues.apache.org/jira/browse/KAFKA-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726789#comment-13726789
]
Sam Meder commented on KAFKA-881:
-
Attached a version of this patch that applies against 0.
[
https://issues.apache.org/jira/browse/KAFKA-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726891#comment-13726891
]
Jay Kreps commented on KAFKA-991:
-
+1
> Reduce the queue size in hadoop pr
[
https://issues.apache.org/jira/browse/KAFKA-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726955#comment-13726955
]
Swapnil Ghike commented on KAFKA-991:
-
Also reviewed by Jun, Neha. The reason why we us
[
https://issues.apache.org/jira/browse/KAFKA-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726958#comment-13726958
]
Joel Koshy commented on KAFKA-991:
--
+1
Committed to 0.8
Minor comment:
- queue size is u
+1 296 (changing my vote from the one in the jira)
On Wed, Jul 31, 2013 at 10:00 PM, Jun Rao wrote:
> +1 for 296
>
> Thanks,
>
> Jun
>
>
> On Wed, Jul 31, 2013 at 1:34 PM, Jay Kreps wrote:
>
>> Okay folks we did a survey on the JIRA (KAFKA-982) and it was more or less
>> a tie between two logos:
[
https://issues.apache.org/jira/browse/KAFKA-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil Ghike updated KAFKA-991:
Attachment: kafka-991-followup.patch
> Reduce the queue size in hadoop producer
> --
[
https://issues.apache.org/jira/browse/KAFKA-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726995#comment-13726995
]
Swapnil Ghike commented on KAFKA-991:
-
Thanks Joel. Would you mind committing the follo
[
https://issues.apache.org/jira/browse/KAFKA-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil Ghike updated KAFKA-991:
Attachment: kafka-991-followup-v2.patch
Fixed README.
> Reduce the queue size in ha
[
https://issues.apache.org/jira/browse/KAFKA-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13727092#comment-13727092
]
Joel Koshy commented on KAFKA-991:
--
Thanks for the follow-up patch. totalBytes is set to z
[
https://issues.apache.org/jira/browse/KAFKA-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil Ghike updated KAFKA-991:
Attachment: kafka-991-followup-3.patch
Thanks, attached a new patch to address that.
I am changing my vote too
+1 296
It's an awesome logo and looks better on the web page
/***
Joe Stein
Founder, Principal Consultant
Big Data Open Source Security LLC
http://www.stealth.ly
Twitter: @allthingshadoop
*
[
https://issues.apache.org/jira/browse/KAFKA-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-991:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Reduce the queue size in hadoop p
[
https://issues.apache.org/jira/browse/KAFKA-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy closed KAFKA-991.
+1
Committed to 0.8
> Reduce the queue size in hadoop producer
> -
Cool, I think it is (nearly) unanimous and we have the whole PMC except for
Jakob who is on vacation. So I am calling it for 296.
-Jay
On Thu, Aug 1, 2013 at 5:08 PM, Joe Stein wrote:
> I am changing my vote too
>
> +1 296
>
> It's an awesome logo and looks better on the web page
>
> /
[
https://issues.apache.org/jira/browse/KAFKA-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-994:
--
Resolution: Fixed
Assignee: Sam Meder (was: Neha Narkhede)
Status: Resolved (was: Patch Available
35 matches
Mail list logo
