[jira] [Commented] (KAFKA-905) Logs can have same offsets causing recovery failure

2013-05-31 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671553#comment-13671553 ] Jun Rao commented on KAFKA-905: --- Thanks for the patch. Looks good. Some minor comments: 1. L

[jira] [Commented] (KAFKA-921) Expose max lag mbean for consumers and replica fetchers

2013-05-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671593#comment-13671593 ] Neha Narkhede commented on KAFKA-921: - +1 on patch v3. > Expose max l

[jira] [Commented] (KAFKA-927) Integrate controlled shutdown into kafka shutdown hook

2013-05-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671595#comment-13671595 ] Neha Narkhede commented on KAFKA-927: - Sriram, This patch doesn't compile with the fol

[jira] [Commented] (KAFKA-927) Integrate controlled shutdown into kafka shutdown hook

2013-05-31 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671608#comment-13671608 ] Jun Rao commented on KAFKA-927: --- Thanks for the patch. Overall, a well thought-out patch. Som

[jira] [Commented] (KAFKA-927) Integrate controlled shutdown into kafka shutdown hook

2013-05-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671633#comment-13671633 ] Neha Narkhede commented on KAFKA-927: - Thanks for the patch, very well thought out! Few

[jira] [Commented] (KAFKA-905) Logs can have same offsets causing recovery failure

2013-05-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671678#comment-13671678 ] Neha Narkhede commented on KAFKA-905: - Great catch, patch looks good except the new exc

[jira] [Closed] (KAFKA-921) Expose max lag mbean for consumers and replica fetchers

2013-05-31 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-921. > Expose max lag mbean for consumers and replica fetchers >

[jira] [Updated] (KAFKA-921) Expose max lag mbean for consumers and replica fetchers

2013-05-31 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-921: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the reviews. Committed with

[jira] [Commented] (KAFKA-903) [0.8.0 - windows] FATAL - [highwatermark-checkpoint-thread1] (Logging.scala:109) - Attempt to swap the new high watermark file with the old one failed

2013-05-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671688#comment-13671688 ] Neha Narkhede commented on KAFKA-903: - +1 on v3 > [0.8.0 - windows] F

[jira] [Commented] (KAFKA-905) Logs can have same offsets causing recovery failure

2013-05-31 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671741#comment-13671741 ] Jay Kreps commented on KAFKA-905: - This patch looks good. One thing worth pointing out is t

[jira] [Resolved] (KAFKA-837) Add 0.7->0.8 migration steps doc

2013-05-31 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian resolved KAFKA-837. -- Resolution: Fixed > Add 0.7->0.8 migration steps doc > -

[jira] [Commented] (KAFKA-927) Integrate controlled shutdown into kafka shutdown hook

2013-05-31 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671922#comment-13671922 ] Sriram Subramanian commented on KAFKA-927: -- Thank you for the review guys. Jun -

[jira] [Updated] (KAFKA-927) Integrate controlled shutdown into kafka shutdown hook

2013-05-31 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian updated KAFKA-927: - Attachment: KAFKA-927-v2.patch > Integrate controlled shutdown into kafka shutdown hoo

[jira] [Created] (KAFKA-928) new topics may not be processed after ZK session expiration in controller

2013-05-31 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-928: - Summary: new topics may not be processed after ZK session expiration in controller Key: KAFKA-928 URL: https://issues.apache.org/jira/browse/KAFKA-928 Project: Kafka Issu