You can amend the previous commit (as long as you havent pushed) with an
author like "git --amend --author='...'"
On Saturday, January 5, 2013, Joe Stein wrote:
> I am getting the no email after doing
>
> git am --signoff < xyz.patch
>
> so nothing gets in to commit to set the author :(
>
> On Sa
that did not work either
I can't even get the patch to apply from the latest trunk because of this
message of patch without email
so the patch is here
https://issues.apache.org/jira/secure/attachment/12563266/KAFKA-133.patch
I go through the steps on the git workflow
git clone https://git-wip-u
Ok, I figured out the problem. The problem was with the patch format so I
will take care of that ... the patch is minor enough I will take the code
changes and whip up a new patch and let Maxime know (assuming that patch is
good) about how to make a Kafka patch moving forward).
I noticed the incu
ok with some more research today it seems the difference and issues I was
having was from the patch being made with
git diff vs git format-patch
with git diff (which is how the patch I was reviewing was made) you apply
doing "patch -p1 < patch"
no commits messages are preserved with git diff. I
[
https://issues.apache.org/jira/browse/KAFKA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545331#comment-13545331
]
Joe Stein commented on KAFKA-133:
-
this looks really good so far I was able to get ./sbt pu
Where do we feel we are with 0.8 ? I ask because this ticket might be a
good reason for a 0.7.3 release and patching 0.7.2 with this ticket does
not seem like much.
There are still a few to-dos on this but it looks like from what I just
went through that it is almost over the goal line entirely.
