Re: reviewer for KAFKA-1028

2014-03-14 Thread Jay Kreps
Done, left a quick question for you. On Fri, Mar 14, 2014 at 1:11 PM, Neha Narkhede wrote: > Jay, > > It will be good if you take a quick look at > https://issues.apache.org/jira/browse/KAFKA-1028 as well. It leaks a > replication per topic config into the log. Other than that, the patch is > re

Re: reviewer for KAFKA-1028

2014-03-14 Thread Neha Narkhede
Jay, It will be good if you take a quick look at https://issues.apache.org/jira/browse/KAFKA-1028 as well. It leaks a replication per topic config into the log. Other than that, the patch is ready for checkin Thanks, Neha On Thu, Mar 13, 2014 at 1:34 PM, Neha Narkhede wrote: > I've been review

Re: reviewer for KAFKA-1028

2014-03-13 Thread Neha Narkhede
I've been reviewing it so far but haven't gotten a chance to look at this last week. Will take a look today. On Thu, Mar 13, 2014 at 12:16 PM, Jay Kreps wrote: > Do we have a reviewer for > https://issues.apache.org/jira/browse/KAFKA-1028 > > -Jay >

reviewer for KAFKA-1028

2014-03-13 Thread Jay Kreps
Do we have a reviewer for https://issues.apache.org/jira/browse/KAFKA-1028 -Jay