Re: review board is available

Hooray! Thanks Neha. Guozhang On Wed, Sep 11, 2013 at 10:50 AM, Neha Narkhede wrote: > I wrote a wrapper script that will update the jira as well as the > reviewboard. So the proposed new patch review process will be - > > 1. Create JIRA > 2. Make code changes and commit to local branch > 3. Us

Re: review board is available

Thanks for the review. I created a JIRA to track this - https://issues.apache.org/jira/browse/KAFKA-1053. Will be great if you can add your comments there. Thanks, Neha On Wed, Sep 11, 2013 at 11:28 AM, Tejas Patil wrote: > This is cool !!! I can't wait to use it. > > Some comments: > > (1) In

Re: review board is available

I wrote a wrapper script that will update the jira as well as the reviewboard. So the proposed new patch review process will be - 1. Create JIRA 2. Make code changes and commit to local branch 3. Use patch review tool

Re: review board is available

This is cool !!! I can't wait to use it. Some comments: (1) In [0], "Setup" -> hyperlinks on steps 1 and 2 loop to the same webpage. (2) I don't have much idea about the right place where the ".reviewboardrc" file should be, but it would be a good idea to commit it in the codebase like [1]. Also

Re: review board is available

Yeah the lack of integration is kind of maddening if you have ever used github. My recommendation is that we treat Review Board as just a patch viewer and discussion tool. In other words you must have a JIRA and a link to the appropriate review board there. We should make no effort to use review b

Re: review board is available

Same concern. It seems that ReviewBoard would not, say, mark the JIRA as patch available when request is published. Does that mean we have to keep doing this manually still? Guozhang On Sun, Sep 8, 2013 at 10:04 AM, Neha Narkhede wrote: > This is great. So far I reviewed 2 patches using reviewb

Re: review board is available

This is great. So far I reviewed 2 patches using reviewboard and it is a huge time saver. I have one question about the setup though - the reviewboard has a Bugs field that takes in the JIRA, can it update the respective JIRA with the reviewboard link ? The concern is that with more reviews coming

review board is available

Okay I got review board set up. I'm not wedded to this tool, but it's pretty simple so let's give it a try and if it sucks we can switch to phabricator or something else. I wrote up instructions on how to use it here: https://cwiki.apache.org/confluence/display/KAFKA/Review+Board If anyone has be