Re: producer rewrite

Same here: +1 on checking in as is. I should be able to go through the patch on Monday. On Fri, Jan 24, 2014 at 01:48:14PM -0800, Neha Narkhede wrote: > I plan to review the code over the weekend and I think it is easier to > address the review comments async. +1 for checking it in as is for now.

Re: producer rewrite

I plan to review the code over the weekend and I think it is easier to address the review comments async. +1 for checking it in as is for now. Thanks, Neha On Fri, Jan 24, 2014 at 1:36 PM, Jay Kreps wrote: > So folks there are some comments on the RB, I take it from this discussion > people ar

Re: producer rewrite

So folks there are some comments on the RB, I take it from this discussion people are cool with me just checking in what I have and addressing the comments asynchronously? If no objection I will do that. -Jay On Thu, Jan 23, 2014 at 12:56 PM, Jay Kreps wrote: > Cool, I've uploaded a patch and

Re: producer rewrite

The JIRA has the patch and the RB is for comments. -Jay On Fri, Jan 24, 2014 at 9:00 AM, S Ahmed wrote: > Thanks. This is the page correct? > https://reviews.apache.org/r/17263/diff/raw/ > > I was hoping I could download the code and run it locally not just view it. > > > On Thu, Jan 23, 2014

Re: producer rewrite

Thanks. This is the page correct? https://reviews.apache.org/r/17263/diff/raw/ I was hoping I could download the code and run it locally not just view it. On Thu, Jan 23, 2014 at 8:02 PM, Neha Narkhede wrote: > There is a link to the reviewboard url on the > JIRA

Re: producer rewrite

There is a link to the reviewboard url on the JIRAmentioned above. That will take you to the patch. On Thu, Jan 23, 2014 at 4:49 PM, S Ahmed wrote: > Sorry I'm new to o/s, how can I look at this patch? > > Would it be mirrored here? https://gith

Re: producer rewrite

Sorry I'm new to o/s, how can I look at this patch? Would it be mirrored here? https://github.com/apache/kafka On Thu, Jan 23, 2014 at 3:56 PM, Jay Kreps wrote: > Cool, I've uploaded a patch and rb here: > https://issues.apache.org/jira/browse/KAFKA-1227 > > -Jay > > > On Thu, Jan 23, 2014 at

Re: producer rewrite

Cool, I've uploaded a patch and rb here: https://issues.apache.org/jira/browse/KAFKA-1227 -Jay On Thu, Jan 23, 2014 at 12:00 PM, Joe Stein wrote: > awesome! +1 for checking this in as is as you suggest > > /*** > Joe Stein > Founder, Principal Consulta

Re: producer rewrite

awesome! +1 for checking this in as is as you suggest /*** Joe Stein Founder, Principal Consultant Big Data Open Source Security LLC http://www.stealth.ly Twitter: @allthingshadoop ***

Re: producer rewrite

This approach sounds reasonable to me. Since the new code will be not be used in the current kafka jar, we can still release 0.8.1 off trunk when it's ready. Thanks, Jun On Thu, Jan 23, 2014 at 10:23 AM, Jay Kreps wrote: > Hey all, > > I have been working on a rewrite of the producer as descr

Re: producer rewrite

+1 for checking this in as is. For a from-scratch rewrite like this, I prefer to do incremental reviews on a standalone subproject until it is complete and stable to be merged into the main codebase. Looking forward to the patch! Thanks, Neha On Thu, Jan 23, 2014 at 10:23 AM, Jay Kreps wrote:

producer rewrite

Hey all, I have been working on a rewrite of the producer as described in the wiki below and discussed in a few previous threads: https://cwiki.apache.org/confluence/display/KAFKA/Client+Rewrite My code is still has some bugs and is a bit rough in parts, but it functions in the basic cases. I did