Re: newbie: PR 11955 review

2022-03-31 Thread Rajani Karuturi
Tests failed again. :( Is everyone facing this problem? I tried to look at the cause for the test failures but couldn’t find any. Is it possible to review and merge this? It’s a pretty small fix. Thanks, On Thu, 31 Mar 2022 at 8:24 PM, Adam Bellemare wrote: > Thanks Bruno :) > > On Thu, Mar

Re: newbie: PR 11955 review

2022-03-31 Thread Adam Bellemare
Thanks Bruno :) On Thu, Mar 31, 2022 at 10:09 AM Bruno Cadonna wrote: > Hi Rajani and Adam, > > I do not think "retest this" or any other comment works for > non-committers anymore. > > Rajani, the failures seem to be flaky tests since they are unrelated to > your change. Could you please look i

Re: newbie: PR 11955 review

2022-03-31 Thread Bruno Cadonna
Hi Rajani and Adam, I do not think "retest this" or any other comment works for non-committers anymore. Rajani, the failures seem to be flaky tests since they are unrelated to your change. Could you please look into JIRA for the flaky tests? You should find tickets that start with "Flaky tes

Re: newbie: PR 11955 review

2022-03-31 Thread Adam Bellemare
It could be an intermittent error. I think there is a way to issue a retest via a comment in github ("retest this") but I am not sure if that's the precise command, nor if you will have the ability to kick it off. On Thu, Mar 31, 2022 at 9:12 AM Rajani Karuturi wrote: > Hi All, > I am new here

newbie: PR 11955 review

2022-03-31 Thread Rajani Karuturi
Hi All, I am new here. To get started, I took one of the "newbie" issues and made changes for the same. Issue: https://issues.apache.org/jira/browse/KAFKA-12380 PR: https://github.com/apache/kafka/pull/11955 PR build shows some test failures but the same pass on my local. The change is very isola