Re: kafka pull request: Unmap before resizing

2013-07-25 Thread Jay Kreps
Hi, can you file a JIRA and attach the patch there? This does the Apache copyright stuff... Instructions here: http://kafka.apache.org/contributing.html This seems like a good thing to have. Is there a more portable way to do this? Obviously this would not work on a non-sun JVM. I think the ideal

kafka pull request: Unmap before resizing

2013-07-25 Thread lizziew
GitHub user lizziew opened a pull request: https://github.com/apache/kafka/pull/6 Unmap before resizing While I was studying how MappedByteBuffer works, I saw a sharing runtime exception on Windows. I applied what I learned to generate a patch which uses an internal open JDK API to