Re: git workflow

2013-01-07 Thread Derek Chen-Becker
gt;> the only thing I did notice is that the commit message I put in "as > a > > >>>> contributor" was part of the patch and everything so I think we > should > > >>>> > > >>> call > > >>> > > >>>>

Re: git workflow

2013-01-07 Thread Jay Kreps
ommit messages, like always put the > >>>> KAFKA-XYZ in the message so when we review and push everything goes in > >>>> > >>> how > >>> > >>>> we expected if we made the change and committed ourselves. > >>>> > &g

Re: git workflow

2013-01-07 Thread Derek Chen-Becker
ways put the >>>> KAFKA-XYZ in the message so when we review and push everything goes in >>>> >>> how >>> >>>> we expected if we made the change and committed ourselves. >>>> >>>> I just could not let it go, now I am going

Re: git workflow

2013-01-07 Thread David Arthur
f patch without email so the patch is here https://issues.apache.org/jira/secure/attachment/12563266/KAFKA-133.patch I go through the steps on the git workflow git clone https://git-wip-us.apache.org/repos/asf/kafka.git kafka cd kafka git fetch git checkout trunk //already on trunk gi

Re: git workflow

2013-01-06 Thread Derek Chen-Becker
t; > > > > > On Sat, Jan 5, 2013 at 1:42 PM, Joe Stein wrote: > > > >> that did not work either > >> > >> I can't even get the patch to apply from the latest trunk because of > this > >> message of patch without email > >&

Re: git workflow

2013-01-05 Thread Joe Stein
=8^) > > > On Sat, Jan 5, 2013 at 1:42 PM, Joe Stein wrote: > >> that did not work either >> >> I can't even get the patch to apply from the latest trunk because of this >> message of patch without email >> >> so the patch is here >> ht

Re: git workflow

2013-01-05 Thread Joe Stein
> > > > Jun >> > > > > >> > > > > On Wed, Jan 2, 2013 at 1:45 PM, Jay Kreps > > >> > wrote: >> > > > > >> > > > > > I don't know about other people but I find git kind of >>

Re: git workflow

2013-01-05 Thread Joe Stein
that did not work either I can't even get the patch to apply from the latest trunk because of this message of patch without email so the patch is here https://issues.apache.org/jira/secure/attachment/12563266/KAFKA-133.patch I go through the steps on the git workflow git clone https://gi

Re: git workflow

2013-01-05 Thread David Arthur
> > I don't know about other people but I find git kind of confusing. I > > > > thought > > > > > it would be useful to try to document the normal workflow for > > different > > > > use > > > > > cases: > > > > &

Re: git workflow

2013-01-04 Thread Joe Stein
would be useful to try to document the normal workflow for > different > > > use > > > > cases: > > > > 1. Contributing a patch > > > > 2. Reviewing and integrating a patch that is contributed > > > > 3. Doing development as a committer

Re: git workflow

2013-01-04 Thread Jay Kreps
eful to try to document the normal workflow for different > > use > > > cases: > > > 1. Contributing a patch > > > 2. Reviewing and integrating a patch that is contributed > > > 3. Doing development as a committer > > > 4. Keeping a copy of your local

Re: git workflow

2013-01-04 Thread Joe Stein
on github (since it doesn't seem > > Apache has a place to keep local backups of work in progress). > > > > https://cwiki.apache.org/confluence/display/KAFKA/Git+Workflow > > > > I would like to link this up from the contributor page to help people > > (incl

Re: git workflow

2013-01-03 Thread Jun Rao
ess). > > https://cwiki.apache.org/confluence/display/KAFKA/Git+Workflow > > I would like to link this up from the contributor page to help people > (including my future self). Objections? > > I am not a git expert, so any feedback to improve these recipes or bug > f

Re: git workflow

2013-01-02 Thread David Arthur
al workflow for different use cases: 1. Contributing a patch 2. Reviewing and integrating a patch that is contributed 3. Doing development as a committer 4. Keeping a copy of your local work on github (since it doesn't seem Apache has a place to keep local backups of work in progress). https:/

Re: git workflow

2013-01-02 Thread Jay Kreps
ter >> 4. Keeping a copy of your local work on github (since it doesn't seem >> Apache has a place to keep local backups of work in progress). >> >> https://cwiki.apache.org/**confluence/display/KAFKA/Git+**Workflow<https://cwiki.apache.org/confluence/display/KAFKA/

Re: git workflow

2013-01-02 Thread David Arthur
Keeping a copy of your local work on github (since it doesn't seem Apache has a place to keep local backups of work in progress). https://cwiki.apache.org/confluence/display/KAFKA/Git+Workflow I would like to link this up from the contributor page to help people (including my future self). Obje

git workflow

2013-01-02 Thread Jay Kreps
py of your local work on github (since it doesn't seem Apache has a place to keep local backups of work in progress). https://cwiki.apache.org/confluence/display/KAFKA/Git+Workflow I would like to link this up from the contributor page to help people (including my future self). Objections?