Re: code layout

2014-02-04 Thread Jun Rao
Since we don't really have an admin api (just standalone tools), perhaps we can start with option A. We can potentially add an admin (or tools) jar in the future when we expose programming apis for admin. Thanks, Jun On Sun, Feb 2, 2014 at 9:59 PM, Jay Kreps wrote: > Yes, this is a good point

Re: code layout

2014-02-03 Thread Steve Morin
That's why I was thinking c) makes sense from a design perspective. > On Feb 2, 2014, at 21:59, Jay Kreps wrote: > > Yes, this is a good point, the admin api could depend on zookeeper. It does > today. That would not work in the existing clients package. > > -Jay > > >> On Sun, Feb 2, 2014 at

Re: code layout

2014-02-02 Thread Jay Kreps
Yes, this is a good point, the admin api could depend on zookeeper. It does today. That would not work in the existing clients package. -Jay On Sun, Feb 2, 2014 at 4:20 PM, Steve Morin wrote: > Would the admin api's potentially have different dependencies? > > > On Feb 1, 2014, at 15:06, Neha

Re: code layout

2014-02-02 Thread Steve Morin
Would the admin api's potentially have different dependencies? > On Feb 1, 2014, at 15:06, Neha Narkhede wrote: > > I like A. It will be simpler to maintain and evolve when we add the admin > APIs. > > > >> On Fri, Jan 31, 2014 at 7:32 PM, Steve Morin wrote: >> >> I like A or C >> >> I thi

Re: code layout

2014-02-02 Thread Guozhang Wang
I would vote for A just for simplicity of dependencies. On Sat, Feb 1, 2014 at 3:06 PM, Neha Narkhede wrote: > I like A. It will be simpler to maintain and evolve when we add the admin > APIs. > > > > On Fri, Jan 31, 2014 at 7:32 PM, Steve Morin wrote: > > > I like A or C > > > > I think it wil

Re: code layout

2014-02-01 Thread Neha Narkhede
I like A. It will be simpler to maintain and evolve when we add the admin APIs. On Fri, Jan 31, 2014 at 7:32 PM, Steve Morin wrote: > I like A or C > > I think it will be clearer for people to separate the two. > > > On Fri, Jan 31, 2014 at 3:29 PM, Jay Kreps wrote: > > > For the new producer

Re: code layout

2014-01-31 Thread Steve Morin
I like A or C I think it will be clearer for people to separate the two. On Fri, Jan 31, 2014 at 3:29 PM, Jay Kreps wrote: > For the new producer code we currently added the new module >clients > This builds the jar kafka-clients.jar. The core module should be renamed to > kafka-server and

code layout

2014-01-31 Thread Jay Kreps
For the new producer code we currently added the new module clients This builds the jar kafka-clients.jar. The core module should be renamed to kafka-server and producer kafka-server.jar. It is the intention that the server will end up depending on the clients but not vice versa (or we could ma

code layout for new clients

2014-01-24 Thread Jay Kreps
Hey All, Another topic worth discussing is how to layout code for the new producer and consumer as well as the common code they will share. There are really three questions: 1. Which top-level sub-modules/directories should we have (currently everything is under core, but presumably we want to spl