Re: Stream config in StreamPartitionAssignor

2018-07-10 Thread Boyang Chen
Sounds good. I will take a look at the doc and get back to you! From: Guozhang Wang Sent: Wednesday, July 11, 2018 2:07 AM To: dev Subject: Re: Stream config in StreamPartitionAssignor Boyang, I see. That makes sense. We should at least update the docs to

Re: Stream config in StreamPartitionAssignor

2018-07-10 Thread Guozhang Wang
ot Stream > Thread config? Hope I made myself clear to you. > > > Also yes, I could put some comment in the docs to let user use Consumer > config prefix if that could help. > > > Best, > > Boyang > > ____________ > From: Guozhang Wang >

Re: Stream config in StreamPartitionAssignor

2018-07-09 Thread Boyang Chen
From: Guozhang Wang Sent: Tuesday, July 10, 2018 5:35 AM To: dev Subject: Re: Stream config in StreamPartitionAssignor Hello Boyang, Thanks for brining this up. Currently since the StreamsPartitionAssingor can only be initiated within the Consumer instance, I think letting users to pass in t

Re: Stream config in StreamPartitionAssignor

2018-07-09 Thread Guozhang Wang
Hello Boyang, Thanks for brining this up. Currently since the StreamsPartitionAssingor can only be initiated within the Consumer instance, I think letting users to pass in the config values with prefix is the preferrable way, i.e. we can improve our docs to educate users about that. BTW I'm curiou

Stream config in StreamPartitionAssignor

2018-07-09 Thread Boyang Chen
Hey there, over the weekend I was debugging the streams configuration not passed within threads. I noticed that one of the code path from KafkaConsumer (L743) was to initialize the StreamPartitionAssignor: this.assignors = config.getConfiguredInstances( ConsumerConfig.PARTITION_ASSIGNM