Re: Review Request 36593: Patch for KAFKA-2347

2015-07-28 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36593/#review93352 --- Ship it! Ship It! - Guozhang Wang On July 18, 2015, 10:14 p.m.,

Re: Review Request 36593: Patch for KAFKA-2347

2015-07-21 Thread Grant Henke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36593/#review92410 --- Ship it! Ship It! - Grant Henke On July 18, 2015, 10:14 p.m., As

Re: Review Request 36593: Patch for KAFKA-2347

2015-07-18 Thread Ismael Juma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36593/#review92190 --- Ship it! Ship It! - Ismael Juma On July 18, 2015, 10:14 p.m., As

Re: Review Request 36593: Patch for KAFKA-2347

2015-07-18 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36593/ --- (Updated July 18, 2015, 10:14 p.m.) Review request for kafka. Bugs: KAFKA-234

Re: Review Request 36593: Patch for KAFKA-2347

2015-07-18 Thread Ismael Juma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36593/#review92179 --- There is a typo in the commit message: "ZookeeperConsuemrConnector".

Re: Review Request 36593: Patch for KAFKA-2347

2015-07-18 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36593/#review92178 --- Ship it! LGTM. Thanks. - Jiangjie Qin On July 18, 2015, 5:02 a.m

Review Request 36593: Patch for KAFKA-2347

2015-07-17 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36593/ --- Review request for kafka. Bugs: KAFKA-2347 https://issues.apache.org/jira/b