Re: Review Request 36590: Patch for KAFKA-2275

2015-07-21 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92557 --- Hey guys, I realized that most of this code has changed as the desig

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Ashish Singh
> On July 19, 2015, 1:11 a.m., Jason Gustafson wrote: > > > > Ashish Singh wrote: > Jason, thanks for your review! I looked into ConsumerNetworkClient/ > NetwrokClient, Metadata and Cluster classes. On receiving metadataUpdate, > cluster instance in metadata is updated. However, when a top

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92316 --- clients/src/main/java/org/apache/kafka/common/Cluster.java (line 19

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92315 --- clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsum

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92313 --- clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsum

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92309 --- clients/src/main/java/org/apache/kafka/clients/NetworkClient.java (

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92307 --- clients/src/main/java/org/apache/kafka/common/Cluster.java (line 18

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Jason Gustafson
> On July 19, 2015, 1:11 a.m., Jason Gustafson wrote: > > > > Ashish Singh wrote: > Jason, thanks for your review! I looked into ConsumerNetworkClient/ > NetwrokClient, Metadata and Cluster classes. On receiving metadataUpdate, > cluster instance in metadata is updated. However, when a top

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92304 --- clients/src/main/java/org/apache/kafka/common/Cluster.java (line 19

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92297 --- clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsum

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92302 --- clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.ja

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92301 --- clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsum

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92298 --- clients/src/main/java/org/apache/kafka/common/Cluster.java (line 19

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92299 --- clients/src/main/java/org/apache/kafka/common/Cluster.java (line 19

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92295 --- clients/src/main/java/org/apache/kafka/clients/consumer/MockConsume

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92291 --- clients/src/main/java/org/apache/kafka/common/Cluster.java (line 18

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92294 --- clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsum

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92293 --- clients/src/main/java/org/apache/kafka/clients/consumer/MockConsume

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92292 --- clients/src/main/java/org/apache/kafka/clients/consumer/MockConsume

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92290 --- clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsum

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92289 --- clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsum

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92288 --- clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsum

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92286 --- clients/src/main/java/org/apache/kafka/clients/Metadata.java (line

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Ashish Singh
> On July 19, 2015, 1:11 a.m., Jason Gustafson wrote: > > Jason, thanks for your review! I looked into ConsumerNetworkClient/ NetwrokClient, Metadata and Cluster classes. On receiving metadataUpdate, cluster instance in metadata is updated. However, when a topic is added by consumer, it is ad

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-20 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/ --- (Updated July 20, 2015, 5:44 p.m.) Review request for kafka. Bugs: KAFKA-2275

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-19 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review9 --- clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsum

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-18 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92194 --- clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsum

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-17 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/ --- (Updated July 18, 2015, 4:39 a.m.) Review request for kafka. Bugs: KAFKA-2275

Review Request 36590: Patch for KAFKA-2275

2015-07-17 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/ --- Review request for kafka. Bugs: KAFKA-2275 https://issues.apache.org/jira/b